James M Snell
e8eaaa7724
buffer: add buffer.transcode
...
Add buffer.transcode(source, from, to) method. Primarily uses ICU
to transcode a buffer's content from one of Node.js' supported
encodings to another.
Originally part of a proposal to add a new unicode module. Decided
to refactor the approach towrds individual PRs without a new module.
Refs: https://github.com/nodejs/node/pull/8075
PR-URL: https://github.com/nodejs/node/pull/9038
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-10-25 10:12:02 -07:00
James M Snell
1e4fafcb1a
2016-10-25, Version 7.0.0 (Current)
...
Notable Changes:
* Buffer
* Passing invalid input to Buffer.byteLength will now throw an error [#8946 ](https://github.com/nodejs/node/pull/8946 ).
* Calling Buffer without new is now deprecated and will emit a process warning [#8169 ](https://github.com/nodejs/node/pull/8169 ).
* Passing a negative number to allocUnsafe will now throw an error [#7079 ](https://github.com/nodejs/node/pull/7079 ).
* Child Process
* The fork and execFile methods now have stronger argument validation [#7399 ](https://github.com/nodejs/node/pull/7399 ).
* Cluster
* The worker.suicide method is deprecated and will emit a process warning [#3747 ](https://github.com/nodejs/node/pull/3747 ).
* Deps
* V8 has been updated to 5.4.500.36 [#8317 ](https://github.com/nodejs/node/pull/8317 ), [#8852 ](https://github.com/nodejs/node/pull/8852 ), [#9253 ](https://github.com/nodejs/node/pull/9253 ).
* NODE_MODULE_VERSION has been updated to 51 [#8808 ](https://github.com/nodejs/node/pull/8808 ).
* File System
* A process warning is emitted if a callback is not passed to async file system methods [#7897 ](https://github.com/nodejs/node/pull/7897 ).
* Intl
* Intl.v8BreakIterator constructor has been deprecated and will emit a process warning [#8908 ](https://github.com/nodejs/node/pull/8908 ).
* Promises
* Unhandled Promise rejections have been deprecated and will emit a process warning [#8217 ](https://github.com/nodejs/node/pull/8217 ).
* Punycode
* The `punycode` module has been deprecated [#7941 ](https://github.com/nodejs/node/pull/7941 ).
* URL
* An Experimental WHATWG URL Parser has been introduced [#7448 ](https://github.com/nodejs/node/pull/7448 ).
PR-URL: https://github.com/nodejs/node/pull/9099
2016-10-25 06:53:36 -07:00
Oliver Salzburg
0a8d0eaa9b
doc: mention case-insensitive env on windows
...
On Windows OS, environment variables are case-insensitive and are
treated likewise in NodeJS. This can be confusing and can lead
to hard-to-debug problems when moving code from one environment
to another.
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/9166
Fixes: https://github.com/nodejs/node/issues/9157
2016-10-25 11:33:05 +03:00
Ben Noordhuis
df29d9f500
doc: add performance warning to require.extensions
...
Discourage using require.extensions because it slows down the module
loader. The number of file system operations that the module system
has to perform in order to resolve a `require(...)` statement to a
filename is proportional to the number of registered extensions.
PR-URL: https://github.com/nodejs/node/pull/9196
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-24 22:50:41 +02:00
Marc Udoff
d3b1a2b4dd
src: add NODE_PRESERVE_SYMLINKS environment variable
...
Add a way through environment variables to set the --preserve-symlinks
flag. Any non-null value of NODE_PRESERVE_SYMLINKS will enable symlinks.
PR-URL: https://github.com/nodejs/node/pull/8749
Fixes: https://github.com/nodejs/node/issues/8509
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-10-24 22:13:08 +03:00
Gibson Fahnestock
5532a7adec
doc: change os x tag to macos
...
PR-URL: https://github.com/nodejs/node/pull/9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-10-24 07:14:04 -07:00
Gibson Fahnestock
e8c9f6f0be
doc: change solaris tag to smartos
...
PR-URL: https://github.com/nodejs/node/pull/9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-10-24 07:14:00 -07:00
Gibson Fahnestock
ab9b2fdbfb
doc: add teams for platform-specific issues
...
Specifies teams to cc for platform specific issues
- Existing teams: @nodejs/platform-arm, @nodejs/platform-freebsd, and
@nodejs/platform-windows
- New teams: @nodejs/platform-s390, @nodejs/platform-aix
- Changed name: @nodejs/platform-solaris -> @nodejs/platform-smartos
PR-URL: https://github.com/nodejs/node/pull/9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-10-24 07:13:53 -07:00
Gibson Fahnestock
c659c9d2ab
doc: add s390 and ppc architecture labels
...
Adds `s390` and `ppc` as Arch labels, and `aix` as an OS label.
PR-URL: https://github.com/nodejs/node/pull/9009
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-10-24 07:13:46 -07:00
Rod Machen
dcc9386183
doc: fixes formatting in process
...
Fixes several formatting errors in the process doc, including missing
link references, misplaced underscores, and a missing backtick.
Fixes: https://github.com/nodejs/node/issues/9223
PR-URL: https://github.com/nodejs/node/pull/9235
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2016-10-24 07:05:48 -07:00
Jeremiah Senkpiel
f1a3755cd1
doc: improve header styling for API docs
...
Sizes were mostly decided by using http://type-scale.com/
with the 1.250 "Major Third" scaling.
PR-URL: https://github.com/nodejs/node/pull/8811
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Phillip Johnsen <johphi@gmail.com >
2016-10-21 22:01:40 +01:00
Kyle E. Mitchell
6f7cdf7ef0
doc: clarify fs.link and fs.linkSync arguments
...
Clarifies documentation by replacing the argument names `srcpath`
and `dstpath` with more descriptive `existingPath` and `newPath`,
reflecting how POSIX describes `link()`.
PR-URL: https://github.com/nodejs/node/pull/9145
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2016-10-21 08:01:07 -07:00
Myles Borins
4b65a65e75
2016-10-19, Version 6.9.1 'Boron' (LTS) Release
...
Notable changes:
* streams: Fix a regression introduced in v6.8.0 in readable stream
that caused unpipe to remove the wrong stream (Anna Henningsen)
PR-URL: https://github.com/nodejs/node/pull/9186
2016-10-19 23:30:15 +01:00
Michael Dawson
30f9790701
doc: add CTC meeting minutes for 2016-10-12
...
PR-URL: https://github.com/nodejs/node/pull/9070
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-19 18:11:19 -04:00
Evan Lucas
ca3c8a9d55
doc: fix header level for crypto.constants
...
The header level for crypto.constants was off by one.
PR-URL: https://github.com/nodejs/node/pull/9187
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-19 08:37:40 -07:00
Rich Trott
add885416f
doc: add ctc-review label information
...
PR-URL: https://github.com/nodejs/node/pull/9072
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-10-19 08:35:15 -07:00
Rod Vagg
bb173f931a
crypto: fix openssl.cnf FIPS handling & testing
...
* Add documentation for `--openssl-conf=file`.
* Fix openssl.cnf loading and OpenSSL init ordering
* Fix FIPS tests so `OPENSSL_CONF` is not longer usable but
`--openssl-conf` is
PR-URL: https://github.com/nodejs/node-private/pull/82
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-10-19 14:25:23 +11:00
Rod Vagg
0e6750d1cd
2016-10-18 Node.js v6.9.0 'Boron' (LTS) Release
...
This release marks the transition of Node.js v6 into Long Term Support
(LTS) with the codename 'Boron'. The v6 release line now moves in to
"Active LTS" and will remain so until April 2018. After that time it
will move in to "Maintenance" until end of life in April 2019.
This is also a security release. All Node.js users should consult the
security release summary at
https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/
for details on patched vulnerabilities.
Notable changes:
* crypto: Don't automatically attempt to load an OpenSSL configuration
file, from the `OPENSSL_CONF` environment variable or from the
default location for the current platform. Always triggering a
configuration file load attempt may allow an attacker to load
compromised OpenSSL configuration into a Node.js process if they are
able to place a file in a default location. (Fedor Indutny, Rod Vagg)
* node: Introduce the `process.release.lts` property, set to `"Boron"`.
This value is `"Argon"` for v4 LTS releases and `undefined` for all
other releases. (Rod Vagg)
* V8: Backport fix for CVE-2016-5172, an arbitrary memory read.
The parser in V8 mishandled scopes, potentially allowing an attacker
to obtain sensitive information from arbitrary memory locations via
crafted JavaScript code. This vulnerability would require an
attacker to be able to execute arbitrary JavaScript code in a
Node.js process. (Rod Vagg)
* **v8_inspector**: Generate a UUID for each execution of the
inspector. This provides additional security to prevent unauthorized
clients from connecting to the Node.js process via the v8_inspector
port when running with `--inspect`. Since the debugging protocol
allows extensive access to the internals of a running process, and
the execution of arbitrary code, it is important to limit
connections to authorized tools only. Vulnerability originally
reported by Jann Horn. (Eugene Ostroukhov)
PR-URL: https://github.com/nodejs/node-private/pull/81
2016-10-19 04:22:07 +11:00
Rod Vagg
83c7a8897c
2016-10-18, Version 4.6.1 'Argon' (LTS)
...
This is a security release. All Node.js users should consult the security
release summary at
https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/
for details on patched vulnerabilities.
Notable changes:
* c-ares: fix for single-byte buffer overwrite, CVE-2016-5180, more
information at https://c-ares.haxx.se/adv_20160929.html (Daniel Stenberg)
PR-URL: https://github.com/nodejs/node/pull/9153
2016-10-19 04:01:02 +11:00
Rod Vagg
107f77594b
2016-10-18 Version 0.10.48 (Maintenance) Release
...
This is a security release. All Node.js users should consult the
security release summary at
https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/
for details on patched vulnerabilities.
Notable changes:
* c-ares: fix for single-byte buffer overwrite, CVE-2016-5180, more
information at https://c-ares.haxx.se/adv_20160929.html
(Rod Vagg)
PR-URL: https://github.com/nodejs/node/pull/9154
2016-10-19 04:00:57 +11:00
Rod Vagg
26e2f0d9e4
2016-10-18 Version 0.12.17 (Maintenance) Release
...
This is a security release. All Node.js users should consult the
security release summary at
https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/
for details on patched vulnerabilities.
Notable changes:
* c-ares: fix for single-byte buffer overwrite, CVE-2016-5180, more
information at https://c-ares.haxx.se/adv_20160929.html
(Daniel Stenberg)
PR-URL: https://github.com/nodejs/node/pull/9147
2016-10-19 04:00:49 +11:00
Parambir Singh
1fcd088fd9
doc: fix typo in zlib.md
...
Change 'methods with throw an error' to 'methods will throw an error'.
PR-URL: https://github.com/nodejs/node/pull/9123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Teddy Katz <teddy.katz@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2016-10-17 09:24:50 -07:00
Indrek Ardel
7f02fecab1
doc: further improve child_process doc types
...
PR-URL: https://github.com/nodejs/node/pull/9095
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-10-17 09:09:32 -07:00
Benji Marinacci
3c4349e8a2
doc: edit Stream api grammar
...
Sections:
- Introduction
- Orginization of this Document
- Object Mode
- Buffering
- API for Stream Implementers
PR-URL: https://github.com/nodejs/node/pull/9100
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-10-17 09:05:42 -07:00
marzelin
cb87748023
doc: improved example for http.get
...
PR-URL: https://github.com/nodejs/node/pull/9065
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-10-17 09:01:19 -07:00
scott stern
3d294cf0c4
doc: update reference to list hash algorithms in crypto.md
...
PR-URL: https://github.com/nodejs/node/pull/9043
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-10-17 08:54:47 -07:00
John Vilk
f478b46a00
doc: specify that errno is a number, not a string
...
The documentation erroneously described the errno property as an alias
for the code property, but that is not the case in the implementation.
errno is the error code of the error as a number, and code is the error
code of the error as a string.
PR-URL: https://github.com/nodejs/node/pull/9007
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2016-10-16 20:43:21 +02:00
Evan Lucas
113c697ded
2016-10-14, Version 6.8.1 (Current)
...
* build: Fix building with shared zlib. (Bradley T. Hughes) [#9077 ](https://github.com/nodejs/node/pull/9077 )
* stream: fix `Writable` subclass instanceof checks (Anna Henningsen) [#9088 ](https://github.com/nodejs/node/pull/9088 )
* timers: fix regression with clearImmediate() (Brian White) [#9086 ](https://github.com/nodejs/node/pull/9086 )
PR-URL: https://github.com/nodejs/node/pull/9104
2016-10-14 19:36:43 -05:00
Ilya Frolov
fcee4d4ad9
doc: highlight deprecated API in ToC
...
Highlight deprecated API methods/properties in "Table of Contents" for
increasing understandability. Adapted code to eslint standards.
PR-URL: https://github.com/nodejs/node/pull/7189
Fixes: https://github.com/nodejs/nodejs.org/issues/772
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2016-10-14 07:30:38 +02:00
jessicaquynh
c2984ce19a
doc: explain why GitHub merge button is not used
...
Adds documentation and explicit reasons on why
the GitHub web interface button is not used. This was
explained in the referenced issue by @TheAlphaNerd.
Fixes: https://github.com/nodejs/node/issues/8893
PR-URL: https://github.com/nodejs/node/pull/9044
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-10-13 21:23:36 -04:00
Nikolai Vavilov
aa4698b66d
doc: fix typo
...
PR-URL: https://github.com/nodejs/node/pull/9089
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-10-14 01:41:53 +03:00
Jeremiah Senkpiel
e4ee09a5b3
2016-10-12, Version 6.8.0 (Current)
...
* fs:
- `SyncWriteStream` now inherits from `Stream.Writable`. (Anna
Henningsen) https://github.com/nodejs/node/pull/8830
- Practically, this means that when stdio is piped to a file,
stdout and stderr will still be `Writable` streams.
- `fs.existsSync()` has been undeprecated. `fs.exists()` remains
deprecated. (Dan Fabulich) https://github.com/nodejs/node/pull/8364
* http: `http.request()` now accepts a `timeout` option. (Rene Weber)
https://github.com/nodejs/node/pull/8101
* module: The module loader now maintains its own realpath cache. (Anna
Henningsen) https://github.com/nodejs/node/pull/8100
* npm: Upgraded to 3.10.8 (Kat Marchán)
https://github.com/nodejs/node/pull/8706
* stream: `Duplex` streams now show proper `instanceof
Stream.Writable`. (Anna Henningsen)
https://github.com/nodejs/node/pull/8834
* timers: Improved `setTimeout`/`Interval` performance by up to 22%.
(Brian White) https://github.com/nodejs/node/pull/8661
PR-URL: https://github.com/nodejs/node/pull/9034
2016-10-12 16:16:56 -04:00
Evan Lucas
3d54ea4304
doc: fix broken links in changelogs
...
Some commit links in the changelogs were pointing to incorrect/missing
shas.
PR-URL: https://github.com/nodejs/node/pull/8122
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-10-11 16:41:45 -05:00
Timothy Gu
52c7f9d221
doc: revise http documentation
...
PR-URL: https://github.com/nodejs/node/pull/8486
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-11 09:54:39 -07:00
Brian White
c9dade48b4
buffer: make byteLength throw on invalid input
...
PR-URL: https://github.com/nodejs/node/pull/8946
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Teddy Katz <teddy.katz@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-10-10 12:57:27 -07:00
Anna Henningsen
2a4b068aca
stream: proper instanceof for Writables
...
Use `[Symbol.hasInstance]()` to return `true` when asking for
`new Duplex() instanceof Writable`.
PR-URL: https://github.com/nodejs/node/pull/8834
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com >
2016-10-10 18:05:23 +02:00
Alex Jordan
90cd39f3ad
doc: make node(1) more consistent with tradition
...
* Added traditional BUGS, AUTHORS and COPYRIGHT sections
* Fixed some minor issues with the IRC links
PR-URL: https://github.com/nodejs/node/pull/8902
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-08 08:49:42 -07:00
Christopn Noelke
23b9625c84
doc: add example for file existence with fs.stat
...
Add an example on how to test if a file exists with fs.stat.
Also add a link to the Common System Errors.
Fixes: https://github.com/nodejs/issues/6752
PR-URL: https://github.com/nodejs/node/pull/8585
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
2016-10-07 09:50:13 -07:00
Luigi Pinca
bd0bedb86a
doc: add added: information for globals
...
Ref: https://github.com/nodejs/node/issues/6578
PR-URL: https://github.com/nodejs/node/pull/8901
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-10-06 23:55:14 +02:00
AnnaMag
bf0bcf463d
doc: change ./node to node in debugger.md
...
Fixes: https://github.com/nodejs/node/issues/8942
PR-URL: https://github.com/nodejs/node/pull/8943
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-10-06 23:45:12 +02:00
Josh Gavant
d463a70c4b
doc: add CTC meeting minutes 2016-09-07
...
PR-URL: https://github.com/nodejs/node/pull/8499
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-06 14:37:03 -07:00
ss22ever
3945943d58
doc: fixup link in fs.md
...
PR-URL: https://github.com/nodejs/node/pull/8940
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-10-06 11:20:03 -07:00
Dan Fabulich
7b5ffa46fe
fs,doc: undeprecate existsSync
...
This has been dragged through various long discussions and has been
elevated to the CTC multiple times.
As noted in
https://github.com/nodejs/node/pull/7455#issuecomment-228961530 ,
while this API is still generally considered an anti-pattern, there are
still use-cases it is best suited for, such as checking if a git rebase
is in progress by looking if ".git/rebase-apply/rebasing" exists.
The general consensus is to undeprecate just the sync version, given
that the async version still has the "arguments order inconsistency"
problem.
The consensus at the two last CTC meetings this came up at was also
to undeprecate existsSync() but keep exists() deprecated.
See: https://github.com/nodejs/node/issues/8242 &
https://github.com/nodejs/node/issues/8330
(Description write-up by @Fishrock123)
Fixes: https://github.com/nodejs/node/issues/1592
Refs: https://github.com/nodejs/node/pull/4217
Refs: https://github.com/nodejs/node/pull/7455
PR-URL: https://github.com/nodejs/node/pull/8364
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2016-10-05 15:10:40 -04:00
Bryan Bess
37238062a0
doc: fix markdown formatting in url.md
...
Tangentially related to https://github.com/nodejs/node/pull/7817
PR-URL: https://github.com/nodejs/node/pull/8933
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2016-10-05 11:36:03 -04:00
Niklas Ingholt
3326081bd4
doc: recommend using port 0 instead of common.PORT
...
In the 'writing_tests' guide it is recommended to use common.PORT
instead of an arbitrary value, but the recommendation is to use
port 0 instead and the docs should reflect that.
PR-URL: https://github.com/nodejs/node/pull/8694
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-10-04 01:05:44 +03:00
Josh Gavant
15bd66be1a
doc: add CTC meeting minutes 2016-09-14
...
PR-URL: https://github.com/nodejs/node/pull/8726
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-10-03 14:29:45 +02:00
Josh Gavant
6e92ae27f7
doc: add CTC meeting minutes 2016-09-21
...
PR-URL: https://github.com/nodejs/node/pull/8727
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
2016-10-03 14:03:58 +02:00
Franziska Hinkelmann
bdb801261a
doc: add example for running with v8-inspector
...
Add example to show what running Node.js with `--inspect`
should look like.
Some IDEs do not show the link when running with `--inspect`.
This example hints to what the full output looks like.
PR-URL: https://github.com/nodejs/node/pull/8845
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2016-09-30 08:39:50 -07:00
Franziska Hinkelmann
21b37b23c1
doc: fix typo in repl doc
...
PR-URL: https://github.com/nodejs/node/pull/8826
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-09-30 07:58:34 -07:00
Rich Trott
cad0423ce4
doc: encourage 2FA before onboarding
...
In the onboarding document, add a note to ask the new Collaborator if
they are using two-factor authentication on their GitHub account. If
they are not, suggest that they enable it as their account will have
elevated privileges in many of the Node.js repositories.
PR-URL: https://github.com/nodejs/node/pull/8776
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu >
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-09-28 17:23:22 -07:00