 Rich Trott
|
c4b5a451e3
|
test: mitigate flaky test-debug-no-context
Change test so that it passes on the occasional win10 access violation.
The workaround here can be undone when issue 5268 is resolved.
The test still detects the defect it was written to detect. There are
two assertions that detect the defect and only one was disabled.
Ref: https://github.com/nodejs/node/issues/5268
Fixes: https://github.com/nodejs/node/issues/4343
PR-URL: https://github.com/nodejs/node/pull/5269
Reviewed-By: James M Snell <jasnell@gmail.com>
|
2016-02-18 20:21:50 -08:00 |
|
|
Rich Trott
|
32f6098eef
|
src,test,tools: modify for more stringent linting
ESLint 2.1.0 is coming. Some lint rules have been tightened.
PR-URL: https://github.com/nodejs/node/pull/5214
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
|
2016-02-18 10:11:26 -08:00 |
|
|
cjihrig
|
efd33a2a9a
|
test: update arrow function style
This commit applies new arrow function linting rules across the
codebase. As it turns out, the only offenders were in the test
directory.
PR-URL: https://github.com/nodejs/node/pull/4813
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
|
2016-01-28 11:31:31 -05:00 |
|
|
Ben Noordhuis
|
25776f3ea1
|
debugger: guard against call from non-node context
Fix a segmentation fault when the debug message handler was called from
a context without an associated `node::Environment`.
Fixes: https://github.com/nodejs/node/issues/4261
Fixes: https://github.com/nodejs/node/issues/4322
PR-URL: https://github.com/nodejs/node/pull/4328
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
2015-12-17 08:42:10 -08:00 |
|