Ben Noordhuis
d7087df4da
src: use RAII for mutexes and condition variables
...
We will be introducing many more critical sections in the upcoming
multi-isolate changes, so let's make manual synchronization a thing
of the past.
PR-URL: https://github.com/nodejs/node/pull/7334
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-06-21 10:29:14 +02:00
Ben Noordhuis
aac79dfd78
src: use stack-allocated Environment instances
...
Makes it easier to reason about the lifetime of the Environment object.
PR-URL: https://github.com/nodejs/node/pull/7090
Refs: https://github.com/nodejs/node/pull/7082
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-06-02 19:38:49 +02:00
Ben Noordhuis
27e84ddd4e
lib,src: clean up ArrayBufferAllocator
...
Remove the direct dependency on node::Environment (which is per-context)
from node::ArrayBufferAllocator (which is per-isolate.)
Contexts that want to toggle the zero fill flag, now do so through a
field that is owned by ArrayBufferAllocator. Better, still not great.
PR-URL: https://github.com/nodejs/node/pull/7082
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-06-01 09:29:51 +02:00
Ben Noordhuis
334ef4f19d
lib,src: drop dependency on v8::Private::ForApi()
...
Said function requires that a v8::Context has been entered first,
introducing a chicken-and-egg problem when creating the first context.
PR-URL: https://github.com/nodejs/node/pull/7082
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-06-01 09:29:49 +02:00
Ben Noordhuis
c3cd453cba
src: make IsolateData creation explicit
...
Make it easier to reason about the lifetime and the ownership of the
IsolateData instance by making its creation explicit and by removing
reference counting logic.
The creator of the Environment is now responsible for passing in the
IsolateData instance and for keeping it alive as long as the Environment
is alive.
PR-URL: https://github.com/nodejs/node/pull/7082
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-06-01 09:29:47 +02:00
Ben Noordhuis
a7581d0859
src: replace ARRAY_SIZE with typesafe arraysize
...
To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer)
from happening again.
PR-URL: https://github.com/nodejs/node/pull/5969
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-04-05 11:37:02 +02:00
Michaël Zasso
ad0ce57432
src: fix NewInstance deprecation warnings
...
PR-URL: https://github.com/nodejs/node/pull/4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com >
2016-03-03 20:35:20 -08:00
Michaël Zasso
d515a3f4b4
src: replace usage of deprecated GetDebugContext
...
PR-URL: https://github.com/nodejs/node/pull/5159
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-03-03 20:35:20 -08:00
Michaël Zasso
4417f99432
src: replace usage of deprecated SetMessageHandler
...
PR-URL: https://github.com/nodejs/node/pull/5159
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-03-03 20:35:20 -08:00
Chris911
e20abb715e
src: remove no longer relevant comments
...
PR-URL: https://github.com/nodejs/node/pull/4843
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Fedor Indutny <fedor@indutny.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-02-01 21:28:06 +01:00
Ben Noordhuis
25776f3ea1
debugger: guard against call from non-node context
...
Fix a segmentation fault when the debug message handler was called from
a context without an associated `node::Environment`.
Fixes: https://github.com/nodejs/node/issues/4261
Fixes: https://github.com/nodejs/node/issues/4322
PR-URL: https://github.com/nodejs/node/pull/4328
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2015-12-17 08:42:10 -08:00
Michaël Zasso
4abc896a82
src: replace usage of v8::Handle with v8::Local
...
v8::Handle is deprecated: https://codereview.chromium.org/1224623004
PR-URL: https://github.com/nodejs/io.js/pull/2202
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2015-09-06 21:38:05 +10:00
Ben Noordhuis
9a03ae6356
src: enable v8 deprecation warnings and fix them
...
Turn on V8 API deprecation warnings. Fix up the no-arg Isolate::New()
calls in src/node.cc and src/debug-agent.cc.
PR-URL: https://github.com/nodejs/io.js/pull/2091
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-09-06 21:38:05 +10:00
Ben Noordhuis
38dc0cd8f4
src: switch from QUEUE to intrusive list
...
This commit also breaks up req_wrap.h into req-wrap.h and req-wrap-inl.h
to work around a circular dependency issue in env.h.
PR-URL: https://github.com/iojs/io.js/pull/667
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-02-11 23:06:29 +01:00
Ben Noordhuis
b1dcaadb0e
src: replace NULL with nullptr in debug agent
...
Update the debug agent to conform to the code style in src/.
2014-11-03 13:19:17 +01:00
Ben Noordhuis
29d7fd6bb8
src: move debug agent from deps/ to src/
...
There is not much point in keeping it a separate project because it
doesn't build standalone, plus it makes applying changes to core more
difficult because of the implicit dependency on header files in src/.
2014-11-03 12:08:04 +01:00