YoonSoo_Shin
80a7e7600c
lib: avoid for of loop and remove unnecessary variable in zlib
...
removed the unnecessary declaration of 'i' in the _final method scope
and changed the for of loop to a for loop
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration
PR-URL: https://github.com/nodejs/node/pull/54258
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2024-08-12 03:53:12 +00:00
Kohei Ueno
746213ec7a
inspector: support Network.loadingFailed event
...
PR-URL: https://github.com/nodejs/node/pull/54246
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-11 11:42:01 +00:00
Michaël Zasso
298ff4fdb1
tty: initialize winSize array with values
...
Assigning to a holey array in the native layer may crash if it has
getters that throw.
Refs: https://github.com/nodejs/node/issues/54186
PR-URL: https://github.com/nodejs/node/pull/54281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-08-11 06:32:13 +00:00
HEESEUNG
90d91abbfe
console: use validateOneOf for colorMode validation
...
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.
PR-URL: https://github.com/nodejs/node/pull/54245
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-08-10 01:49:40 +00:00
Stephen Belanger
7366808b85
lib: improve async_context_frame structure
...
PR-URL: https://github.com/nodejs/node/pull/54239
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2024-08-09 19:44:42 +00:00
Marco Ippolito
3cbeed88d9
module: refactor ts parser loading
...
PR-URL: https://github.com/nodejs/node/pull/54243
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-08-09 06:46:58 +00:00
Pietro Marchini
88bac52b23
test_runner: fix erroneous diagnostic warning when only: false
...
Co-author: rstagi <r.stagi96@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/54116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-08-08 05:50:32 +00:00
Jonas
3ed9f989b8
fs: remove unnecessary option argument validation
...
PR-URL: https://github.com/nodejs/node/pull/53958
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-08-06 18:43:41 +00:00
Fedor Indutny
78150f3e9c
lib: fix unhandled errors in webstream adapters
...
WebStream's Readable controller does not tolerate `.close()` being
called after an `error`. However, when wrapping a Node's Readable stream
it is possible that the sequence of events leads to `finished()`'s
callback being invoked after such `error`.
In order to handle this, in this change we call the `finished()` handler
earlier when controller is canceled, and always handle this as an error
case.
Fix: https://github.com/nodejs/node/issues/54205
PR-URL: https://github.com/nodejs/node/pull/54206
Fixes: https://github.com/nodejs/node/issues/54205
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-06 18:34:35 +00:00
Hüseyin Açacak
c852e222cb
path: fix relative on Windows
...
PR-URL: https://github.com/nodejs/node/pull/53991
Fixes: https://github.com/nodejs/node/issues/27534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-08-06 09:40:23 +00:00
Sung Ye In
5bfebfec88
test_runner: make mock_loader not confuse CJS and ESM resolution
...
PR-URL: https://github.com/nodejs/node/pull/53846
Fixes: https://github.com/nodejs/node/issues/53807
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-08-06 11:24:24 +02:00
Kohei Ueno
3616ace637
inspector: provide detailed info to fix DevTools frontend errors
...
PR-URL: https://github.com/nodejs/node/pull/54156
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-05 12:30:45 +00:00
jakecastelli
fafc845089
stream: make checking pendingcb on WritableStream backward compatible
...
PR-URL: https://github.com/nodejs/node/pull/54142
Fixes: https://github.com/nodejs/node/issues/54131
Refs: https://github.com/nodejs/node/issues/54131
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2024-08-05 12:30:29 +00:00
Marek Piechut
a8166880f1
watch: reload changes in contents of --env-file
...
Make sure we watch and reload on env file changes.
Ignore env file in parent process, so child process can reload
current vars when we recreate it.
Fixes: https://github.com/nodejs/node/issues/54001
PR-URL: https://github.com/nodejs/node/pull/54109
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-08-05 10:41:33 +00:00
Colin Ihrig
ca2ed88f94
test_runner: remove outdated comment
...
Network imports were removed, so remove the comment.
Refs: https://github.com/nodejs/node/pull/53822
PR-URL: https://github.com/nodejs/node/pull/54146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-08-05 14:54:52 +09:30
YoonSoo_Shin
e6ee6e2901
lib: fix typos in comments within internal/streams
...
fixed typos in comments within the internal/streams directory.
PR-URL: https://github.com/nodejs/node/pull/54093
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2024-08-05 01:58:40 +00:00
Roberto Simonini
a3cd290f24
buffer: add JSDoc to blob bytes method
...
PR-URL: https://github.com/nodejs/node/pull/54117
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2024-08-05 00:29:07 +00:00
Colin Ihrig
67f713731c
test_runner: run after hooks even if test is aborted
...
If a test is run, but aborted, any after hooks should still be
run, as they may need to perform cleanup.
PR-URL: https://github.com/nodejs/node/pull/54151
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Raz Luvaton <rluvaton@gmail.com >
2024-08-04 15:56:04 +00:00
Marco Ippolito
5d6c76adee
module: fix strip-types interaction with detect-module
...
PR-URL: https://github.com/nodejs/node/pull/54164
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-08-03 17:15:11 +00:00
Robert Nagy
acbd0be0da
buffer: faster type check
...
Also add support for any TypedArray as target.
PR-URL: https://github.com/nodejs/node/pull/54088
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-03 17:15:03 +00:00
Rafael Gonzaga
358ff748ea
lib,permission: support Buffer to permission.has
...
PR-URL: https://github.com/nodejs/node/pull/54104
Fixes: https://github.com/nodejs/node/issues/54100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-08-03 16:46:57 +00:00
Stephen Belanger
d1229eeca4
lib: rewrite AsyncLocalStorage without async_hooks
...
PR-URL: https://github.com/nodejs/node/pull/48528
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2024-08-02 19:44:20 +00:00
Robert Nagy
76c8ba9d9b
buffer: use native copy impl
...
PR-URL: https://github.com/nodejs/node/pull/54087
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
2024-08-02 09:19:41 +00:00
Michaël Zasso
00c0644747
module: remove outdated comment
...
Refs: https://github.com/nodejs/node/pull/53822
PR-URL: https://github.com/nodejs/node/pull/54118
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2024-08-01 12:41:00 +02:00
Rich Trott
e2b7e41e23
child_process: remove unused internal event
...
Tests pass without this event being emitted. Remove it.
PR-URL: https://github.com/nodejs/node/pull/53793
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2024-08-01 03:07:10 +00:00
jakecastelli
1fd170a7fc
stream: throw TypeError when criteria fulfilled in getIterator
...
PR-URL: https://github.com/nodejs/node/pull/53825
Fixes: https://github.com/nodejs/node/issues/53819
Refs: https://github.com/nodejs/node/issues/53819
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2024-08-01 02:00:47 +00:00
Early Riser
b4fd1fd63f
url: improve resolveObject with ObjectAssign
...
PR-URL: https://github.com/nodejs/node/pull/54092
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
2024-07-31 06:17:59 +00:00
Robert Nagy
e7edcf38cd
buffer: use faster integer argument check
...
PR-URL: https://github.com/nodejs/node/pull/54089
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-30 22:29:51 +00:00
Benjamin Pasero
f9f9a421a8
path: use the correct name in validateString
...
The parameter was renamed from `ext` to `suffix`
but not in the `validateString` call.
PR-URL: https://github.com/nodejs/node/pull/53669
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-30 16:59:47 +02:00
Vinicius Lourenço
890760b8e5
console: fix issues with frozen intrinsics
...
PR-URL: https://github.com/nodejs/node/pull/54070
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-07-30 04:38:21 +00:00
Marco Ippolito
cf9a8140aa
module: fix extensionless typescript in cjs loader
...
PR-URL: https://github.com/nodejs/node/pull/54062
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-29 19:43:28 +00:00
Joyee Cheung
be7a0c5780
module: do not warn for typeless package.json when there isn't one
...
It was intended that warnings should only be emitted for an
existing package.json without a type. This fixes a confusing
warning telling users to update /package.json when there are
no package.json on the lookup path at all, like this:
[MODULE_TYPELESS_PACKAGE_JSON] Warning: ... parsed as an ES module
because module syntax was detected; to avoid the performance penalty
of syntax detection, add "type": "module" to /package.json
Drive-by: update the warning message to be clear about
reparsing and make it clear what's actionable.
PR-URL: https://github.com/nodejs/node/pull/54045
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-29 17:46:41 +00:00
Vinicius Lourenço
01cf9bccdf
lib: support dynamic trace events on debugWithTimer
...
PR-URL: https://github.com/nodejs/node/pull/53913
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-07-28 17:20:38 +00:00
Rafael Gonzaga
5ac969fdca
lib,src: drop --experimental-network-imports
...
PR-URL: https://github.com/nodejs/node/pull/53822
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2024-07-28 16:33:05 +00:00
e4263dad96
assert: use isError instead of instanceof in innerOk
...
Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de >
Co-Authored-By: Nihar Phansalkar <phansalkarnihar@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/53980
Fixes: https://github.com/nodejs/node/issues/50780
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-07-28 13:13:59 +00:00
Kohei Ueno
69a69f6ca3
http: add diagnostics channel http.client.request.error
...
PR-URL: https://github.com/nodejs/node/pull/54054
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
2024-07-28 09:57:38 +00:00
Emil Tayeb
2b5856e466
test_runner: switched to internal readline interface
...
Switched to using internal interface after
PR-URL: https://github.com/nodejs/node/pull/54000
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-28 06:22:10 +00:00
Colin Ihrig
14e7eb34f4
test_runner: remove redundant bootstrap boolean
...
The test runner bootstrap process awaits a Promise and then sets
a boolean flag. This commit consolidates the Promise and boolean
into a single value. This commit also ensures that the globalRoot
test is always assigned in createTestTree() in order to better
consolidate the CLI/run() and non-CLI configuration.
PR-URL: https://github.com/nodejs/node/pull/54013
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-27 13:27:03 +00:00
Austin Wright
b32732b1ee
stream: expose DuplexPair API
...
PR-URL: https://github.com/nodejs/node/pull/34111
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-07-26 08:09:23 +00:00
Aksinya Bykova
049c894350
test_runner: do not throw on mocked clearTimeout()
...
PR-URL: https://github.com/nodejs/node/pull/54005
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
2024-07-25 15:26:00 +00:00
HEESEUNG
87e18a7b37
lib: optimize copyError with ObjectAssign in primordials
...
optimized the copyError function by using ObjectAssign from primordials.
this change replaces the for-loop with ObjectAssign, which improves
memory usage and performance.
this change updates the copyError function in internal/assert.js to
use ObjectAssign for copying properties.
PR-URL: https://github.com/nodejs/node/pull/53999
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
2024-07-25 12:12:35 +00:00
Marco Ippolito
35f92d953c
module: add --experimental-strip-types
...
PR-URL: https://github.com/nodejs/node/pull/53725
Refs: https://github.com/nodejs/loaders/issues/217
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruy Adorno <ruy@vlt.sh >
2024-07-24 16:30:06 +00:00
Matteo Collina
2208948e1b
test_runner: fix support watch with run(), add globPatterns option
...
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/53866
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-24 13:11:20 +00:00
YieldRay
42fd6401c2
fs: ensure consistency for mkdtemp in both fs and fs/promises
...
Port changes for mkdtemp from lib/fs.js to lib/internal/fs/promise.js,
ensuring consistent behavior.
Refs: https://github.com/nodejs/node/pull/51078
PR-URL: https://github.com/nodejs/node/pull/53776
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
2024-07-23 11:56:18 +00:00
Aviv Keller
fa0fde7157
process: unify experimental warning messages
...
PR-URL: https://github.com/nodejs/node/pull/53704
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-23 11:56:03 +00:00
Giovanni
8536b674d8
test_runner: added colors to dot reporter
...
PR-URL: https://github.com/nodejs/node/pull/53450
Fixes: https://github.com/nodejs/node/issues/51770
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-23 12:39:10 +03:00
Eddie Abbondanzio
b19a950102
test_runner: cleanup global event listeners after run
...
PR-URL: https://github.com/nodejs/node/pull/53878
Fixes: https://github.com/nodejs/node/issues/53868
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2024-07-23 06:49:52 +00:00
Yagiz Nizipli
88027e84d8
fs: optimize fs.cpSync js calls
...
PR-URL: https://github.com/nodejs/node/pull/53614
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 16:00:39 +00:00
Colin Ihrig
ea837a0db9
test_runner: refactor coverage to pass in config options
...
This commit updates the test runner's code coverage so that
coverage options are explicitly passed in instead of pulled
from command line options.
PR-URL: https://github.com/nodejs/node/pull/53931
Refs: https://github.com/nodejs/node/issues/53924
Refs: https://github.com/nodejs/node/issues/53867
Refs: https://github.com/nodejs/node/pull/53866
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 04:26:43 +00:00
Ehsan Khakifirooz
aca31b8e0f
lib: improve cluster/primary code
...
PR-URL: https://github.com/nodejs/node/pull/53756
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-07-21 22:23:17 +00:00