Kohei Ueno
746213ec7a
inspector: support Network.loadingFailed event
...
PR-URL: https://github.com/nodejs/node/pull/54246
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-11 11:42:01 +00:00
HEESEUNG
90d91abbfe
console: use validateOneOf for colorMode validation
...
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.
PR-URL: https://github.com/nodejs/node/pull/54245
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-08-10 01:49:40 +00:00
Isaac-yz-Liu
30f6c56e03
test: fix timeout not being cleared
...
PR-URL: https://github.com/nodejs/node/pull/54242
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
2024-08-09 05:42:10 +00:00
Antoine du Hamel
9e6c526f6c
test: refactor test-runner-module-mocking
...
PR-URL: https://github.com/nodejs/node/pull/54233
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2024-08-08 18:27:08 +00:00
Pietro Marchini
88bac52b23
test_runner: fix erroneous diagnostic warning when only: false
...
Co-author: rstagi <r.stagi96@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/54116
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-08-08 05:50:32 +00:00
Chengzhong Wu
2bcf9995d2
src: skip inspector wait in internal workers
...
Internal workers are essential to load user scripts and bootstrapped
with internal entrypoints. They should not be waiting for inspectors
even when `--inspect-brk` and `--inspect-wait` were specified, and avoid
blocking main thread to bootstrap.
IsolateData can be created with a specified PerIsolateOptions instead of
creating a copy from the per_process namespace. This also avoids
creating a copy bypassing the parent env's modified options, like
creating a worker thread from a worker thread.
PR-URL: https://github.com/nodejs/node/pull/54219
Fixes: https://github.com/nodejs/node/issues/53681
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-07 21:56:59 +00:00
Luigi Pinca
e0634f58ab
test: use assert.{s,deepS}trictEqual()
...
Use `asset.strictEqual()` and `asset.deepStrictEqual()` in
`test/parallel/test-tls-set-sigalgs.js`.
PR-URL: https://github.com/nodejs/node/pull/54208
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-08-06 20:12:31 +00:00
Fedor Indutny
78150f3e9c
lib: fix unhandled errors in webstream adapters
...
WebStream's Readable controller does not tolerate `.close()` being
called after an `error`. However, when wrapping a Node's Readable stream
it is possible that the sequence of events leads to `finished()`'s
callback being invoked after such `error`.
In order to handle this, in this change we call the `finished()` handler
earlier when controller is canceled, and always handle this as an error
case.
Fix: https://github.com/nodejs/node/issues/54205
PR-URL: https://github.com/nodejs/node/pull/54206
Fixes: https://github.com/nodejs/node/issues/54205
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mattias Buelens <mattias@buelens.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-06 18:34:35 +00:00
sungpaks
359b4284bc
test: add subtests to test-node-run
...
Added two subtests to test-node-run. First one is about unparsable
package.json file, and the second one is about there is no "script"
fields in package.json
PR-URL: https://github.com/nodejs/node/pull/54204
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2024-08-06 15:47:52 +00:00
Hüseyin Açacak
c852e222cb
path: fix relative on Windows
...
PR-URL: https://github.com/nodejs/node/pull/53991
Fixes: https://github.com/nodejs/node/issues/27534
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-08-06 09:40:23 +00:00
Sung Ye In
5bfebfec88
test_runner: make mock_loader not confuse CJS and ESM resolution
...
PR-URL: https://github.com/nodejs/node/pull/53846
Fixes: https://github.com/nodejs/node/issues/53807
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-08-06 11:24:24 +02:00
Kohei Ueno
3616ace637
inspector: provide detailed info to fix DevTools frontend errors
...
PR-URL: https://github.com/nodejs/node/pull/54156
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-08-05 12:30:45 +00:00
jakecastelli
fafc845089
stream: make checking pendingcb on WritableStream backward compatible
...
PR-URL: https://github.com/nodejs/node/pull/54142
Fixes: https://github.com/nodejs/node/issues/54131
Refs: https://github.com/nodejs/node/issues/54131
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2024-08-05 12:30:29 +00:00
Colin Ihrig
67f713731c
test_runner: run after hooks even if test is aborted
...
If a test is run, but aborted, any after hooks should still be
run, as they may need to perform cleanup.
PR-URL: https://github.com/nodejs/node/pull/54151
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Raz Luvaton <rluvaton@gmail.com >
2024-08-04 15:56:04 +00:00
Sonny
bd42e4c6a7
test: fix typo in test
...
PR-URL: https://github.com/nodejs/node/pull/54137
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-08-04 07:03:24 +00:00
Sonny
d172da8d01
test: add initial pull delay and prototype pollution prevention tests
...
Refs : https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L522-L536
PR-URL: https://github.com/nodejs/node/pull/54061
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-08-03 19:52:44 +00:00
Rafael Gonzaga
358ff748ea
lib,permission: support Buffer to permission.has
...
PR-URL: https://github.com/nodejs/node/pull/54104
Fixes: https://github.com/nodejs/node/issues/54100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-08-03 16:46:57 +00:00
Stephen Belanger
d1229eeca4
lib: rewrite AsyncLocalStorage without async_hooks
...
PR-URL: https://github.com/nodejs/node/pull/48528
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2024-08-02 19:44:20 +00:00
jakecastelli
0c1877a82a
test: add coverage for webstorage quota
...
PR-URL: https://github.com/nodejs/node/pull/53964
Refs: https://github.com/nodejs/node/issues/53871
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-08-02 22:58:36 +09:30
Antoine du Hamel
1e3a3470a5
build: add --without-amaro build flag
...
PR-URL: https://github.com/nodejs/node/pull/54136
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-08-02 10:37:36 +00:00
jakecastelli
1fd170a7fc
stream: throw TypeError when criteria fulfilled in getIterator
...
PR-URL: https://github.com/nodejs/node/pull/53825
Fixes: https://github.com/nodejs/node/issues/53819
Refs: https://github.com/nodejs/node/issues/53819
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2024-08-01 02:00:47 +00:00
Eric Bickle
7485ad817a
crypto: include NODE_EXTRA_CA_CERTS in all secure contexts by default
...
Store loaded NODE_EXTRA_CA_CERTS into root_certs_vector, allowing
them to be added to secure contexts when NewRootCertStore() is
called, rather than losing them when unrelated options are provided.
When NODE_EXTRA_CA_CERTS is specified, the root certificates
(both bundled and extra) will no longer be preloaded at startup.
This improves Node.js startup time and makes the behavior of
NODE_EXTRA_CA_CERTS consistent with the default behavior when
NODE_EXTRA_CA_CERTS is omitted.
The original reason NODE_EXTRA_CA_CERTS were loaded at startup
(issues #20432 , #20434 ) was to prevent the environment variable from
being changed at runtime. This change preserves the runtime consistency
without actually having to load the certs at startup.
Fixes: https://github.com/nodejs/node/issues/32010
Refs: https://github.com/nodejs/node/issues/40524
Refs: https://github.com/nodejs/node/pull/23354
PR-URL: https://github.com/nodejs/node/pull/44529
Reviewed-By: Tim Perry <pimterry@gmail.com >
2024-07-30 14:20:19 +02:00
Vinicius Lourenço
890760b8e5
console: fix issues with frozen intrinsics
...
PR-URL: https://github.com/nodejs/node/pull/54070
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-07-30 04:38:21 +00:00
Vinicius Lourenço
01cf9bccdf
lib: support dynamic trace events on debugWithTimer
...
PR-URL: https://github.com/nodejs/node/pull/53913
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-07-28 17:20:38 +00:00
e4263dad96
assert: use isError instead of instanceof in innerOk
...
Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de >
Co-Authored-By: Nihar Phansalkar <phansalkarnihar@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/53980
Fixes: https://github.com/nodejs/node/issues/50780
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-07-28 13:13:59 +00:00
Kohei Ueno
69a69f6ca3
http: add diagnostics channel http.client.request.error
...
PR-URL: https://github.com/nodejs/node/pull/54054
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
2024-07-28 09:57:38 +00:00
Rich Trott
dcccf9ab9b
test: move shared module to test/common
...
`test/fixtures/process-exit-code-cases.js` is a shared module and should
be in `test/common` (so it gets linted, etc.) and documented in
`test/common/README.md`.
PR-URL: https://github.com/nodejs/node/pull/54042
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-27 08:52:28 -07:00
KAYYY
449529df02
test: remove unnecessary console log
...
PR-URL: https://github.com/nodejs/node/pull/53812
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-07-26 12:56:10 +00:00
Austin Wright
b32732b1ee
stream: expose DuplexPair API
...
PR-URL: https://github.com/nodejs/node/pull/34111
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-07-26 08:09:23 +00:00
Rich Trott
82cf0f2f3c
test: add comments and rename test for timer robustness
...
The name of the test did not make it clear what it was about. (It also
used "timer" in the name instead of "timers" like all the other tests.)
I also added a comment to be extra clear about the test purpose and a
link to the issue that was originally filed about it.
PR-URL: https://github.com/nodejs/node/pull/54008
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-07-25 17:33:38 +00:00
Carlos Espa
798ca7ed10
test: add test for one arg timers to increase coverage
...
PR-URL: https://github.com/nodejs/node/pull/54007
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-25 17:12:51 +00:00
Aksinya Bykova
049c894350
test_runner: do not throw on mocked clearTimeout()
...
PR-URL: https://github.com/nodejs/node/pull/54005
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
2024-07-25 15:26:00 +00:00
Colin Ihrig
d1c7817da2
test: mark 'test/parallel/test-sqlite.js' as flaky
...
The current test is large and can time out. It should be split
into multiple smaller tests as done in #54014 . However, that
approach appears to change GC behavior such that the database
files are not cleaned up quickly enough on Windows. Forcing
any unfinalized SQL statements to be GC'ed appears to fix the
problem. Mark the original test as flaky until the necessary
code changes are made.
PR-URL: https://github.com/nodejs/node/pull/54031
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-07-25 12:12:41 +00:00
Thomas Hunter II
36e44f1230
doc, test: tracing channel hasSubscribers getter
...
follow up work for https://github.com/nodejs/node/pull/51915
PR-URL: https://github.com/nodejs/node/pull/52908
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-24 16:48:40 +00:00
Marco Ippolito
35f92d953c
module: add --experimental-strip-types
...
PR-URL: https://github.com/nodejs/node/pull/53725
Refs: https://github.com/nodejs/loaders/issues/217
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruy Adorno <ruy@vlt.sh >
2024-07-24 16:30:06 +00:00
Matteo Collina
2208948e1b
test_runner: fix support watch with run(), add globPatterns option
...
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/53866
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-24 13:11:20 +00:00
Deokjin Kim
db594d042b
src: return undefined if no rows are returned in SQLite
...
For now, { key: null, value: null} is returned even though
no rows are returned from database when `statement.get()`
is called. So return empty value if return value of
`sqlite3_step` is `SQLITE_DONE`.
PR-URL: https://github.com/nodejs/node/pull/53981
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-23 16:34:59 +00:00
jakecastelli
0ed9a43242
test: mark test-pipe-file-to-http as flaky
...
PR-URL: https://github.com/nodejs/node/pull/53751
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2024-07-23 14:12:40 +00:00
Early Riser
1eac9a3d41
test: compare paths on Windows without considering case
...
PR-URL: https://github.com/nodejs/node/pull/53993
Fixes: https://github.com/nodejs/node/issues/53989
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-07-23 12:07:34 +00:00
Eddie Abbondanzio
b19a950102
test_runner: cleanup global event listeners after run
...
PR-URL: https://github.com/nodejs/node/pull/53878
Fixes: https://github.com/nodejs/node/issues/53868
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2024-07-23 06:49:52 +00:00
Josh Lee
17fb18d3c2
src: fix slice of slice of file-backed Blob
...
The value for `new_end` was wrong: While the members `start_` and `end_`
refer to the entire length of the file, the parameters `start` and `end`
are relative to the current slice.
The new end would apparently have the current start_ subtracted from it,
and the length would possibly overflow when the FdEntry is asked for its
size or when get_reader is called, resulting in a subslice which extends
past the current slice, which shouldn't be possible. Add a CHECK if this
happens, rather than returning data outside the current slice.
There aren't any C++ tests for FdEntry, and on the javascript side there
isn't a way to ask the blob handle for its nominal size. That size could
be a large uint64, which gets converted to int64 to when FileHandle::new
is called, which interprets a negative length as unlimited.
Fixes: https://github.com/nodejs/node/issues/53908
PR-URL: https://github.com/nodejs/node/pull/53972
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 18:25:30 +00:00
Tobias Nießen
ad0a2db975
src,test: disallow unsafe integer coercion in SQLite
...
Currently, by default (i.e., when use_big_ints_ has not explicitly been
set to true), reading a SQLite integer value that is not a safe integer
in JavaScript is likely to yield an incorrect number.
Instead, err on the side of caution and throw if the stored integer is
not a safe integer in JavaScript and if use_big_ints_ has not been set
to true.
PR-URL: https://github.com/nodejs/node/pull/53851
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2024-07-22 12:22:17 +00:00
Benjamin Gruenbaum
259163802c
test: validate promise-version setTimeout behavior with NaN
...
PR-URL: https://github.com/nodejs/node/pull/53622
Refs: https://github.com/nodejs/node/pull/46678
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 07:52:57 +02:00
Liran Tal
47b877993f
child_process: fix incomplete prototype pollution hardening
...
Prior pull request (#48726 ) hardened against prototype pollution
vulnerabilities but effectively missed some use-cases which
opened a window for prototype pollution for some child_process
functions such as spawn(), spawnSync(), and execFileSync().
PR-URL: https://github.com/nodejs/node/pull/53781
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-07-21 21:27:04 +00:00
Antoine du Hamel
036ff03691
test: reduce flakiness of test-assert-esm-cjs-message-verify
...
PR-URL: https://github.com/nodejs/node/pull/53967
Fixes: https://github.com/nodejs/node/issues/53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-21 17:34:38 +00:00
Luigi Pinca
50d09bc5f6
test: deflake test-blob-file-backed
...
Avoid race conditions by using a different file for each subtest.
Fixes: https://github.com/nodejs/node/issues/51860
PR-URL: https://github.com/nodejs/node/pull/53920
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2024-07-20 13:16:23 +00:00
Kohei Ueno
a523c345b1
inspector: add initial support for network inspection
...
PR-URL: https://github.com/nodejs/node/pull/53593
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2024-07-19 05:00:30 +00:00
Yagiz Nizipli
7168295e7a
fs: move rmSync implementation to c++
...
PR-URL: https://github.com/nodejs/node/pull/53617
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-18 20:02:49 +00:00
Chengzhong Wu
63d7b4280e
lib: decorate async stack trace in source maps
...
Decorate stack frame with 'async' and 'new' keywords based on the type
of the call site info.
PR-URL: https://github.com/nodejs/node/pull/53860
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-18 14:45:43 +00:00
James M Snell
efe5b81df9
deps: start working on ncrypto dep
...
Start moving src/crypto functionality out to a separate dep that
can be shared with other projects that need to emulate Node.js
crypto behavior.
PR-URL: https://github.com/nodejs/node/pull/53803
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-18 06:56:53 -07:00