Commit Graph
2244 Commits
Author SHA1 Message Date
Keyhan Vakil 0736d0b3f5 src: register external references for source code
Currently we use external strings for internalized builtin source code.
However when a snapshot is taken, any external string whose resource
is not registered is flattened into a SeqString (see ref). The
result is that module source code stored in the snapshot does not
use external strings after deserialization. This patch registers an
external string resource for each internalized builtin's source. The
savings are substantial: ~1.9 MB of heap memory per isolate, or ~44%
of an otherwise empty isolate's heap usage:

```console
$ node --expose-gc -p 'gc(),process.memoryUsage().heapUsed'
4190968
$ ./node --expose-gc -p 'gc(),process.memoryUsage().heapUsed'
2327536
```

The savings can be even higher for user snapshots which may include
more internal modules.

The existing UnionBytes implementation was ill-suited, because it only
created an external string resource when ToStringChecked was called,
but we need to register the external string resources before the
isolate even exists. We change UnionBytes to no longer own the data,
and shift ownership of the data to a new external resource class
called StaticExternalByteResource.  StaticExternalByteResource are
either statically allocated (for internalized builtin code) or owned
by the static `externalized_builtin_sources` map, so they will only be
destructed when static resources are destructed. We change JS2C to emit
statements to register a string resource for each internalized builtin.

Refs: https://github.com/v8/v8/blob/d2c8fbe9ccd1a6ce5591bb7dd319c3c00d6bf489/src/snapshot/serializer.cc#L633
PR-URL: https://github.com/nodejs/node/pull/47055
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2023-05-10 11:17:59 +00:00
Marco Ippolito 1b177932a1 tools: automate icu-small update
PR-URL: https://github.com/nodejs/node/pull/47727
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-05-09 21:01:08 +00:00
Node.js GitHub Bot 4f69aae6a0 tools: update lint-md-dependencies to rollup@3.21.5
PR-URL: https://github.com/nodejs/node/pull/47903
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-05-09 09:48:48 +00:00
Node.js GitHub Bot bf8dd3f293 tools: update eslint to 8.40.0
PR-URL: https://github.com/nodejs/node/pull/47906
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-05-09 06:38:21 +00:00
Moshe Atlow 9e5e2f1dc5 test: migrate a pseudo_tty test to use assertSnapshot
PR-URL: https://github.com/nodejs/node/pull/47803
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-05-04 08:34:23 +00:00
Marco Ippolito 109ab0a89c doc: create maintaining folder for deps
PR-URL: https://github.com/nodejs/node/pull/47589
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-05-02 17:03:23 +00:00
Node.js GitHub Bot 32778b8d0e tools: update eslint to 8.39.0
PR-URL: https://github.com/nodejs/node/pull/47789
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2023-05-02 00:48:22 +00:00
Node.js GitHub Bot 8587e3b369 tools: update doc to highlight.js@11.8.0
PR-URL: https://github.com/nodejs/node/pull/47786
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2023-05-02 00:48:08 +00:00
Sun Haiyong aa6600df58 tools: add the missing LoongArch64 definition in the v8.gyp file
PR-URL: https://github.com/nodejs/node/pull/47641
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2023-05-01 13:26:23 +02:00
Node.js GitHub Bot 0a3f6a9d07 tools: update lint-md-dependencies to rollup@3.21.1
PR-URL: https://github.com/nodejs/node/pull/47787
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-04-30 04:20:45 +00:00
Marco Ippolito e2e3f5c9da tools: move update-npm to dep updaters
PR-URL: https://github.com/nodejs/node/pull/47619
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-26 14:10:29 +00:00
Marco Ippolito 71a776b928 tools: automate v8 patch update
PR-URL: https://github.com/nodejs/node/pull/47594
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2023-04-26 08:20:23 +00:00
Filip Skokan a5ce18f9e0 test: refactor WPTRunner and enable parallel WPT execution
PR-URL: https://github.com/nodejs/node/pull/47635
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2023-04-25 11:45:54 +00:00
Tobias Nießen 8becacb25d tools: fix skip message in update-cjs-module-lexer
Refs: https://github.com/nodejs/node/pull/47446
PR-URL: https://github.com/nodejs/node/pull/47701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2023-04-24 17:34:01 +00:00
Node.js GitHub Bot 0e5b82c381 crypto: update root certificates to NSS 3.89
This is the certdata.txt[0] from NSS 3.89, released on 2023-03-09.

This is the version of NSS that shipped in Firefox 112 on
2023-04-11.

Certificates removed:
- Network Solutions Certificate Authority
- EC-ACC
- Staat der Nederlanden EV Root CA

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_89_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: https://github.com/nodejs/node/pull/47659
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2023-04-23 11:44:59 +00:00
Node.js GitHub Bot db1bf9ddbb tools: update lint-md-dependencies to @rollup/plugin-commonjs@24.1.0
PR-URL: https://github.com/nodejs/node/pull/47577
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-04-23 06:10:47 +00:00
Richard Lau 472ffdef73 tools: fix updating root certificates
When searching for the latest certdata.txt, check that the file
exists on the remote server.

PR-URL: https://github.com/nodejs/node/pull/47607
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2023-04-21 02:14:00 +00:00
Moshe Atlow f536bb04ce deps: add minimatch as a dependency
PR-URL: https://github.com/nodejs/node/pull/47499
Refs: https://github.com/nodejs/node/pull/47490
Refs: https://github.com/nodejs/node/pull/47486
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2023-04-21 03:01:52 +03:00
Filip Skokan 607715e52a Revert "test: run WPT files in parallel again"
This reverts commit c05689ea6b.

PR-URL: https://github.com/nodejs/node/pull/47627
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
2023-04-20 10:25:08 +02:00
Mert Can Altın f509f102c8 tools: add execution permission to uvwasi script
PR-URL: https://github.com/nodejs/node/pull/47600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2023-04-19 19:15:08 +00:00
Tobias Nießen 4956271c93 tools: add update script for googletest
GoogleTest follows the Abseil Live at Head philosophy, and rarely
creates tags or GitHub releases, so instead, follow Google's
recommendation and update to the upstream HEAD every once in a while.

The tricky bit is properly updating googletest.gyp, and this script
might fail doing so in the future.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/47482
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-19 15:07:01 +00:00
Marco Ippolito 8f879ded4e tools: automate zlib update
PR-URL: https://github.com/nodejs/node/pull/47417
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-04-19 08:25:54 +00:00
Steven R. Loomis e050cecad1 deps: update ICU to 73.1 release
- Details: https://icu.unicode.org/download/73

PR-URL: https://github.com/nodejs/node/pull/47456
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2023-04-17 09:48:26 -05:00
Yagiz Nizipli c94be4125b test: mark test-cluster-primary-error flaky on asan
PR-URL: https://github.com/nodejs/node/pull/47422
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-04-14 03:51:46 +00:00
Ranieri Innocenti Spada 5fa84e8866 tools: automate uvwasi dependency update
Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/47509
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-13 16:29:29 +00:00
Marco Ippolito 6dcbf8b616 tools: automate ngtcp2 and nghttp3 update
PR-URL: https://github.com/nodejs/node/pull/47402
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-12 13:18:02 +00:00
Marco Ippolito 4899998d0d tools: move update-undici.sh to dep_updaters and create maintain md
PR-URL: https://github.com/nodejs/node/pull/47380
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-11 13:19:14 +00:00
Cheng Zhao 3a98dd338f tools: make js2c.py usable for other build systems
PR-URL: https://github.com/nodejs/node/pull/46930
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2023-04-10 22:11:22 +02:00
Marco Ippolito c2b54fb900 tools: move update-acorn.sh to dep_updaters and create maintaining md
PR-URL: https://github.com/nodejs/node/pull/47382
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-10 19:38:08 +00:00
Node.js GitHub Bot a57b8ddd9a tools: update eslint to 8.38.0
PR-URL: https://github.com/nodejs/node/pull/47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-04-10 06:11:49 +00:00
Node.js GitHub Bot 270e24f0f7 tools: update eslint to 8.38.0
PR-URL: https://github.com/nodejs/node/pull/47475
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-04-10 06:11:48 +00:00
Marco Ippolito cfb654cc31 tools: automate cjs-module-lexer dependency update
PR-URL: https://github.com/nodejs/node/pull/47446
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-09 18:23:04 +00:00
Node.js GitHub Bot 7ef5c60e80 tools: update lint-md-dependencies to @rollup/plugin-node-resolve@15.0.2
PR-URL: https://github.com/nodejs/node/pull/47431
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-04-07 23:58:25 +00:00
Richard Lau a75871a36e tools: add root certificate update script
Automates the steps from `doc/contributing/maintaining-root-certs.md`.
Extend "Tools and deps update" workflow to use the new script to update
the root certificates.

PR-URL: https://github.com/nodejs/node/pull/47425
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-04-07 19:10:56 +00:00
Konstantin Demin c3cd75d10b build, deps, tools: avoid excessive LTO
Don't link intermediate executables with LTO in order to speed up
overall build time.

Signed-off-by: Konstantin Demin <rockdrilla@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/47313
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-04-06 00:24:58 +00:00
Filip Skokan c05689ea6b test: run WPT files in parallel again
PR-URL: https://github.com/nodejs/node/pull/47283
Refs: https://github.com/nodejs/node/issues/47146
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-03-31 17:56:40 +00:00
Stephen Belanger fe751df537 lib: add tracing channel to diagnostics_channel
PR-URL: https://github.com/nodejs/node/pull/44943
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
2023-03-31 17:40:30 +00:00
Michaël Zasso 7ce223273d tools: update V8 gypfiles for 11.1
PR-URL: https://github.com/nodejs/node/pull/47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-03-31 14:15:31 +00:00
Michaël Zasso ca4bd3023e tools: update V8 gypfiles for 11.0
PR-URL: https://github.com/nodejs/node/pull/47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-03-31 14:15:30 +00:00
Node.js GitHub Bot 10928cb0a4 tools: update eslint to 8.37.0
PR-URL: https://github.com/nodejs/node/pull/47333
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2023-03-31 13:55:43 +00:00
Moshe Atlow b541d2c7e9 tools: fix duration_ms to be milliseconds
PR-URL: https://github.com/nodejs/node/pull/44490
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
2023-03-31 12:24:18 +00:00
Marco Ippolito da8c099f10 tools: automate brotli update
PR-URL: https://github.com/nodejs/node/pull/47205
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
2023-03-31 08:31:01 +00:00
Marco Ippolito 5314148d8a tools: standardize base64 update
PR-URL: https://github.com/nodejs/node/pull/47201
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-03-29 08:27:33 +00:00
Node.js GitHub Bot 106aa47639 tools: update lint-md-dependencies to rollup@3.20.2
PR-URL: https://github.com/nodejs/node/pull/47255
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2023-03-26 06:34:09 +00:00
Tobias Nießen 6311de3322 tools: upgrade Windows digital signature to SHA256
signtool still defaults to SHA1, which is vulnerable to certain
collisions. This switches to SHA256, which is stronger and which also
matches the hash function used by the signing certificate.

Technically, `/fd certHash` would be a better choice, but I don't know
if it is widely supported.

PR-URL: https://github.com/nodejs/node/pull/47206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-03-25 18:27:46 +00:00
Marco Ippolito 38b6ecc12e tools: standardize update-llhttp.sh
PR-URL: https://github.com/nodejs/node/pull/47198
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tierney Cyren <hello@bnb.im>
2023-03-25 14:26:01 +00:00
jakecastelli 94ec71d385 tools: add button to copy code example to clipboard
PR-URL: https://github.com/nodejs/node/pull/46928
Refs: https://github.com/nodejs/node/issues/46894
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
2023-03-25 08:41:43 +00:00
Marco Ippolito a64469dcf1 tools: standardize update-nghttp2.sh
PR-URL: https://github.com/nodejs/node/pull/47197
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2023-03-25 08:24:55 +00:00
Stefan Stojanovic 0b66df61ef msi: migrate to WiX4
To be able to build x86, x64, and ARM64 MSI installers with the same WiX
version, migration to WiX4 is required.

PR-URL: https://github.com/nodejs/node/pull/45943
Refs: https://github.com/nodejs/build/issues/2540
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2023-03-22 22:16:57 +00:00
Moshe Atlow f5eedf480c tools: allow test tap output to include unicode characters
PR-URL: https://github.com/nodejs/node/pull/47175
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
2023-03-21 17:27:53 +00:00