Antoine du Hamel
7fd6c2036d
tools: refactor prefer-primordials
...
Use optional chaining to improve code readability and remove use of
`Array.prototype.reduce`.
PR-URL: https://github.com/nodejs/node/pull/36018
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
2021-02-16 17:58:31 +01:00
cjihrig
ac24e50502
tools: update ESLint to 7.20.0
...
Update ESLint to 7.20.0
PR-URL: https://github.com/nodejs/node/pull/37339
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-15 10:38:36 -05:00
Antoine du Hamel
0177d4cc20
doc: optimize HTML rendering
...
Defer rendering sections of docs until they are displayed on
the user's screen.
PR-URL: https://github.com/nodejs/node/pull/37301
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-02-15 16:14:15 +01:00
James M Snell
4a19cc8947
perf_hooks: introduce createHistogram
...
Adds a new `perf_hooks.createHistogram()` API for creating histogram
instances that allow user recording.
Makes Histogram instances cloneable via MessagePort. This allows, for
instance, an event loop delay monitor to be running on the main thread
while the histogram data can be monitored actively from a worker thread.
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/37155
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-02-14 13:03:49 -08:00
Antoine du Hamel
a803d4aedb
tools: fix lint-pr-url message
...
PR-URL: https://github.com/nodejs/node/pull/37304
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-13 18:08:48 +01:00
Michaël Zasso
5bf2737e13
tools: avoid pending deprecation in doc generator
...
`unist-util-find` depends on `lodash.iteratee` which uses
`process.binding()`.
Let's remove this dependency which is used in one place to do a very
simple thing.
PR-URL: https://github.com/nodejs/node/pull/37267
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-02-12 21:46:54 +01:00
Michaël Zasso and Jiawen Geng
79da253473
tools: update V8 gypfiles for 8.8
...
Co-authored-by: Jiawen Geng <technicalcute@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/36139
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
2021-02-11 19:11:49 +01:00
Antoine du Hamel
33d3a2e6cb
tools: add GitHub Action linter for pr-url
...
PR-URL: https://github.com/nodejs/node/pull/37221
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-09 11:45:11 +01:00
Rich Trott
72f9c53c0f
tools: bump remark-present-lint-node from 2.0.0 to 2.0.1
...
This is a prerequisite for https://github.com/nodejs/node/pull/37259 .
PR-URL: https://github.com/nodejs/node/pull/37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2021-02-08 04:26:22 -08:00
Michaël Zasso
907d6b6b40
tools: fix d8 macOS build
...
libv8_base doesn't exist anymore.
PR-URL: https://github.com/nodejs/node/pull/37211
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-02-07 15:43:11 +01:00
Joyee Cheung
2e769a92ff
src: put (de)serialization code into node_snapshotable.h/cc
...
So that it's easier to find the corresponding code.
PR-URL: https://github.com/nodejs/node/pull/37114
Refs: https://github.com/nodejs/node/pull/36943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2021-02-05 20:18:47 +08:00
cjihrig
bc396c8ac5
tools: update ESLint to 7.19.0
...
Update ESLint to 7.19.0
PR-URL: https://github.com/nodejs/node/pull/37159
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-02-03 15:55:32 +01:00
Rich Trott
683754c6f3
doc: remove TOC summary for pages with no TOC
...
Remove the table of contents summary for pages with no table of
contents. Currently, this affects at least index.html.
PR-URL: https://github.com/nodejs/node/pull/37043
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-01-31 06:03:33 -08:00
James M Snell
c3d6d50309
quic: remove quic
...
PR-URL: https://github.com/nodejs/node/pull/37067
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2021-01-30 07:49:28 -08:00
cjihrig
1b222f900e
tools: remove commented code from stability.js
...
PR-URL: https://github.com/nodejs/node/pull/37092
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-01-29 20:05:25 +08:00
Michaël Zasso
900c9f5041
tools: cleanup old ICU version-specific fixes
...
Our current minimum ICU is 67, so we don't need to support those anymore
PR-URL: https://github.com/nodejs/node/pull/36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-01-20 16:32:50 +01:00
Michaël Zasso
5faffd8d3f
deps: update ICU to 68.2
...
Refs: https://github.com/unicode-org/icu/releases/tag/release-68-2
PR-URL: https://github.com/nodejs/node/pull/36980
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-01-20 16:32:45 +01:00
Zijian Liu
2bb42bf156
tools,doc: list the stability status of each API
...
Fixes: https://github.com/nodejs/node/issues/23723
PR-URL: https://github.com/nodejs/node/pull/36223
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-01-20 01:23:45 +01:00
James M Snell
d4bea09a0a
buffer: introduce Blob
...
The `Blob` object is an immutable data buffer. This is a first step
towards alignment with the `Blob` Web API.
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/36811
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-01-18 13:55:25 -08:00
James M Snell
bd899bc656
crypto: experimental (Ed/X)25519/(Ed/X)448 support
...
Implements initial experimental support for Curve25519 and
Curve448 support for both ECDH and sign/verify in Web Crypto.
Introduced as a Node.js-specific extension to Web Crypto.
Signed-off-by: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/36076
PR-URL: https://github.com/nodejs/node/pull/36879
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-01-18 08:12:08 -08:00
cjihrig
568b26ac6e
tools: update ESLint to 7.18.0
...
Update ESLint to 7.18.0
PR-URL: https://github.com/nodejs/node/pull/36955
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-01-18 12:12:05 +01:00
Antoine du Hamel
49f900e42d
tools: add support for top-level await syntax in linter
...
PR-URL: https://github.com/nodejs/node/pull/36911
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-01-16 00:31:43 +01:00
Mattia Pontonio
2ba8728b9f
doc: wrap TOC in a <details> tag
...
PR-URL: https://github.com/nodejs/node/pull/36896
Fixes: https://github.com/nodejs/node/issues/36885
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-01-14 16:35:59 +01:00
Michaël Zasso
6520a874eb
tools: update all lint-md rollup dependencies
...
PR-URL: https://github.com/nodejs/node/pull/36843
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-01-11 12:08:34 +01:00
Michaël Zasso
9883fe0114
tools: update doc tool dependencies
...
PR-URL: https://github.com/nodejs/node/pull/36844
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-01-11 08:13:23 +01:00
James M Snell
f5287a4b7b
crypto: introduce X509Certificate API
...
Introduces the `crypto.X509Certificate` object.
```js
const { X509Certificate } = require('crypto');
const x509 = new X509Certificate('{pem encoded cert}');
console.log(x509.subject);
```
Fixes: https://github.com/nodejs/node/issues/29181
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/36804
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-01-09 12:04:23 -08:00
Richard Lau
fcf62269df
tools: fix md5 hash for ICU 68.1 src
...
Correct md5sum hash for the tarball version of the ICU 68.1 source.
The previously recorded md5sum hash was for the zip version.
PR-URL: https://github.com/nodejs/node/pull/36777
Fixes: https://github.com/nodejs/node/issues/36776
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2021-01-05 20:47:34 -08:00
cjihrig
64a4001d2c
tools: update ESLint to 7.17.0
...
Update ESLint to 7.17.0
PR-URL: https://github.com/nodejs/node/pull/36726
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Yash Ladha <yash@yashladha.in >
2021-01-04 19:02:21 +00:00
raisinten
d146b25928
build: fix unknown warning option
...
warning: unknown warning option '-Wno-int-in-bool-context';
did you mean '-Wno-gnu-include-next'? [-Wunknown-warning-option]
1 warning generated.
The `-Wint-in-bool-context` diagnostic is not enabled by default,
so no additional option is needed.
PR-URL: https://github.com/nodejs/node/pull/36629
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-12-28 11:51:27 +00:00
Rich Trott
245159fccf
tools: revise install.py for minor improvements
...
* Use an with block for reading the config file.
Refs: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files
* Use explicit blank return to make it clear that the return value is
not actually used and that it is being used for flow control only..
PR-URL: https://github.com/nodejs/node/pull/36626
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Christian Clauss <cclauss@me.com >
2020-12-27 06:30:31 -08:00
Michaël Zasso
8c94aea98e
tools: update gyp-next to v0.7.0
...
Refs: https://github.com/nodejs/gyp-next/releases/tag/v0.7.0
PR-URL: https://github.com/nodejs/node/pull/36580
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
2020-12-26 12:19:26 +01:00
Rich Trott
e068eec783
tools: correct usage message for genv8constants.py
...
PR-URL: https://github.com/nodejs/node/pull/36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-25 04:28:35 -08:00
Rich Trott
18fc50f983
tools: call close() explicitly in genv8constants.py
...
PR-URL: https://github.com/nodejs/node/pull/36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-25 04:28:32 -08:00
Rich Trott
36c17e2f51
tools: use is None consistently in Python
...
We use `is None` instead of `== None` everywhere (which mostly just
means test.py) except in one place in genv8constants.py. Switch to `is
None` in genv8constants.py. This is slightly more efficient, although I
can't imagine that makes a measurable difference here.
PR-URL: https://github.com/nodejs/node/pull/36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-25 04:28:27 -08:00
Richard Lau
21f2e8859d
tools: fix make-v8.sh
...
V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).
PR-URL: https://github.com/nodejs/node/pull/36594
Refs: https://github.com/nodejs/node/pull/36099
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Coe <bencoe@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2020-12-22 01:09:42 +00:00
Michaël Zasso
ce658bd2c8
doc: update and run license-builder for Babel
...
PR-URL: https://github.com/nodejs/node/pull/36504
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-21 15:07:13 +01:00
Antoine du Hamel
6c25870073
tools: fix release script sign function
...
PR-URL: https://github.com/nodejs/node/pull/36556
Refs: https://github.com/nodejs/node/pull/36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2020-12-21 14:47:22 +01:00
zhangyongsheng
eefb424c60
tools: update ESLint to 7.16.0
...
PR-URL: https://github.com/nodejs/node/pull/36579
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-21 14:24:53 +01:00
zhangyongsheng
775ce40c99
tools: fix update-eslint.sh
...
PR-URL: https://github.com/nodejs/node/pull/36579
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-21 14:24:51 +01:00
Antoine du Hamel
f28715d95d
tools: fix release script
...
PR-URL: https://github.com/nodejs/node/pull/36540
Refs: https://github.com/nodejs/node/pull/36123
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-12-17 16:03:48 +00:00
Antoine du Hamel
0e96dc1f95
tools: lint shell scripts
...
PR-URL: https://github.com/nodejs/node/pull/36099
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-16 23:45:26 +01:00
Myles Borins
7faeddf23a
tools: update ini in tools/node-lint-md-cli-rollup
...
Refs: https://github.com/nodejs/node/pull/36473
Refs: https://github.com/advisories/GHSA-qqgx-2p2h-9c37
PR-URL: https://github.com/nodejs/node/pull/36474
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2020-12-11 11:32:46 -05:00
Michael Dawson
72b07e4fcf
doc: update terminology
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/36475
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2020-12-10 16:45:39 -05:00
cjihrig
514da38180
tools: update ESLint to 7.15.0
...
Update ESLint to 7.15.0
PR-URL: https://github.com/nodejs/node/pull/36411
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2020-12-09 16:42:12 +00:00
Michaël Zasso
8dbeac6c04
tools: update doc tool dependencies
...
PR-URL: https://github.com/nodejs/node/pull/36407
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-08 22:17:58 +00:00
Antoine du Hamel
5f1bf80b5e
tools: upgrade to @babel/eslint-parser 7.12.1
...
PR-URL: https://github.com/nodejs/node/pull/36321
Fixes: https://github.com/ensure
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-12-07 10:05:29 -08:00
Rich Trott
5477969555
tools: refloat 7 Node.js patches to cpplint.py
...
Cherry-pick 12c8b4d154
Original commit message:
This commit is a suggestion for adding a rule for NULL usages in the
code base. This will currently report a number of errors which could be
ignored using // NOLINT (readability/null_usage)
PR-URL: https://github.com/nodejs/node/pull/17373
Reviewed-By: Jon Moss <me@jonathanmoss.me >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b
Cherry-pick fc81e80191
Original commit message:
Update cpplint.py to check for inline headers when the corresponding
header is already included.
PR-URL: https://github.com/nodejs/node/pull/21521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Refs: https://github.com/nodejs/node/commit/fc81e801913de3e3f3c0c8e26c105f983a74e539
Cherry-pick cbc3dd997e
Original commit message:
src, tools: add check for left leaning pointers
This commit adds a rule to cpplint to check that pointers in the code
base lean to the left and not right, and also fixes the violations
reported.
PR-URL: https://github.com/nodejs/node/pull/21010
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Refs: https://github.com/nodejs/node/commit/cbc3dd997eb90d629d1b9912b7a5a40eb82343df
Cherry-pick 902998190a
Original commit message:
tools: fix cpplint.py header rules
THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.
PR-URL: https://github.com/nodejs/node/pull/26306
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Refs: https://github.com/nodejs/node/commit/902998190a55d6915b881936f6dd5b6e9cca6ad8
Cherry-pick 0a25ace9c3
Original commit message:
tools: move cpplint configuration to .cpplint
PR-URL: https://github.com/nodejs/node/pull/27098
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Refs: https://github.com/nodejs/node/commit/0a25ace9c35b62ece4d32fd90b326d8063265109
Cherry-pick afa9a7206c
Original commit message:
tools: refloat update link to google styleguide for cpplint
This commit updates two old links to Google's C++ styleguide which
currently result in a 404 when accessed.
PR-URL: https://github.com/nodejs/node/pull/30876
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Refs: https://github.com/nodejs/node/commit/afa9a7206c26a29a2af226696c145c924a6d3754
Cherry-pick e23bf8f771
Original commit message:
tools,src: refloat forbid usage of v8::Persistent
`v8::Persistent` comes with the surprising catch that it requires
manual cleanup. `v8::Global` doesn’t, making it easier to use,
and additionally provides move semantics. New code should always
use `v8::Global`.
PR-URL: https://github.com/nodejs/node/pull/31018
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Gus Caplan <me@gus.host >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
PR-URL: https://github.com/nodejs/node/pull/35569
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/35866
PR-URL: https://github.com/nodejs/node/pull/36213
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/36235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/36324
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2020-12-05 21:15:18 -08:00
Rich Trott
2ce2b48187
tools: bump cpplint to 1.5.4
...
PR-URL: https://github.com/nodejs/node/pull/36324
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-12-05 21:14:59 -08:00
Antoine du Hamel
897307554a
tools: remove bashisms from macOS release scripts
...
PR-URL: https://github.com/nodejs/node/pull/36121
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-12-04 22:56:13 +00:00
Antoine du Hamel
1729ba7578
tools: remove bashisms from release script
...
PR-URL: https://github.com/nodejs/node/pull/36123
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-12-04 23:55:19 +01:00