Daniel Lemire
2e9e844d99
src: use ranges library (C++20) more systematically
...
PR-URL: https://github.com/nodejs/node/pull/58028
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2025-06-26 02:31:52 +00:00
theanarkh
f08e0a0fa0
dns: set timeout to 1000ms when timeout < 0
...
PR-URL: https://github.com/nodejs/node/pull/58441
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-06-25 16:36:20 +00:00
James M Snell
2bb7667475
fs: move FileHandle close on GC to EOL
...
Automatically closing a FileHandle on garbage collection
has been deprecated for some time now. We've said that
it will eventually be removed and become and error.
PR-URL: https://github.com/nodejs/node/pull/58536
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
2025-06-25 17:00:25 +01:00
Mert Can Altin
6ce6fdbf21
module: update tests for combined ambiguous module syntax error
...
PR-URL: https://github.com/nodejs/node/pull/55874
Fixes: https://github.com/nodejs/node/issues/55776
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-06-24 21:49:31 +00:00
Miguel Marcondes Filho
d08513dfc7
sqlite: add support for readBigInts option in db connection level
...
PR-URL: https://github.com/nodejs/node/pull/58697
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
2025-06-24 14:26:07 +00:00
Aditi
faada65d16
src: add FromV8Value<T>() for integral and enum types
...
Add a template utility method FromV8Value<T>() to replace the
repetitive static_cast<...>(value.As<>()‑>Value()) pattern.
It also additionally adds compile‑time range checks for
integers.
Refs: https://github.com/nodejs/node/pull/57146#discussion_r1963799600
PR-URL: https://github.com/nodejs/node/pull/57931
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2025-06-24 04:16:09 +00:00
Node.js GitHub Bot
5f3262add6
deps: update acorn to 8.15.0
...
PR-URL: https://github.com/nodejs/node/pull/58711
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-06-23 20:35:29 +00:00
Rafael Gonzaga
b04c4a44a5
src: pass resource on permission checks for spawn
...
This commit enhances the permission model errors
when no --allow-child-process is used and the error
is emitted.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com >
PR-URL: https://github.com/nodejs/node/pull/58758
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-06-21 14:40:10 +00:00
Node.js GitHub Bot
88f4cef8b9
deps: update amaro to 1.1.0
...
PR-URL: https://github.com/nodejs/node/pull/58754
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-06-20 14:07:56 +00:00
Chengzhong Wu
5a14ea62b9
inspector: add protocol methods retrieving sent/received data
...
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.
PR-URL: https://github.com/nodejs/node/pull/58645
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com >
2025-06-20 10:20:37 +00:00
Rafael Gonzaga
462c74181d
src,permission: add --allow-net permission
...
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com >
PR-URL: https://github.com/nodejs/node/pull/58517
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2025-06-17 12:35:23 +00:00
Jacky Zhao
908f9f1dc6
fs: add UV_ENOSPC to list of things to pass to err directly
...
PR-URL: https://github.com/nodejs/node/pull/56918
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-06-16 18:56:41 +00:00
Miguel Marcondes Filho
5fe7800683
node-api: add warning for NAPI_EXPERIMENTAL
...
PR-URL: https://github.com/nodejs/node/pull/58280
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com >
2025-06-13 16:00:37 +00:00
Pietro Marchini
3ac0e28a7f
src: enhance error messages for unknown options
...
PR-URL: https://github.com/nodejs/node/pull/58677
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-06-13 13:40:17 +00:00
Chengzhong Wu and jazelly
5457443210
lib,src: support DOMException ser-des
...
Added serialization and deserialization support for `DOMException`.
Co-Authored-By: jazelly <xzha4350@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58649
Fixes: https://github.com/nodejs/node/issues/49181
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
2025-06-11 16:11:18 +00:00
Joyee Cheung
8c17ceb38f
module: allow cycles in require() in the CJS handling in ESM loader
...
When --import is used, the ESM loader is used to handle even pure
CJS entry points, and it can run into CJS module facades in the
evaluating state when the parent CJS module is being evaluated.
In this case it should be allowed, since the ESM <-> CJS cycles
that are meant to be disallowed (for the time being) should
already be detected before evaluation and wouldn't get here,
and CJS <-> CJS cycles are fine.
PR-URL: https://github.com/nodejs/node/pull/58598
Fixes: https://github.com/nodejs/node/issues/58515
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
2025-06-11 09:33:16 +00:00
Node.js GitHub Bot
bb991716c6
deps: update amaro to 1.0.0
...
PR-URL: https://github.com/nodejs/node/pull/58639
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
2025-06-11 06:57:40 +00:00
Mert Can Altin
238af6a8b5
src: replace std::array with static arrays in contextify
...
PR-URL: https://github.com/nodejs/node/pull/58580
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-06-10 10:59:14 +00:00
Node.js GitHub Bot
a45f1ad8ae
deps: update zlib to 1.3.1-470d3a2
...
PR-URL: https://github.com/nodejs/node/pull/58628
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-06-10 01:07:34 +00:00
Dario Piotrowicz
bce60abdb1
src: add new CopyUtimes function to reduce code duplication
...
PR-URL: https://github.com/nodejs/node/pull/58625
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-06-09 23:35:36 +00:00
Dario Piotrowicz
3596ee006e
src: replace V8 Fast API todo comment with note comment
...
PR-URL: https://github.com/nodejs/node/pull/58614
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-06-09 14:22:28 +00:00
Dario Piotrowicz
3c351c272f
fs: improve cpSync no-filter copyDir performance
...
move the logic in `cpSync` that copies a directory from
src to dest from JavaScript to C++ increasing its performance
Note: this improvement is not applied if the filter option is
provided, such optimization will be looked into separately
PR-URL: https://github.com/nodejs/node/pull/58461
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-06-07 14:44:25 +00:00
Rafael Gonzaga
f58613a64c
src,permission: implicit allow-fs-read to app entrypoint
...
This commit automatically includes in the allow-fs-read
list all the app's entrypoints.
`--require` and user entry point
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com >
PR-URL: https://github.com/nodejs/node/pull/58579
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-06-07 13:33:25 +00:00
Mert Can Altin
0c6e16bc84
src: env_vars caching and local variable scope optimization
...
PR-URL: https://github.com/nodejs/node/pull/57624
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-06-06 23:30:10 +00:00
Pietro Marchini
c1f090dc76
src: support namespace options in configuration file
...
PR-URL: https://github.com/nodejs/node/pull/58073
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Giovanni Bucci <github@puskin.it >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
2025-06-06 12:47:05 +00:00
Chengzhong Wu
708fd1945b
src: remove node.h APIs to make callback without an async context
...
PR-URL: https://github.com/nodejs/node/pull/58471
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-06-06 10:50:02 +00:00
Carlos Fuentes
02a1505efc
http2: add lenient flag for RFC-9113
...
PR-URL: https://github.com/nodejs/node/pull/58116
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2025-06-05 12:30:07 +00:00
Tobias Nießen
ebf38d825d
crypto: forward auth tag to OpenSSL immediately
...
This change simplifies the AEAD implementation. Instead of storing the
authentication tag when the user calls `setAuthTag()` and passing it to
OpenSSL later in `MaybePassAuthTagToOpenSSL()`, the modified code
forwards it to OpenSSL from within `setAuthTag()` already, removing the
need to store it.
For clarity, I have also renamed the possible `AuthTagState` values to
better reflect the actual state of the authentication tag.
I assume that we did not originally do this due to issues with some
old versions of OpenSSL when reordering certain function calls, but even
with the recent additions I made to the relevant test (namely,
1ef99237f5 and
53944c4462 ), it seems to pass in both
OpenSSL 3 and OpenSSL 1.1.1 with this simplification.
PR-URL: https://github.com/nodejs/node/pull/58547
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2025-06-03 11:13:44 +00:00
Joyee Cheung
3d22cdb713
src: remove fast API for InternalModuleStat
...
There are several motivation for removing this:
1. The implementation does not align with InternalModuleStat,
most noticably it does not namespace the path or convert
it to UTF-16 before using it with std::filesystem::path
on Windows which could crash on non-English locale.
2. It needs the Environment - if not for decoding the string,
at least for env->exec_path() to resolve the path for
namespacing - and therefore needs a handle to the Context
which requires a handle scope which actually makes the
fast API version slower than the normal binding.
For simplicity this just removes the fast API to fix the bug and
improve the performance.
PR-URL: https://github.com/nodejs/node/pull/58489
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-06-03 10:15:39 +00:00
Ethan Arrowood
2be863be08
dns: fix dns query cache implementation
...
PR-URL: https://github.com/nodejs/node/pull/58404
Refs: https://github.com/nodejs/node/pull/57640
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
2025-06-02 15:29:36 +00:00
Stefan Stojanovic
ef9cd8f062
build,win: fix dll build
...
Fixes: https://github.com/nodejs/node/issues/58208
PR-URL: https://github.com/nodejs/node/pull/58357
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-06-02 11:23:28 +00:00
Juan José
9dc41f27f4
permission: remove useless conditional
...
Deleting a null pointer has no effect. The check is not needed.
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/58514
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
2025-06-02 05:01:00 +00:00
Aditi
f4978814d4
src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
...
PR-URL: https://github.com/nodejs/node/pull/58500
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-31 18:58:07 +00:00
James M Snell
62ba6196d4
sqlite: cleanup ERM support and export Session class
...
Update sqlite Session to support Symbol.dispose and
move the definition of the dispose methods to c++ to
close the open TODO
PR-URL: https://github.com/nodejs/node/pull/58378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-05-30 17:21:30 -07:00
Tobias Nießen
7622f0d050
src: fix FIPS init error handling
...
If `--enable-fips` or `--force-fips` fails to be applied during
`ProcessFipsOptions()`, the node process might exit with
`ExitCode::kNoFailure` because `ERR_GET_REASON(ERR_peek_error())` can
return `0` since `ncrypto::testFipsEnabled()` does not populate the
OpenSSL error queue.
You can likely test this locally by running
node --enable-fips && echo $?
with the current `node` binary from the main branch if compiled without
support for FIPS.
As confirmed by the `XXX` comment here, which was added three years ago
in commit b697160256 , even if the error
queue was populated properly, the OpenSSL reason codes are not really
related to the Node.js `ExitCode` enumeration.
PR-URL: https://github.com/nodejs/node/pull/58379
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2025-05-30 11:23:57 +00:00
Chengzhong Wu
7ffa029750
src,lib: obtain sourceURL in magic comments from V8
...
Obtain sourceURL magic comments via V8 API to avoid a second round of
extraction of magic comments.
Updates source map snapshot normalization to allow testing full path
names inside the test outputs.
PR-URL: https://github.com/nodejs/node/pull/58389
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2025-05-30 09:47:20 +00:00
Eusgor
a8e9f634d3
src: fix possible dereference of null pointer
...
There is a CHECK_NOT_NULL check before dereferencing node_env on
line 710 in the "if" block, but there is no CHECK_NOT_NULL check before
dereferencing node_env on line 721. Maybe it makes sense to put
CHECK_NOT_NULL right after calling the Environment::GetCurrent function.
PR-URL: https://github.com/nodejs/node/pull/58459
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-29 20:01:48 +00:00
James M Snell
4eeb78b999
src: add env->cppgc_allocation_handle() convenience method
...
Reduce some of the boilerplate code needed to access the
cppgc::AllocationHandle from the Node.js Environment.
PR-URL: https://github.com/nodejs/node/pull/58483
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-29 15:32:43 +00:00
Chengzhong Wu
56989d33f5
src: remove deprecated node::EmitBeforeExit and node::EmitExit
...
PR-URL: https://github.com/nodejs/node/pull/58469
Refs: https://github.com/nodejs/node/pull/35486
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2025-05-29 08:09:13 +00:00
Chengzhong Wu
d429aa2d17
src: remove deprecated node::CreatePlatform and node::FreePlatform
...
PR-URL: https://github.com/nodejs/node/pull/58470
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-05-28 17:24:42 +00:00
Chengzhong Wu
e0ae14ce73
src: remove deprecated node::InitializeNodeWithArgs
...
PR-URL: https://github.com/nodejs/node/pull/58470
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-05-28 17:24:41 +00:00
Shelley Vohr
47081ee21c
src: fix -Wreturn-stack-address error
...
PR-URL: https://github.com/nodejs/node/pull/58439
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2025-05-28 13:56:20 +00:00
Shima Ryuhei
a4c7c9f6d7
inspector: add mimeType and charset support to Network.Response
...
Refs: https://github.com/nodejs/node/issues/53946
PR-URL: https://github.com/nodejs/node/pull/58192
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-28 10:15:37 +00:00
Noritaka Kobayashi
3877800ffb
doc,src,test: fix typos
...
PR-URL: https://github.com/nodejs/node/pull/58477
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com >
2025-05-28 08:18:47 +00:00
Node.js GitHub Bot
44a53759c7
deps: update undici to 7.10.0
...
PR-URL: https://github.com/nodejs/node/pull/58445
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
2025-05-27 23:19:22 +00:00
James M Snell
a430ef50aa
src: prepare for v8 sandboxing
...
PR-URL: https://github.com/nodejs/node/pull/58376
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-05-26 09:04:31 -07:00
Chengzhong Wu
d3bc4549ec
src: reorganize ContextifyFunction methods
...
PR-URL: https://github.com/nodejs/node/pull/58434
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2025-05-26 14:01:34 +00:00
Chengzhong Wu
41e4953832
src: improve CompileFunctionAndCacheResult error handling
...
PR-URL: https://github.com/nodejs/node/pull/58434
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2025-05-26 14:01:33 +00:00
Colin Ihrig
e201299011
sqlite: handle thrown errors in result callback
...
This commit updates the aggregate function 'result' callback
handling to not crash when an exception is thrown.
Fixes: https://github.com/nodejs/node/issues/58425
PR-URL: https://github.com/nodejs/node/pull/58426
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2025-05-25 21:49:37 +00:00
James M Snell
33505d1bb0
src: make a number of minor improvements to buffer
...
When using Buffer::New with an externally allocated buffer and
v8 sandbox enabled, defer to copy instead of wrapping the buffer.
Also, when immediately memcpy'ing into the full buffer, allocate
the buffer with kUninitialized as a slight perf optimization.
PR-URL: https://github.com/nodejs/node/pull/58377
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
2025-05-24 14:11:22 -07:00