Evan Lucas
7271cb047c
src: add process.versions.icu
...
If i18n support is present, add the icu version
to process.versions
Fixes: https://github.com/nodejs/node/issues/3089
PR-URL: https://github.com/nodejs/node/pull/3102
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Rod Vagg <rod@vagg.org >
2015-10-07 20:39:15 -07:00
Minwoo Jung
f92aee7170
doc: fix outdated 'try/catch' statement in sync
...
Fixes description about crypto.randomBytes.
Fixes: https://github.com/nodejs/node/issues/3081
PR-URL: https://github.com/nodejs/node/pull/3087
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2015-10-02 13:39:25 +10:00
Rich Trott
928166c4a8
doc: copyedit fs.watch() information
...
Removed "Only FSEvents supports this type of file watching so it is
unlikely any additional platforms will be added soon."
Per @saghul, "FSEvents" refers to the OSX API, but since we added
Windows support it may not be unlikely that we add more.
PR-URL: https://github.com/nodejs/node/pull/3097
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com >
2015-10-02 13:39:24 +10:00
Fabio Oliveira
b28f6a53bc
docs: Clarify assert.doesNotThrow behavior
...
The documentation for assert.doesNotThrow now reflects all the inputs
the function accepts, as well as the errors thrown for each combination
of parameter types.
PR-URL: https://github.com/nodejs/node/pull/2807
Reviewed-By: Rich Trott <rtrott@gmail.com >
2015-09-24 22:09:45 -07:00
Laurent Fortin
5c3f50b21d
doc: rearrange execSync and execFileSync
...
Changed the ordering so it is in line with the async methods.
PR-URL: https://github.com/nodejs/node/pull/2940
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2015-09-24 22:09:45 -07:00
Laurent Fortin
4fc33ac11a
doc: make execFileSync in line with execFile
...
PR-URL: https://github.com/nodejs/node/pull/2940
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2015-09-24 22:09:44 -07:00
reggi
a366e84b17
doc: fix typos in cluster & errors
...
PR-URL: https://github.com/nodejs/node/pull/3011
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2015-09-24 22:09:44 -07:00
Sakthipriyan Vairamani
43e2b7f836
doc: remove usage of events.EventEmitter
...
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: https://github.com/nodejs/node/pull/2896
PR-URL: https://github.com/nodejs/node/pull/2921
Reviewed-By: Roman Reiss <me@silverwind.io >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2015-09-23 08:39:34 +10:00
Christopher J. Brody
9c59d2f16a
doc: remove extra using v8::HandleScope statement
...
v8::HandleScope does not seem to be required for addon functions.
PR-URL: https://github.com/nodejs/node/pull/2983
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2015-09-22 16:31:39 +10:00
Rich Trott
f7edbab367
doc: clarify description of assert.ifError()
...
This fixes a few typographical errors (comma splices and the like) and
clarifies the description of assert.ifError(). It also standardizes the
document on "inequality" rather than having both "inequality" and "non-
equality".
PR-URL: https://github.com/nodejs/node/pull/2941
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2015-09-20 10:31:26 -07:00
Rich Trott
b2ddf0f9a2
doc: refine process.kill() and exit explanations
...
Add corrections about when exit event fires and how .kill() works on
Windows.
PR-URL: https://github.com/nodejs/node/pull/2918
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
2015-09-20 10:30:53 -07:00
Rich Trott
bf42cc8dba
doc: process exit event is not guaranteed to fire
...
This change:
* notes that the exit event is not guaranteed to fire
* provides an example situation where the exit event may not fire
* makes a minor copyediting change
* enforces 80 character wrap in one place where it was not honored
Fixes: https://github.com/nodejs/node/issues/2853
PR-URL: https://github.com/nodejs/node/pull/2861
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2015-09-16 21:03:51 -04:00
Sam Roberts
bb0f869f67
doc: remove incorrect reference to TCP in net docs
...
createServer() can create socket of types other than TCP.
PR-URL: https://github.com/nodejs/node/pull/2903
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2015-09-16 16:07:59 -04:00
Sam Roberts
302d59dce8
doc: correct buffer.slice arg syntax
...
PR-URL: https://github.com/nodejs/node/pull/2903
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2015-09-16 16:07:58 -04:00
Sam Roberts
74db9637b7
doc: describe spawn option.detached
...
PR-URL: https://github.com/nodejs/node/pull/2903
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2015-09-16 16:07:58 -04:00
Sam Roberts
f931b9dd95
timer: ref/unref return self
...
Most calls to ref() and unref() are chainable, timers should be
chainable, too.
Typical use:
var to = setTimeout(ontimeout, 123).unref();
PR-URL: https://github.com/nodejs/node/pull/2905
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Trevor Norris <trevnorris@nodejs.org >
2015-09-16 16:07:58 -04:00
Sven Slootweg
cd643d7c37
doc: add missing backtick in buffer.markdown
...
Fixes: https://github.com/nodejs/node/issues/2880
PR-URL: https://github.com/nodejs/node/pull/2881
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2015-09-15 14:06:19 -04:00
Yazhong Liu
6108ea9bb4
fs: consider NaN/Infinity in toUnixTimestamp
...
PR-URL: https://github.com/nodejs/node/pull/2387
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-09-15 13:53:00 -04:00
Danny Nemer
e8a206e802
doc: fix broken link in repl.markdown
...
PR-URL: https://github.com/nodejs/node/pull/2827
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2015-09-14 21:50:59 -04:00
Jeremiah Senkpiel
2d77d03643
doc: fix two doc errors in stream and process
...
`process.stdout` always blocks as of
20176a9841
`WritableState.buffer` is `getBuffer()` as of
91586661c9
PR-URL: https://github.com/nodejs/node/pull/2549
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2015-09-14 21:50:58 -04:00
Tristian Flanagan
55ac24f721
doc: fixed io.js references in process.markdown
...
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2846
2015-09-14 21:50:58 -04:00
Minwoo Jung
cd1297fb57
doc: use "Calls" over "Executes" for consistency
...
"Calls" is used frequently throughout the docs except for this line.
Use "Calls" over "Executes" to make it consistent.
PR-URL: https://github.com/nodejs/node/pull/2800
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2015-09-14 21:50:57 -04:00
Anne-Gaelle Colom
d664b95581
doc: use US English for consistency
...
behaviour -> behavior
PR-URL: https://github.com/nodejs/node/pull/2784
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2015-09-11 11:31:20 +10:00
Anne-Gaelle Colom
82ba1839fb
doc: use 3rd person singular for consistency
...
PR-URL: https://github.com/nodejs/node/pull/2765
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2015-09-11 11:31:20 +10:00
Sam Roberts
432cce6e95
doc: describe process API for IPC
...
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
PR-URL: https://github.com/nodejs/node/pull/1978
2015-09-11 11:31:19 +10:00
Rich Trott
1d75012b9d
doc: fix comma splice in Assertion Testing doc
...
This fixes a minor typographical error in the Assertion Testing doc.
PR-URL: https://github.com/nodejs/node/pull/2728
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
2015-09-09 09:05:11 +10:00
Sakthipriyan Vairamani
7038388558
doc,test: enable recursive file watching in Windows
...
Recursive file watching is supported by libuv since 1.7.0. Refer
https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126 . This
patch notes that in the docs and enables testing this feature. It also
adds proper TAP plugin parsable message for other platforms.
PR-URL: https://github.com/nodejs/node/pull/2649
Fixes: https://github.com/nodejs/node/issues/375
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org >
Reviewed-By: silverwind - Roman Reiss <me@silverwind.io >
2015-09-06 21:39:06 +10:00
Jeremiah Senkpiel
29f586ac0a
doc: update url doc to account for escaping
...
Fixes: https://github.com/nodejs/node/issues/2113
Ref: 17a379ec39
PR-URL: https://github.com/nodejs/node/pull/2605
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: mscdex - Brian White <mscdex@mscdex.net >
2015-09-06 21:38:59 +10:00
Ben Noordhuis
d010568c23
child_process: add callback parameter to .send()
...
Add an optional callback parameter to `ChildProcess.prototype.send()`
that is invoked when the message has been sent.
Juggle the control channel's reference count so that in-flight messages
keep the event loop (and therefore the process) alive until they have
been sent.
`ChildProcess.prototype.send()` and `process.send()` used to operate
synchronously but became asynchronous in commit libuv/libuv@393c1c5
("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed
in io.js in commit 07bd05b ("deps: update libuv to 1.2.1").
Fixes: https://github.com/nodejs/node/issues/760
PR-URL: https://github.com/nodejs/node/pull/2620
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2015-09-06 21:38:58 +10:00
Jeremiah Senkpiel
4c5fc3b1d4
doc: clarify cluster behaviour with no workers
...
Fixes: https://github.com/nodejs/node/issues/1239
Ref: 41b75ca926
PR-URL: https://github.com/nodejs/node/pull/2606
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
2015-08-28 20:32:56 -04:00
Ben Noordhuis
de88255b0f
Revert "lib,src: add unix socket getsockname/getpeername"
...
This reverts commit 6cd0e2664b .
This reverts commit 7a999a1376 .
This reverts commit f337595441 .
It turns out that on Windows, uv_pipe_getsockname() is a no-op for
client sockets. It slipped through testing because of a CI snafu.
PR-URL: https://github.com/nodejs/node/pull/2584
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2015-08-28 00:14:13 +02:00
Ben Noordhuis
6cd0e2664b
doc: update io.js reference
...
Commit f337595 ("lib,src: add unix socket getsockname/getpeername")
accidentally left in a reference to io.js v1.5.0 in the documentation.
Update it to say "Node.js v4.0.0", the upcoming release.
PR-URL: https://github.com/nodejs/node/pull/2580
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2015-08-27 18:00:55 +02:00
Ben Noordhuis
7a999a1376
lib: add net.Socket#localFamily property
...
Complements the existing net.Socket#remoteFamily property.
PR-URL: https://github.com/nodejs/node/pull/956
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-08-27 17:45:29 +02:00
Ben Noordhuis
f337595441
lib,src: add unix socket getsockname/getpeername
...
The implementation is a minor API change in that socket.address() now
returns a `{ address: '/path/to/socket' }` object, like it does for TCP
and UDP sockets. Before this commit, it returned `socket._pipeName`,
which is a string when present.
Change common.PIPE on Windows from '\\\\.\\pipe\\libuv-test' to
'\\\\?\\pipe\\libuv-test'. Windows converts the '.' to a '?' when
creating a named pipe, meaning that common.PIPE didn't match the
result from NtQueryInformationFile().
Fixes: https://github.com/nodejs/node/issues/954
PR-URL: https://github.com/nodejs/node/pull/956
Reviewed-By: Sam Roberts <vieuxtech@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-08-27 17:45:04 +02:00
Сковорода Никита Андреевич
d6714ff1a4
doc: minor clarification in buffer.markdown
...
Replaced "contents is" with "contents are".
Added a note that initial Buffer contents could contain sensitive data.
PR-URL: https://github.com/nodejs/node/pull/2574
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2015-08-27 18:08:13 +03:00
James M Snell
2e8bb62011
doc: fix bad merge on modules.markdown
...
My previous commit landed a bad merge on modules.markdown.
This fixes it.
2015-08-25 19:00:02 -07:00
James M Snell
09768e306c
doc: minor additional corrections and improvements
...
Per feedback from @thefourtheye: (a) improve word on the
description of the `close` event in stream.markdown and
(b) remove `[module section]: modules.html` from
globals.markdown
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:52 -07:00
James M Snell
758d02e4e9
doc: minor grammatical update in crypto.markdown
...
Per: https://github.com/joyent/node/pull/8878
Originally submitted by @jacksonhoose
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:47 -07:00
James M Snell
b11ba2791c
doc: minor grammatical update
...
Per: https://github.com/joyent/node/pull/9009
Originally submitted by @peerwit
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:42 -07:00
James M Snell
c58a63a18e
doc: remove repeated statement in globals.markdown
...
Per: https://github.com/joyent/node/pull/25102
Originally reported by @kuldipem
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:37 -07:00
James M Snell
ac0563f97d
doc: remove 'dudes' from documentation
...
per: https://github.com/joyent/node/pull/25572#discussion_r33197896
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:32 -07:00
James M Snell
a5b7852292
doc: update tense in child_process.markdown
...
per: https://github.com/joyent/node/pull/25826
originally submitted by: @ClimbsRocks
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:28 -07:00
James M Snell
89788dc347
doc: fixed worker.id type
...
per: https://github.com/joyent/node/pull/25459
originally submitted by @sonnyp
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:25 -07:00
James M Snell
c549c8b30c
doc: port is optional for socket.bind()
...
per: https://github.com/joyent/node/pull/25356
originally submitted by @dcousens
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:20 -07:00
James M Snell
281be6ce65
doc: fix minor types and grammar in fs docs
...
per: https://github.com/joyent/node/pull/7431
originally submitted by @linclark
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:13 -07:00
James M Snell
0679dcc9b7
doc: update parameter name in net.markdown
...
per: https://github.com/joyent/node/pull/7112
originally submitted by @Peekmo
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:09 -07:00
James M Snell
3cecff35ce
doc: small typo in domain.markdown
...
per: https://github.com/joyent/node/pull/7715
originally submitted by @tonylukasavage
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:05 -07:00
James M Snell
36151d698d
doc: fixed typo in net.markdown (missing comma)
...
per: https://github.com/joyent/node/pull/7930
originally submitted by @pbrewczynski
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:52:01 -07:00
James M Snell
7860977524
doc: update description of fs.exists in fs.markdown
...
per: https://github.com/joyent/node/pull/7944
originally submitted by @oconnore
Minor update to the description in `fs.exists()`
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:51:57 -07:00
James M Snell
db4cb338be
doc: clarification on the 'close' event
...
per: https://github.com/joyent/node/pull/8209
originally submitted by @jeromew
Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/2378
2015-08-25 18:51:53 -07:00