Michael Dawson
d10c71798d
src: suppress false coverity warning
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42284
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-22 17:40:28 -04:00
Gerhard Stöbich
da399a6c8e
async_hooks: remove destroyed symbol on Promises
...
Promises are never destroyed manually therefore it's not needed to
attach an object to track if destroy hook was called already.
PR-URL: https://github.com/nodejs/node/pull/42402
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-03-21 20:35:05 +00:00
Vladimir Morozov
718be08686
node-api: format Node-API related code
...
PR-URL: https://github.com/nodejs/node/pull/42396
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-21 13:24:16 -04:00
Tobias Nießen
df39fd64b3
src: refactor IsSupportedAuthenticatedMode
...
Improve the function's structure and clarify the special handling of
ChaCha20-Poly1305. Remove the IS_OCB_MODE macro.
PR-URL: https://github.com/nodejs/node/pull/42368
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-21 15:30:07 +00:00
Tobias Nießen
cc94563c14
crypto: fix auth tag length error when mode != GCM
...
PR-URL: https://github.com/nodejs/node/pull/42383
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-20 12:18:52 +00:00
Darshan Sen
57529b22c4
src: convert hex2bin() into a regular function
...
No need to write hex2bin() as a function template because it's only
called with a char parameter.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/42321
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-03-18 19:57:32 +00:00
Rich Trott
44131ad638
worker: do not send message if port is closing
...
Fixes: https://github.com/nodejs/node/issues/42296
PR-URL: https://github.com/nodejs/node/pull/42357
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-03-18 06:32:22 -07:00
Michael Dawson
6d0e92a9d6
src: fix coverity warnings in node_file.cc
...
Fix two warnings about a useless call and not checking
a return value.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42272
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-14 17:58:12 -04:00
Tobias Nießen
4aae5364f7
src: check EC_POINT_get_affine_coordinates result
...
PR-URL: https://github.com/nodejs/node/pull/42304
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-14 19:15:17 +00:00
Tobias Nießen
afcfaa07ac
src: simplify bound check in ParseArrayIndex
...
PR-URL: https://github.com/nodejs/node/pull/42306
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-14 16:36:39 +00:00
Tobias Nießen
d90ceb2b54
src: avoid returning invalid value from hex2bin
...
If the input is not a valid hexadecimal digit, hex2bin should not return
an invalid value, which is not handled correctly by the caller, which is
the PercentDecode function. However, PercentDecode only ever calls the
hex2bin function with valid hexadecimal digits, so mark the code path
that previously returned an invalid value for non-digits as UNREACHABLE.
PR-URL: https://github.com/nodejs/node/pull/42307
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-14 16:23:44 +00:00
Tobias Nießen
a718ef91f4
src: check return value of HMAC_Final
...
PR-URL: https://github.com/nodejs/node/pull/42303
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-14 14:23:14 +00:00
Joyee Cheung
457567f72c
src: include crypto in the bootstrap snapshot
...
To lazy load the run time options, the following properties
are updated from value properties to accessor properties
whose getter would turn them back to a value properties
upon the initial access.
- crypto.constants.defaultCipherList
- crypto.pseudoRandomBytes
- crypto.prng
- crypto.rng
PR-URL: https://github.com/nodejs/node/pull/42203
Refs: https://github.com/nodejs/node/issues/37476
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-03-11 17:15:13 +00:00
Joyee Cheung
de163d5db6
src: include internal/options in the snapshot
...
This patch enables internal/options to be included in the snapshot,
so that when lazy loading the run time options, the modules only
need to make sure that the options are queried lazily and do not
have to lazy load the internal/options module together. We can
still guarantee that no run time options are serialized into the
state-independent bootstrap snapshot with the assertion inside
GetCLIOptions().
PR-URL: https://github.com/nodejs/node/pull/42203
Refs: https://github.com/nodejs/node/issues/37476
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-03-11 17:15:12 +00:00
Rich Trott
d8c4e375f2
url: preserve null char in WHATWG URL errors
...
A null character in the middle of an invalid URL was resulting in an
error message that truncated the input string. This preserves the entire
input string in the error message.
Refs: https://github.com/nodejs/node/issues/39592
PR-URL: https://github.com/nodejs/node/pull/42263
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-11 05:51:41 +00:00
Tobias Nießen
da7916676b
src: remove redundant buffer size check
...
This condition is already checked by the CHECK_BUFLEN_IN_RANGE macro,
so if it was true here, that would contradict the previous check.
PR-URL: https://github.com/nodejs/node/pull/42257
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-10 23:48:01 +00:00
Anna Henningsen
72e83fcea6
src: perform minor cleanups on zlib code
...
- Use `final` to indicate the classes that we actually
instantiate
- Properly use `const` (and the necessary associated `const_cast`
for zlib because we don’t define `ZLIB_CONST` and allow shared
builds)
- Store the JS callback in an internal field rather than a `Global`
(which improves memory leak debugging capabilities, removes
a potential future memory leak footgun, and aligns the code
with the rest of the codebase more closely)
- Other minor C++ cleanup
PR-URL: https://github.com/nodejs/node/pull/42247
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-10 11:51:12 +00:00
Michael Dawson
82342c2a54
http2: fix potential integer overflow
...
Fix report from coverity on potential integer overflow
in http2.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42248
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-03-10 08:53:05 +00:00
Tobias Nießen
e1fb6ae02f
crypto: prettify othername in PrintGeneralName
...
Refs: https://github.com/nodejs/node/commit/466e5415a2b7b3574ab5403acb87e89a94a980d1
PR-URL: https://github.com/nodejs/node/pull/42123
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-03-09 16:36:51 +00:00
Tobias Nießen
36fb79030e
crypto: fix X509Certificate toLegacyObject
...
PR-URL: https://github.com/nodejs/node/pull/42124
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-03-09 16:36:40 +00:00
Darshan Sen
6b004f1bb1
src,crypto: avoid tristate Maybe<bool> in ExportJWKEcKey()
...
The function currently uses the return value to convey whether an
exception was thrown while it was running by using either Just(true) or
Nothing<bool>(). Unfortunately, Maybe<bool> also has a third state -
Just(false), which doesn't make any sense here. So this change avoids
the possibility of a tristate return value by making use of Maybe<void>
which only has two valid states - JustVoid() / Nothing<void>(), which
fits right in.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/42223
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-08 22:40:28 +00:00
Yash Ladha
f2676b9ea9
src: use emplace_back instead of push_back
...
PR-URL: https://github.com/nodejs/node/pull/42159
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-08 23:31:56 +01:00
Tobias Nießen
e8697cfe38
crypto: improve prime size argument validation
...
The current validation in JavaScript is insufficient and also produces
an incorrect error message, restricting the size parameter to 32-bit
values, whereas the C++ backend restricts the size parameter to the
positive range of an int.
This change tightens the validation in JavaScript and adapts the error
message accordingly, making the validation in C++ superfluous.
Refs: https://github.com/nodejs/node/pull/42207
PR-URL: https://github.com/nodejs/node/pull/42234
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-08 17:33:38 +00:00
Tobias Nießen
3dcab2b30a
crypto: fix fingerprint string size calculation
...
The function generating fingerprint strings never accesses more than
EVP_MAX_MD_SIZE * 3 characters, including the terminating '\0'.
PR-URL: https://github.com/nodejs/node/pull/42175
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-03-07 22:42:22 +00:00
Tobias Nießen
9440429b6b
crypto: add CHECKs to remaining BIO_s_mem allocs
...
PR-URL: https://github.com/nodejs/node/pull/42155
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-07 21:28:42 +00:00
Michael Dawson
c6db0f0f63
src: fix unchecked return warning from coverity
...
Fix unchecked return warning from coverity in
src/env.cc. Added check in same manner as other
places where uv_async_init is called.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42176
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2022-03-07 13:00:04 -05:00
Anna Henningsen
64832c12b1
src: return proper URLs from node_api_get_module_file_name
...
Using `file://${path}` does not properly escape special URL characters.
PR-URL: https://github.com/nodejs/node/pull/41758
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-03-07 15:57:54 +01:00
XadillaX
4158d62dec
url, src: modify one special_back_slash
...
Make it always equals to `false`.
PR-URL: https://github.com/nodejs/node/pull/42112
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-07 13:04:48 +08:00
Xuguang Mei
3d4f3ca5eb
src: skip revoke_data_object if uuid is not found
...
Fix: https://github.com/nodejs/node/issues/42206
PR-URL: https://github.com/nodejs/node/pull/42212
Fixes: https://github.com/nodejs/node/issues/42206
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-06 09:24:42 +00:00
Rafael Silva
db6490cba2
http2: close stream and session on frameError
...
PR-URL: https://github.com/nodejs/node/pull/42147
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-03-02 12:53:11 +00:00
Tobias Nießen
ef30a226ce
src: remove dead code in AddFingerprintDigest
...
This function is never called with md_size == 0, and it would make no
sense to do so in the future either.
PR-URL: https://github.com/nodejs/node/pull/42145
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-01 16:21:18 +00:00
Michael Dawson
a9c0689786
crypto: fix return type prob reported by coverity
...
Coverity correctly reported that the value returned
by BIO_get_mem_data could be negative and the type
provided for the return value was unsigned.
Fix up the type and check.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/42135
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-03-01 09:05:29 -05:00
Tobias Nießen
0f2ab70542
src: combine GetCurveASN1Name and GetCurveNistName
...
PR-URL: https://github.com/nodejs/node/pull/42118
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:24:52 +00:00
Tobias Nießen
0b5e8e01ab
src: simplify TLSWrap::SetSession
...
PR-URL: https://github.com/nodejs/node/pull/42087
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:07:42 +00:00
Tobias Nießen
2cdf8a44e9
src: prefer bool over int in crypto_common
...
PR-URL: https://github.com/nodejs/node/pull/42097
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:06:02 +00:00
Tobias Nießen
a41992de9e
src: simplify arg type of AddFingerprintDigest
...
PR-URL: https://github.com/nodejs/node/pull/42101
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:05:51 +00:00
Tobias Nießen
1ce42ec18b
src: do not ignore return value of BIO_reset
...
The USE macro indicates that a value is intentionally ignored. Instead,
CHECK that the function succeeds.
PR-URL: https://github.com/nodejs/node/pull/42103
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:05:42 +00:00
Tobias Nießen
f71fca769e
src: simplify GetExponentString
...
PR-URL: https://github.com/nodejs/node/pull/42121
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-27 14:05:34 +00:00
Filip Skokan
aa97c9d973
crypto: add KeyObject.prototype.equals method
...
PR-URL: https://github.com/nodejs/node/pull/42093
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-26 13:51:09 +00:00
Austin Kelleher
663a669b0b
node-api: fix typo in node_api.cc
...
PR-URL: https://github.com/nodejs/node/pull/42110
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2022-02-24 19:04:50 +01:00
Shelley Vohr
0367b5c35e
src: allow preventing InitializeInspector in env
...
PR-URL: https://github.com/nodejs/node/pull/35025
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-23 23:32:30 +00:00
Tobias Nießen
563b2ed000
crypto: use RFC2253 format in PrintGeneralName
...
For backward compatibility, node uses X509_NAME_oneline to format
X509_NAME entries in PrintGeneralName. However, the format produced by
this function is non-standard and its use is discouraged. It also does
not handle Unicode names correctly.
This change switches to X509_NAME_print_ex with flags that produce an
RFC2253-compatible format. Non-ASCII strings are converted to UTF-8 and
preserved in the output. Control characters are not escaped by OpenSSL
when producing the RFC2253 format because they will be escaped by node
in a JSON-compatible manner afterwards.
PR-URL: https://github.com/nodejs/node/pull/42002
Refs: https://github.com/nodejs/node/pull/42001
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2022-02-22 15:27:01 +00:00
Michaël Zasso
4944ad0b9e
lib: enable fetch by default
...
PR-URL: https://github.com/nodejs/node/pull/41811
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2022-02-21 12:34:13 +00:00
Tobias Nießen
bd0474974a
crypto: check result of BIO_new in X509ToObject
...
Match other call sites of BIO_new(BIO_s_mem()) and CHECK the result of
the call.
Refs: https://github.com/nodejs/node/commit/fb3a9cd0d8e8cf5f3120012a28643230b31c1f83
PR-URL: https://github.com/nodejs/node/pull/41979
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-17 23:11:54 +00:00
Tobias Nießen
19370b3176
crypto: rename X509_NAME_FLAGS
...
Rename X509_NAME_FLAGS to kX509NameFlagsMultiline to better align with
the naming conventions we use for constexpr values, to distinguish it
from OpenSSL's built-in X509 constants, and to clarify what specific
X509 name flags the constant represents.
PR-URL: https://github.com/nodejs/node/pull/42001
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-02-17 23:11:46 +00:00
Darshan Sen
5edad38328
src,buffer: evaluate THROW_AND_RETURN_IF_OOB() expression only once
...
There's no need to evaluate the expression passed into the macro more
than once.
Fixes: https://github.com/nodejs/node/issues/41935
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/41945
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2022-02-18 00:05:42 +01:00
Antoine du Hamel
849991c6c4
crypto: expose Web Crypto API on the global scope
...
PR-URL: https://github.com/nodejs/node/pull/41938
Refs: https://developer.mozilla.org/en-US/docs/Web/API/crypto_property
Refs: https://github.com/nodejs/node/pull/41782
Refs: https://w3c.github.io/webcrypto
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2022-02-14 16:14:49 +00:00
Anna Henningsen
34be1af5e1
src: merge ToJsSet into ToV8Value
...
This addresses a `TODO` comment, and makes use of the opportunity
to also clean up our `MaybeLocal` handling in this area and
start accepting `std::string_view` where we accept `std::string`.
PR-URL: https://github.com/nodejs/node/pull/41757
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-02-14 00:44:30 +01:00
Raymond Zhao
863d13c192
child_process: kHideConsoleWindows for spawnSync
...
kHideConsoleWindows should hide console windows for
execSync and spawnSync calls as well. This fix adds on
to https://github.com/nodejs/node/pull/39712 .
PR-URL: https://github.com/nodejs/node/pull/41412
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2022-02-11 17:30:56 +00:00
Anna Henningsen
b51eba422f
src: remove separate definitions for static constexpr members
...
This is no longer necessary (and actually deprecated) since C++17.
PR-URL: https://github.com/nodejs/node/pull/41755
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-02-11 16:42:09 +00:00