Sam Roberts
08387b245e
tls: remove unused ocsp extension parsing
...
The OCSP info from parsing the TLS ClientHello has not been used since
550c263https://github.com/nodejs/node/pull/1464
PR-URL: https://github.com/nodejs/node/pull/25153
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com >
2018-12-28 12:57:24 -08:00
Diana Holland
98afca92a9
crypto: move field initialization to class
...
PR-URL: https://github.com/nodejs/node/pull/23610
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com >
2018-10-15 02:45:54 +02:00
Daniel Bevenius
85d5885f52
crypto: remove unused header in clienthello.h
...
This commit removes stdlib.h header as it does not seem to be used any
more.
PR-URL: https://github.com/nodejs/node/pull/17752
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2017-12-19 14:36:55 +01:00
Ben Noordhuis
98a6f63e45
src: fix -Wundefined-inline warnings
...
Fix compiler warnings introduced in commit 47edfd9c3chttps://github.com/nodejs/node/pull/17649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Timothy Gu <timothygu99@gmail.com >
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2017-12-15 07:47:42 +01:00
Daniel Bevenius
7bb2cc43c6
src: remove unused include node_crypto_clienthello
...
This commit removes the include of node.h which does not seem to be
used.
PR-URL: https://github.com/nodejs/node/pull/17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-12-11 13:01:07 +01:00
Daniel Bevenius
08109a3ca1
src: move crypto_bio/clienthello to crypto ns
...
Currently, node_crypto_bio and node_crypto_clienthello are not in the
crypto namespace but simply in the node namespace. Not sure if this was
intentional or not, but I think it would make sense to move them to be
consistent.
PR-URL: https://github.com/nodejs/node/pull/13957
Reviewed-By: Refael Ackermann <refack@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2017-06-30 07:23:25 +02:00
James M Snell
98e54b0bd4
meta: restore original copyright header
...
A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.
Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155
Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.
2017-03-10 11:23:48 -08:00
Fedor Indutny
c9f6776d2b
crypto: fix undefined behavior in ParseExtension
...
Many extensions are unknown to the `ClientHelloParser::ParseExtension`,
do not cast user-supplied `uint16_t` to `enum`.
PR-URL: https://github.com/nodejs/node/pull/7494
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-07-11 02:23:28 -04:00
Ben Noordhuis
eff96d32dc
src: add include guards to internal headers
...
For consistency with the newly added src/base64.h header, check that
NODE_WANT_INTERNALS is defined and set in internal headers.
PR-URL: https://github.com/nodejs/node/pull/6948
Refs: https://github.com/nodejs/node/pull/6910
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-05-25 09:54:24 +02:00
isaacs
3e1b1dd4a9
Remove excessive copyright/license boilerplate
...
The copyright and license notice is already in the LICENSE file. There
is no justifiable reason to also require that it be included in every
file, since the individual files are not individually distributed except
as part of the entire package.
2015-01-12 15:30:28 -08:00
Ben Noordhuis
26dd9e15bb
build,src: remove sslv2 support
...
SSLv2 has been deprecated and known broken for nearly twenty years now.
I made SSLv2 support opt-in well over a year ago in commit 39aa894https://github.com/iojs/io.js/pull/290
Reviewed-By: Fedor Indutny <fedor@indutny.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
2015-01-11 16:07:45 +01:00
Ben Noordhuis
5ab87dba73
src: mark empty destructors as default
...
Mark empty destructors as having a default no-op implementation.
Remove a few unused constructors and destructors while we are here.
2014-10-23 22:49:59 +02:00
Ben Noordhuis
2d82cdf670
src: replace NULL with nullptr
...
Now that we are building with C++11 features enabled, replace use
of NULL with nullptr.
The benefit of using nullptr is that it can never be confused for
an integral type because it does not support implicit conversions
to integral types except boolean - unlike NULL, which is defined
as a literal `0`.
2014-10-23 22:49:58 +02:00
Fedor Indutny
b3ef289ffb
tls: support OCSP on client and server
2014-04-18 02:21:16 +04:00
Fedor Indutny
048e0e77e0
tls: asynchronous SNICallback
...
Make ClientHelloParser handle SNI extension, and extend `_tls_wrap.js`
to support loading SNI Context from both hello, and resumed session.
fix #5967
2013-08-06 16:13:01 +04:00
Fedor Indutny
8e28193cc2
tls_wrap: DRY ClientHelloParser
...
Share ClientHelloParser code between `tls_wrap.cc` and `node_crypto.cc`.
fix #5959
2013-08-06 16:13:01 +04:00
Sam Roberts