Kohei Ueno
d102d16e98
tools: update inspector_protocol to 83b1154
...
PR-URL: https://github.com/nodejs/node/pull/51309
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
2024-01-11 04:41:26 +00:00
cola119
f6a83cdb6f
tools: update inspector_protocol to c488ba2
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:25 +00:00
cola119
02cdc95126
tools: update inspector_protocol to 9b4a4aa
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:24 +00:00
cola119
323ad042b9
tools: update inspector_protocol to 2f51e05
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:23 +00:00
cola119
0faa94cac8
tools: update inspector_protocol to d7b099b
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:23 +00:00
cola119
5cada97466
tools: update inspector_protocol to 912eb68
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:22 +00:00
cola119
ef5bac0a46
tools: update inspector_protocol to 547c5b8
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:21 +00:00
cola119
39ea735091
tools: update inspector_protocol to ca525fc
...
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-12-29 13:10:21 +00:00
Daniel Lemire
2990390359
inspector: simplify dispatchProtocolMessage
...
PR-URL: https://github.com/nodejs/node/pull/49780
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-09-30 01:58:09 +00:00
Antoine du Hamel
1e761654d3
doc: consolidate use of multiple-byte units
...
Refs: https://en.wikipedia.org/wiki/Byte#Multiple-byte_units
PR-URL: https://github.com/nodejs/node/pull/42587
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Mestery <mestery@protonmail.com >
2022-04-20 00:46:37 +02:00
Michaël Zasso
24c403cfaf
tools: patch jinja2 for Python 3.10 compat
...
PR-URL: https://github.com/nodejs/node/pull/40296
Fixes: https://github.com/nodejs/node/issues/40294
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-10-06 17:06:26 -07:00
Richard Lau
8c954103ab
tools: fix more build warnings in inspector_protocol
...
PR-URL: https://github.com/nodejs/node/pull/39725
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-12 14:45:48 -07:00
Darshan Sen
a48b9c330a
tools: cherry-pick ffb34b6d5d
...
Original commit message:
tools: fix compiler warning in inspector_protocol
error: comparison of integer expressions of different signedness:
‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
2562 | if (!success || std::numeric_limits<int32_t>::max() <
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
2563 | token_start_internal_value_) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
PR-URL: https://github.com/nodejs/node/pull/37573
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/39725
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-12 14:45:46 -07:00
Rich Trott
a1fac5b9a5
tools: update inspector_protocol to e8ba1a7
...
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-09 18:56:05 +00:00
Rich Trott
74c4f82282
tools: update inspector_protocol to 39ca567
...
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-09 18:56:04 +00:00
Rich Trott
0187474535
tools: update inspector_protocol to 97d3146
...
To apply the diff cleanly, ffb34b6 had to be reverted.
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-09 18:56:03 +00:00
Rich Trott
585d4efd7c
Revert "tools: fix compiler warning in inspector_protocol"
...
This reverts commit ffb34b6d5d .
PR-URL: https://github.com/nodejs/node/pull/39694
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-09 18:56:02 +00:00
Rich Trott
9bc2a5976c
tools: update inspector_protocol to a53e96d31a2755eb16ca37
...
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-09 18:56:01 +00:00
Rich Trott
c3df329889
tools: update inspector_protocol to fe0467fd105a
...
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-09 18:56:00 +00:00
Rich Trott
58316e2caa
inspector: update inspector_protocol to 89c4adf
...
Apply a366321, 37518ac, and 89c4adf to tools/inspector_protocol.
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
PR-URL: https://github.com/nodejs/node/pull/39650
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-08-05 13:57:43 +00:00
Rich Trott
9e904470f4
inspector: update inspector_protocol to 8ec18cf
...
Apply 8ec18cf: "Support STRING16 in the template when converting CBOR
map keys"
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+/8ec18cf0885bef0b5c2a922c5dc3813cbf63e962
We're over 2 years out of date in the tools/inspector_protocol directory
and I have to imagine this will come back to bite us at some point. But
I also don't want to do a huge update all at once, so starting with a
single commit. I might bundle commits together a bit more if this goes
well.
PR-URL: https://github.com/nodejs/node/pull/39614
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-08-03 04:54:54 +00:00
Antoine du Hamel
26e318a321
doc: use HEAD instead of master for links
...
PR-URL: https://github.com/nodejs/node/pull/38518
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-05-05 10:45:30 +02:00
Darshan Sen
ffb34b6d5d
tools: fix compiler warning in inspector_protocol
...
error: comparison of integer expressions of different signedness:
‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
2562 | if (!success || std::numeric_limits<int32_t>::max() <
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
2563 | token_start_internal_value_) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~
PR-URL: https://github.com/nodejs/node/pull/37573
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-03-04 22:27:31 +01:00
Daniel Bevenius
2e441e152f
tools: fix redundant-move warning in inspector
...
Currently, the following warning is generated from the inspector
protocol:
/out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:
In member function
‘virtual std::unique_ptr<node::inspector::protocol::Value>
node::inspector::protocol::ListValue::clone() const’:
/out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21:
error: redundant move in return statement [-Werror=redundant-move]
739 | return std::move(result);
| ~~~~~~~~~^~~~~~~~
This commit removes the move for DictionaryValue and ListValue.
PR-URL: https://github.com/nodejs/node/pull/32685
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matheus Marchini <mat@mmarchini.me >
2020-04-30 06:17:32 +02:00
Ben Noordhuis
484c24fd4e
tools: python3 compat for inspector code generator
...
The code generator takes a dict and turns it into a namedtuple. The dict
contains the key "async", which is a keyword in python 3.7, and rejected
by the namedtuple constructor. Rename it to "async_" to avoid the clash.
Fixes: https://github.com/nodejs/node/issues/29326
PR-URL: https://github.com/nodejs/node/pull/29340
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-09-12 09:26:57 -07:00
cclauss
4662f67e38
tools: fix Python 3 issues in inspector_protocol
...
PR-URL: https://github.com/nodejs/node/pull/29296
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2019-08-26 21:31:08 -07:00
Michaël Zasso and Ben Noordhuis
5aaa7fee2e
tools: update inspector_protocol to 0aafd2
...
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl >
PR-URL: https://github.com/nodejs/node/pull/27770
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2019-06-01 09:28:34 +02:00
Refael Ackermann
0befda6970
tools: python: update flake8 rules
...
* Tree-factor location of some *.py files for easy demarcation of
areas to exclude.
PR-URL: https://github.com/nodejs/node/pull/25614
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2019-04-13 20:32:55 -04:00
Ben Noordhuis
608878c956
build: fix inspector dependency resolution
...
It was reported that parallel builds on Windows sometimes error because
of missing intermediate files.
On closer inspection I noticed that some files are copied from src/ to
the intermediate build directory in a way where they don't participate
in dependency resolution. Put another way, the build system doesn't
know to wait for the copy to complete because we don't tell it to.
Fix that by not copying around files but instead making the script that
processes them a little smarter about where to find them and where to
store the results.
PR-URL: https://github.com/nodejs/node/pull/27026
Fixes: https://github.com/nodejs/node/issues/27025
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
2019-04-04 16:02:23 +02:00
Pavel Feldman
d775d74698
tools: roll inspector_protocol to f67ec5
...
Fixes: https://github.com/nodejs/node/issues/25808
PR-URL: https://github.com/nodejs/node/pull/26303
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Refael Ackermann <refack@gmail.com >
2019-03-04 11:44:49 -05:00
Andrey Lushnikov
e0395247c8
inspector: add inspector_protocol as a direct dependency
...
Currently, node.js depends on inspector_protocol indirectly through the
dependency on v8.
This is a dependency violation that will make it hard to roll V8 into
Node if V8 gets a newer inspector protocol version with incompatible
API. In fact, this surfaced on one of our bots when we tried to roll new
inspector_protocol into V8.
This patch adds inspector protocol and its required dependencies to node
deps:
- jinja2
- markupsafe
PR-URL: https://github.com/nodejs/node/pull/21975
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com >
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com >
2018-08-10 18:03:43 -07:00