Brian White
2bc7841d0f
test: use random ports where possible
...
This helps to prevent issues where a failed test can keep a bound
socket open long enough to cause other tests to fail with EADDRINUSE
because the same port number is used.
PR-URL: https://github.com/nodejs/node/pull/7045
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
2016-06-10 22:30:55 -04:00
James M Snell
dcccbfdc79
src: refactor require('constants')
...
The require('constants') module is currently undocumented and mashes
together unrelated constants. This refactors the require('constants')
in favor of distinct os.constants, fs.constants, and crypto.constants
that are specific to the modules for which they are relevant. The
next step is to document those within the specific modules.
PR-URL: https://github.com/nodejs/node/pull/6534
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com >
2016-05-17 11:05:18 -07:00
Jeremiah Senkpiel
52bae222a3
test: abstract skip functionality to common
...
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js
PR-URL: https://github.com/nodejs/node/pull/6697
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
2016-05-12 16:43:35 -04:00
Rich Trott
a56da51a38
benchmark,test,lib: remove extra spaces
...
In preparation for stricter linting, remove extra spaces.
PR-URL: https://github.com/nodejs/node/pull/6645
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-05-11 23:18:16 -07:00
Fedor Indutny
165b33fce2
https: evict cached sessions on error
...
Instead of using the same session over and over, evict it when the
socket emits error. This could be used as a mitigation of #3692 , until
OpenSSL fix will be merged/released.
See: https://github.com/nodejs/node/issues/3692
PR-URL: https://github.com/nodejs/node/pull/4982
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp >
2016-02-01 21:52:04 -05:00
Brian White