Antoine du Hamel
1af3599b7e
tools: filter release keys to reduce interactivity
...
PR-URL: https://github.com/nodejs/node/pull/55950
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2025-01-05 12:57:30 -05:00
Michaël Zasso
8c670496da
build: use rclone instead of aws CLI
...
Use rclone to upload assets to Cloudflare as it is more reliable.
Refs: https://github.com/nodejs/build/issues/3508
PR-URL: https://github.com/nodejs/node/pull/55617
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-11-27 11:03:28 -05:00
Richard Lau
2a62d6ca57
build, tools: drop leading / from r2dir
...
The script is commented as removing `/home/dist/` part but the `cut`
command is off by one and end up including the `/` character (so that
the resulting string starts with `/`). When this is substituted into
`s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with
`//` (one from the template and one from the `r2dir`) which appears
to cause Cloudflare to create an extra top level `/` directory in the
bucket.
PR-URL: https://github.com/nodejs/node/pull/53951
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-08-05 11:15:42 -03:00
Michaël Zasso
9c7b009f47
build,tools: simplify upload of shasum signatures
...
Use the same prompt for uploads to the web host and Cloudflare R2.
PR-URL: https://github.com/nodejs/node/pull/53892
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-28 09:51:32 +02:00
flakey5 and Michaël Zasso
18c530f8f7
build, tools: copy release assets to staging R2 bucket once built
...
Co-authored-by: Michaël Zasso <targos@protonmail.com >
PR-URL: https://github.com/nodejs/node/pull/51394
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2024-05-08 07:12:43 +02:00
Ruy Adorno
361d34c514
tools: add release host var to promotion script
...
Adds a `NODEJS_RELEASE_HOST` environment variable that enable releasers
to provide a custom proxy host to connect to when performing the
promotion steps of a given release.
Signed-off-by: Ruy Adorno <ruyadorno@google.com >
PR-URL: https://github.com/nodejs/node/pull/45913
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2023-01-01 16:29:42 +00:00
Antoine du Hamel
6c25870073
tools: fix release script sign function
...
PR-URL: https://github.com/nodejs/node/pull/36556
Refs: https://github.com/nodejs/node/pull/36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2020-12-21 14:47:22 +01:00
Antoine du Hamel
f28715d95d
tools: fix release script
...
PR-URL: https://github.com/nodejs/node/pull/36540
Refs: https://github.com/nodejs/node/pull/36123
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-12-17 16:03:48 +00:00
Michael Dawson
72b07e4fcf
doc: update terminology
...
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/36475
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2020-12-10 16:45:39 -05:00
Antoine du Hamel
1729ba7578
tools: remove bashisms from release script
...
PR-URL: https://github.com/nodejs/node/pull/36123
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-12-04 23:55:19 +01:00
Rod Vagg
625a81dea3
tools: ensure consistent perms of signed release files
...
Fixes: https://github.com/nodejs/build/issues/1904
PR-URL: https://github.com/nodejs/node/pull/29350
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-01-11 18:53:43 -08:00
Rod Vagg
f34ca9f783
tools: only sign release if promotion successful
...
Ref: https://github.com/nodejs/build/pull/1596
PR-URL: https://github.com/nodejs/node/pull/24669
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2018-11-30 21:23:01 -08:00
Rod Vagg
84c2157a60
tools: check for git tag before promoting release
...
PR-URL: https://github.com/nodejs/node/pull/24670
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2018-11-30 21:22:04 -08:00
Ruslan Bekenev
237a42dd93
tools: add custom private key option
...
Add -i option for release.sh that allows users to specify
non-default private key for ssh and scp commands.
Change argument parsing to getopts.
PR-URL: https://github.com/nodejs/node/pull/14401
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
2017-08-27 11:03:50 -03:00
Myles Borins
b7d143842c
tools: be explicit about including key-id
...
gpg 2.1 no longer includes the key-id by default which breaks
the release script. This makes sure we are explicit about it.
PR-URL: https://github.com/nodejs/node/pull/13309
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2017-06-01 16:07:18 -07:00
Myles Borins
b315e2455e
tools: use long format for gpg fingerprint
...
Git has been using my Long format fingerprint in the tagging messages,
this has been causing the release script to fail on my keys.
It would also be wise to be using the long format on keys based on some
attacks that hack been found in the wild around short keys.
PR-URL: https://github.com/nodejs/node/pull/9258
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
2016-11-07 10:34:10 -05:00
Evan Lucas
6845d6e318
tools: fix release script on macOS 10.12
...
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.
Fixes: https://github.com/nodejs/node/issues/8822
PR-URL: https://github.com/nodejs/node/pull/8824
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
2016-10-20 09:57:43 -07:00
Rod Vagg
64b9b39f07
tools: check tag is on github before release
...
PR-URL: https://github.com/nodejs/node/pull/9142
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-10-19 02:14:27 +11:00
Rod Vagg
df163c74e2
tools: make detached SHASUM .sig file for releases
...
PR-URL: https://github.com/nodejs/node/pull/9071
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2016-10-19 02:13:33 +11:00
Rod Vagg
e2e0c810a2
tools: explicitly set digest algo for SHASUM to 256
2016-10-19 02:13:33 +11:00
Myles Borins
321162df71
tools: add support for subkeys in release tools
...
Replace grep with awk to add support for subkeys
PR-URL: https://github.com/nodejs/node/pull/4807
Reviewed-By: Rod Vagg <rod@vagg.org >
2016-01-26 09:05:33 -08:00
Rod Vagg
cad0397b9a
tools: update release.sh to work with new website
...
now need to specify "nodejs" or "iojs", also remove .gpg file
PR-URL: https://github.com/nodejs/node/pull/2623
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu >
2015-09-01 08:47:59 -04:00
cjihrig
a69ab27ab4
node: rename from io.js to node
...
This commit replaces instances of io.js with Node.js, based on the
recent convergence. There are some remaining instances of io.js,
related to build and the installer.
Fixes: https://github.com/nodejs/node/issues/2361
PR-URL: https://github.com/nodejs/node/pull/2367
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: João Reis <reis@janeasystems.com >
2015-08-23 17:59:43 -04:00
Rod Vagg
df48fafa92
tools: add release tool and docs, remove old tools
...
Also added binary download documentation to the README.md and
GPG release key fingerprint for @rvagg.
PR-URL: https://github.com/iojs/io.js/pull/681
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Fedor Indutny <fedor@indutny.com >
2015-02-04 09:02:15 +11:00