BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
37,769 Commits 266 Branches 972 Tags
da416697fa0189134dbfe3e962decf79dde4f8e2
Commit Graph
296 Commits
Author SHA1 Message Date
Gabriela Gutierrez de696d70ef tools: add GitHub token permissions to label flaky-test issues 
Signed-off-by: Gabriela Gutierrez <gabigutierrez@google.com>
PR-URL: https://github.com/nodejs/node/pull/45308
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-12-04 00:17:54 +00:00
Filip Skokan 3b1f3891fc tools: have test-asan use ubuntu-20.04 
PR-URL: https://github.com/nodejs/node/pull/45581
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-22 17:57:36 +00:00
Facundo Tuesca 59bb198161 tools: add automation for updating libuv dependency 
Add a Github Action that checks for new versions of the `libuv` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45362
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-21 18:18:35 +00:00
Antoine du Hamel f2ee81839a tools: include current release in the list of released versions 
PR-URL: https://github.com/nodejs/node/pull/45463
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-11-14 22:58:58 +00:00
Moshe Atlow 119559a361 tools: do not run CQ on non-fast-tracked PRs open for less than 2 days 
PR-URL: https://github.com/nodejs/node/pull/45407
Fixes: https://github.com/nodejs/node/issues/45405
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-11-12 16:22:02 +00:00
Rich Trott e9a9e1ea5b tools: dynamically determine parallelism on GitHub Actions macOS 
Refs: https://github.com/nodejs/node/pull/45340#discussion_r1014859250
PR-URL: https://github.com/nodejs/node/pull/45350
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-11-10 17:04:00 +00:00
Darshan Sen d55a7c3435 test: add a test to ensure the correctness of timezone upgrades 
Currently, there's no way to know if a timezone upgrade PR is correct
without building and testing the change locally. This change provides a
solution for that.

Tested in https://github.com/RaisinTen/node/pull/4.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45299
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-10 13:08:30 +00:00
Facundo Tuesca f313b39d8f tools: add automation for updating acorn dependency 
Add a Github Action that checks for new versions of the `acorn` and
`acorn-walk` dependencies, and creates PRs to update them if newer
versions than the ones present in the repo are found.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45357
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2022-11-10 09:27:45 +00:00
Rich Trott f9fab41140 tools: increase macOS cores to 3 on GitHub CI 
In efbec85f30, we reduced the cores to 2
based on GitHub documentation. The documentation now says that there are
3 cores.

Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
PR-URL: https://github.com/nodejs/node/pull/45340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-11-06 19:56:25 +00:00
Facundo Tuesca 1f517130dd tools: add automation for updating base64 dependency 
Add a Github Action that checks for new versions of the `base64` C
library, and creates a PR to update it if a newer version than the one
present in the repo is found.

Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45300
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-11-06 02:17:03 +00:00
Moshe Atlow 77c0448ede meta: remove dont-land-on-v12 auto labeling 
PR-URL: https://github.com/nodejs/node/pull/45233
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-10-30 19:38:26 +00:00
Luigi Pinca cfd4c43a1e tools: use Python 3.11 in GitHub Actions workflows 
PR-URL: https://github.com/nodejs/node/pull/45191
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2022-10-28 18:35:50 +00:00
Jiawen Geng b2a6083980 build: workaround for node-core-utils 
PR-URL: https://github.com/nodejs/node/pull/45199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2022-10-28 01:12:07 +00:00
Yagiz Nizipli 3faa6e2c11 tools: update actions/setup-python to v4 
PR-URL: https://github.com/nodejs/node/pull/45178
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-10-27 20:08:57 +00:00
Richard Lau 5e2aeae032 build: add GitHub token to auto-start-ci workflow 
Recent changes to node-core-utils attempt to read pull request labels
when deciding whether or not to start a V8 CI. This requires a valid
GitHub token with appropriate permissions to be set for node-core-utils.

Refs: https://github.com/nodejs/node-core-utils/pull/652
PR-URL: https://github.com/nodejs/node/pull/45185
Fixes: https://github.com/nodejs/node/issues/45163
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-10-26 05:51:45 +00:00
Antoine du Hamel 9f8f311084 tools: fix create-or-update-pull-request-action hash on GHA 
Refs: https://github.com/nodejs/node/pull/45022#issuecomment-1290397901
PR-URL: https://github.com/nodejs/node/pull/45166
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2022-10-25 12:17:17 +00:00
Luigi Pinca ef1771183e tools: update gr2m/create-or-update-pull-request-action 
Update gr2m/create-or-update-pull-request-action to version 1.9.1.

PR-URL: https://github.com/nodejs/node/pull/45022
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-10-19 06:25:07 +00:00
Luigi Pinca 7ed44db558 tools: do not use the set-output command in workflows 
The `set-output` command is deprecated. Use the `GITHUB_OUTPUT`
environment file.

Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PR-URL: https://github.com/nodejs/node/pull/45024
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-19 06:24:58 +00:00
Darshan Sen 1a8f8ba6c6 build: add version info to timezone update PR 
Refs: https://github.com/nodejs/node/pull/44950#issuecomment-1275073089
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45021
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-18 07:09:46 +00:00
Moshe Atlow e5c807e115 meta: label test.js and test.md with test_runner label 
PR-URL: https://github.com/nodejs/node/pull/44863
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-02 11:19:20 +00:00
Alex 629d2bfca0 build: update timezone-update.yml 
Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com>

PR-URL: https://github.com/nodejs/node/pull/44717
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 11:22:04 -07:00
Lenvin Gonsalves 85b46e1cab tools: add timezone update workflow 
Fixes: https://github.com/nodejs/node/issues/43134
PR-URL: https://github.com/nodejs/node/pull/43988
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
 2022-09-16 00:03:40 +02:00
Shrujal Shah e039549d1f meta: update test_runner in label-pr-config 
PR-URL: https://github.com/nodejs/node/pull/44615
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2022-09-15 08:06:58 +00:00
Tobias Nießen ad41c919df src: remove v8abbr.h 
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only
used for dtrace, which has been removed.

Refs: https://github.com/nodejs/node/pull/43652
PR-URL: https://github.com/nodejs/node/pull/44402
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-08-30 12:57:22 +00:00
Daeyeon Jeong 5c923a4b06 meta: update web streams in label-pr-config 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: https://github.com/nodejs/node/pull/44235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-08-17 18:36:17 +00:00
Joyee Cheung 472edc775d src: disambiguate terms used to refer to builtins and addons 
The term "native module" dates back to some of the oldest code
in the code base. Within the context of Node.js core it usually
refers to modules that are native to Node.js (e.g. fs, http),
but it can cause confusion for people who don't work on this
part of the code base, as "native module" can also refer to
native addons - which is even the case in some of the API
docs and error messages.

This patch tries to make the usage of these terms more consistent.
Now within the context of Node.js core:

- JavaScript scripts that are built-in to Node.js are now referred
  to as "built-in(s)". If they are available as modules,
  they can also be referred to as "built-in module(s)".
- Dynamically-linked shared objects that are loaded into
  the Node.js processes are referred to as "addons".

We will try to avoid using the term "native modules" because it could
be ambiguous.

Changes in this patch:

File names:
- node_native_module.h -> node_builtins.h,
- node_native_module.cc -> node_builtins.cc

C++ binding names:
- `native_module` -> `builtins`

`node::Environment`:
- `native_modules_without_cache` -> `builtins_without_cache`
- `native_modules_with_cache` -> `builtins_with_cache`
- `native_modules_in_snapshot` -> `builtins_in_cache`
- `native_module_require` -> `builtin_module_require`

`node::EnvSerializeInfo`:
- `native_modules` -> `builtins

`node::native_module::NativeModuleLoader`:
- `native_module` namespace -> `builtins` namespace
- `NativeModuleLoader` -> `BuiltinLoader`
- `NativeModuleRecordMap` -> `BuiltinSourceMap`
- `NativeModuleCacheMap` -> `BuiltinCodeCacheMap`
- `ModuleIds` -> `BuiltinIds`
- `ModuleCategories` -> `BuiltinCategories`
- `LoadBuiltinModuleSource` -> `LoadBuiltinSource`

`loader.js`:
- `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in
  `process.moduleLoadList` is kept for compatibility)

And other clarifications in the documentation and comments.

PR-URL: https://github.com/nodejs/node/pull/44135
Fixes: https://github.com/nodejs/node/issues/44036
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2022-08-09 01:36:49 +08:00
Rafael Gonzaga ef33e93101 build: add workflow to label flaky-test platform 
This workflow adds platform labels on `flaky-test` issues to make it
easier and more reliable for someone to use labels to (for example)
find all flaky tests on SmartOS or all flaky tests on FreeBSD.

PR-URL: https://github.com/nodejs/node/pull/44042
Fixes: https://github.com/nodejs/node/issues/43854
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-08-07 22:34:03 +00:00
Chengzhong Wu 6b055f3857 meta: add codeowner for src/node_snapshot* 
PR-URL: https://github.com/nodejs/node/pull/44113
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-08-03 17:01:53 +00:00
Rich Trott 32ffa5d097 build: allow test-internet on forks if not scheduled 
Refs: https://github.com/nodejs/node/pull/44054#issuecomment-1200246681
PR-URL: https://github.com/nodejs/node/pull/44073
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-08-02 11:21:40 +00:00
Rich Trott 07d7e1b0c1 build: skip test-internet run on forks 
Do not run test-internet scheduled GitHub Action on forks.

PR-URL: https://github.com/nodejs/node/pull/44054
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-07-31 18:16:01 +01:00
NicoNekoru 5c50b2053e meta: shorten PowerShell snippet for bug-report template 
PR-URL: https://github.com/nodejs/node/pull/44011
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
 2022-07-30 13:51:21 +08:00
Antoine du Hamel 2e4bcfcb96 tools: add more options to track flaky tests 
Refs: https://github.com/nodejs/node/pull/43929#issuecomment-1193104729

PR-URL: https://github.com/nodejs/node/pull/43954
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
 2022-07-25 13:01:41 +01:00
Daeyeon Jeong 72fd06f7f0 meta: update node-api in label-pr-config 
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43794
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-07-24 13:12:07 +01:00
Rafael Gonzaga 6e740f2638 meta: use platform dropdown on flaky template 
PR-URL: https://github.com/nodejs/node/pull/43855
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2022-07-18 11:03:35 +01:00
Matteo Collina 40515e6259 meta: enable blank issues 
Signed-off-by: Matteo Collina <hello@matteocollina.com>

PR-URL: https://github.com/nodejs/node/pull/43775
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-07-14 11:37:41 +02:00
Varun Sharma d6988ec9be build: add GitHub token permissions for workflows 
Signed-off-by: Varun Sharma <varunsh@stepsecurity.io>

PR-URL: https://github.com/nodejs/node/pull/43743
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-07-12 22:50:46 +01:00
Feng Yu 6f924ac691 build: update main branch name in GH workflow 
PR-URL: https://github.com/nodejs/node/pull/43481
Refs: https://github.com/nodejs/node/issues/33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-06-23 05:57:51 +01:00
Antoine du Hamel c470386255 tools: fix create-or-update-pull-request-action hash on GHA 
PR-URL: https://github.com/nodejs/node/pull/43378
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-06-11 14:59:37 +01:00
Livia Medeiros e227e5285d tools: fix find-inactive actions 
PR-URL: https://github.com/nodejs/node/pull/43377
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-11 10:27:04 +01:00
Antoine du Hamel c7c8d8683a tools: use hashes instead of tags for external actions (#43284) 
Using tags is a security risk, as they can be updated to point to
anything else.

Refs: https://github.com/nodejs/corepack/pull/117#discussion_r886913592

PR-URL: https://github.com/nodejs/node/pull/43284
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-06-05 21:45:18 +02:00
Antoine du Hamel ef16c7b7c5 tools: update codecov/codecov-action version 
Refs: https://github.com/codecov/codecov-action/releases

PR-URL: https://github.com/nodejs/node/pull/43297
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2022-06-02 15:17:43 +02:00
Feng Yu b4398df2e5 tools: refactor build-addons.js to ESM 
PR-URL: https://github.com/nodejs/node/pull/43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-22 14:28:41 +01:00
Feng Yu 5cb257958e tools: refactor update-authors.js to ESM 
PR-URL: https://github.com/nodejs/node/pull/43098
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-21 16:31:31 +01:00
Joyee Cheung fbe1478077 bootstrap: include code cache in the embedded snapshot 
Since V8 code cache encodes indices to the read-only space
it is safer to make sure that the code cache is generated in the
same heap used to generate the embdded snapshot. This patch
merges the code cache builder into the snapshot builder and
makes the code cache part of node::SnapshotData that is
deserialized into the native module loader during bootstrap.

PR-URL: https://github.com/nodejs/node/pull/43023
Fixes: https://github.com/nodejs/node/issues/31074
Refs: https://github.com/nodejs/node/issues/35711
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2022-05-17 20:38:11 +08:00
Richard Lau 347000ccf8 build: set ASAN workaround 
PR-URL: https://github.com/nodejs/node/pull/43085
Refs: https://github.com/google/sanitizers/issues/1322
Refs: https://github.com/nodejs/node/issues/43082
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-05-14 22:05:55 -07:00
Jiawen Geng 8c800d7102 build: disable windows-2022 temporarily 
PR-URL: https://github.com/nodejs/node/pull/43093
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-05-14 08:47:47 -07:00
Feng Yu be1ca70515 tools: refactor lint-sh.js to esm module 
PR-URL: https://github.com/nodejs/node/pull/42942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-05-08 16:08:10 +01:00
Darshan Sen 61fefe1959 build: fix format-cpp 
According to the logs in
https://github.com/nodejs/node/pull/42681#issuecomment-1100856089,
`make format-cpp` exits with an NZEC. This change intentionally ignores
the error code because it is irrelevant. We already check if the
formatter produced a diff in the next line.

Refs: https://github.com/nodejs/node/pull/42681#issuecomment-1100856089
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42764
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-04-20 16:00:22 +01:00
Darshan Sen fc326d674d build: improve the format-cpp error message 
This change specifies the target branch name instead of leaving that to
the committer to fill in.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42765
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-04-20 00:26:50 +01:00
Darshan Sen 96673bcb96 build: run clang-format on CI 
We already include the tool inside tools/clang-format, so we should
start using it on CI. This attempts to run the linter only on the
commits present in an opened PR.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42681
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-13 18:22:00 +01:00