BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
37,769 Commits 266 Branches 972 Tags
da416697fa0189134dbfe3e962decf79dde4f8e2
Commit Graph
809 Commits
Author SHA1 Message Date
Debadree Chatterjee 79a977ae31 watch: add CLI flag to preserve output 
Fixes: https://github.com/nodejs/node/issues/45713
PR-URL: https://github.com/nodejs/node/pull/45717
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2022-12-11 23:23:11 +01:00
Stefan Stojanovic 89502401bf test: fix test-watch-mode 
Refs: https://github.com/nodejs/node/issues/44898
PR-URL: https://github.com/nodejs/node/pull/45585
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-12-01 20:10:46 +00:00
Stefan Stojanovic 2cad517854 test: fix test-watch-mode-inspect 
Refs: https://github.com/nodejs/node/issues/44898
PR-URL: https://github.com/nodejs/node/pull/45586
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-12-01 18:33:00 +00:00
Moshe Atlow ce16bf553f watch: watch for missing dependencies 
PR-URL: https://github.com/nodejs/node/pull/45348
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
 2022-11-13 15:13:26 +00:00
Joyee Cheung b872d30d19 lib: add options to the heap snapshot APIs 
Support configuration of the HeapSnapshotMode and NumericsMode
fields inf HeapSnapshotOptions in the JS APIs for heap snapshots.

PR-URL: https://github.com/nodejs/node/pull/44989
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2022-11-08 16:19:54 +01:00
Luke Karrys 590cf569fe test: convert test-debugger-pid to async/await 
PR-URL: https://github.com/nodejs/node/pull/45179
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-11-01 05:45:47 +00:00
Yagiz Nizipli 17ae2ab750 fs: add recursive watch to linux 
PR-URL: https://github.com/nodejs/node/pull/45098
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-31 23:15:45 +00:00
Moshe Atlow 47b63f52a8 test: watch mode inspect restart repeatedly 
PR-URL: https://github.com/nodejs/node/pull/45060
Fixes: https://github.com/nodejs/node/issues/44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-22 18:02:09 +00:00
Pierrick Bouvier 806ea92e70 test: mark test-watch-mode* as flaky on all platforms 
This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: https://github.com/nodejs/node/pull/45049
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-20 09:06:09 +00:00
Rich Trott 6059cbedbd test: remove unnecessary noop function args to mustCall() 
PR-URL: https://github.com/nodejs/node/pull/45027
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-10-18 12:13:41 +00:00
Madhuri fe520f80c9 test: refactor promises to async/await 
PR-URL: https://github.com/nodejs/node/pull/44980
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2022-10-14 17:50:32 +00:00
Moshe Atlow 0298b7f8a6 test: debug watch mode inspect 
PR-URL: https://github.com/nodejs/node/pull/44861
Refs: https://github.com/nodejs/node/issues/44805
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-10 16:46:34 +00:00
legendecas 364c0e196c perf_hooks: fix webperf idlharness 
1. Enforce receiver checks on IDL interfaces.
2. Avoid prototype manipulation on constructing IDL interfaces with
   `ReflectConstruct`.
3. `defineReplaceableAttribute` should create IDL getter/setter.
4. Corrected `PerformanceResourceTiming` to inherit the public interface
   `PerformanceEntry` instead of the internal interface
   `InternalPerformanceResourceTiming`.
5. `detail` is not a specified attribute on `PerfomanceEntry`. Node.js
   specific extensions are moved to a subclass of `PerformanceEntry` as
   `PerformanceNodeEntry`.

PR-URL: https://github.com/nodejs/node/pull/44483
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-04 00:55:58 +08:00
Richard Lau 0ee6643d36 test: check server status in test-tls-psk-client 
Add assertions to sequential/test-tls-psk-client to check if the
spawned OpenSSL server has exited in any way except for the expected
termination by the cleanUp() function. The added assertions will
prevent the test from spinning forever trying to connect to the
non-existent server in the case that the spawned process has exited.
Include stderr and stdout in the assertion failure message to aid
debugging.

PR-URL: https://github.com/nodejs/node/pull/44824
Refs: https://github.com/nodejs/node/issues/44821
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-10-02 13:10:37 +00:00
pete3249 bf0c312893 test: use async/await in test-debugger-exceptions 
PR-URL: https://github.com/nodejs/node/pull/44690
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-30 02:46:02 +00:00
Chandana e236af8d54 test: use async/await in test-debugger-help 
PR-URL: https://github.com/nodejs/node/pull/44686
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-29 23:29:11 +00:00
mmeenapriya 29c35ea823 test: update test-debugger-scripts to use await/async 
PR-URL: https://github.com/nodejs/node/pull/44692
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-29 21:32:34 +00:00
Monu-Chaudhary 6b9253a81a test: use async/await in test-debugger-random-port-with-inspect-port 
PR-URL: https://github.com/nodejs/node/pull/44695
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-29 12:53:11 -07:00
Brinda Ashar 865a5784fd test: use async/await in test-debugger-heap-profiler 
PR-URL: https://github.com/nodejs/node/pull/44693
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-29 12:50:11 -07:00
samyuktaprabhu 2615d7653c test: use async/await in test-debugger-auto-resume 
PR-URL: https://github.com/nodejs/node/pull/44675
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-29 07:22:09 -07:00
Rathi N Das 746d525837 test: migrated from Promise chains to Async/Await 
PR-URL: https://github.com/nodejs/node/pull/44674
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2022-09-29 09:15:32 +00:00
Juliet Zhang 19503e7468 test: change promises to async/await in test-debugger-backtrace.js 
PR-URL: https://github.com/nodejs/node/pull/44677
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-09-29 09:15:22 +00:00
Hope Olaidé 6355cd8542 test: use async/await in test-debugger-sb-before-load 
PR-URL: https://github.com/nodejs/node/pull/44697
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-09-29 09:15:10 +00:00
Divya Mohan 1438557062 test: refactor to async/await 
PR-URL: https://github.com/nodejs/node/pull/44694
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-28 16:18:53 +00:00
Priya Shastri 11b8b99ce4 test: modify test-debugger-custom-port.js to use async-await 
PR-URL: https://github.com/nodejs/node/pull/44680
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 19:35:41 +00:00
Archana Kamath 1d2f1eceef test: update test-debugger-breakpoint-exists.js to use async/await 
PR-URL: https://github.com/nodejs/node/pull/44682
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 16:52:39 +00:00
poorvitusam 0098af1e37 test: use async/await in test-debugger-preserve-breaks 
PR-URL: https://github.com/nodejs/node/pull/44696
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 16:52:30 +00:00
surbhirjain b376047236 test: use async/await in test-debugger-profile 
PR-URL: https://github.com/nodejs/node/pull/44684
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 16:32:41 +00:00
Ankita Khiratkar 97959769fd test: change the promises to async/await in test-debugger-exec-scope.js 
PR-URL: https://github.com/nodejs/node/pull/44685
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-27 06:26:58 +00:00
Madhulika Sharma 1e6153c090 test: change promises to async/await 
PR-URL: https://github.com/nodejs/node/pull/44683
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-26 06:19:11 +00:00
Nupur Chauhan cf4a334050 test: use async/await in test-debugger-invalid-args 
PR-URL: https://github.com/nodejs/node/pull/44678
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-25 23:15:27 +00:00
Meghana Ramesh d8493c4f97 test: update test-debugger-low-level to use await/async 
PR-URL: https://github.com/nodejs/node/pull/44688
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-25 17:00:58 +00:00
Moshe Atlow dc4398c9cf test: fix watch mode test flake 
PR-URL: https://github.com/nodejs/node/pull/44739
Fixes: https://github.com/nodejs/node/issues/44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-09-25 11:07:56 +00:00
“Pooja 269aa6ebba test: change promise to async/await in debugger-watcher 
PR-URL: https://github.com/nodejs/node/pull/44687
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-09-23 06:42:13 -07:00
Moshe Atlow 96f072231d test: deflake watch mode tests 
PR-URL: https://github.com/nodejs/node/pull/44621
Fixes: https://github.com/nodejs/node/issues/44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-09-20 10:37:42 +03:00
Moshe Atlow a165193c5c test_runner: support using --inspect with --test 
PR-URL: https://github.com/nodejs/node/pull/44520
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-09-10 17:01:42 +00:00
Moshe Atlow 9c60cd1d60 test: split watch mode inspector tests to sequential 
PR-URL: https://github.com/nodejs/node/pull/44551
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
 2022-09-09 11:18:02 +00:00
Joyee Cheung 7327c5ed81 test: split heap prof tests 
The original heap prof tests can take too long to complete on
azure Windows machines, resulting in timeouts. Split them into
smaller tests and move them into the parallel directory to
speed up the execution.

PR-URL: https://github.com/nodejs/node/pull/44388
Refs: https://github.com/nodejs/reliability/issues/356
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-08-31 23:38:45 +08:00
Joyee Cheung bb4dff783d test: raise sleep times in child process tests 
sequential/test-child-process-execsync and
parallel/test-child-process-spawnsync-timeout are both flaky
on azure Windows machines, where it may take longer for Node.js
to launch and receive output from child processes. These tests
work by spawning a child processes that is supposed to sleep
for a long time, but the option is configured so that Node.js
would terminate them early when a shorter timeout is reached.
Then the tests assert that the time taken for the whole thing
is shorter than the specified sleep time (meaning the process
don't actually get to sleep for that long). To make the tests
less brittle on azure Windows, this patch raises the sleep
times in those tests on Windows platform, so that the overhead
can be taken into account there.

PR-URL: https://github.com/nodejs/node/pull/44375
Refs: https://github.com/nodejs/build/issues/3014
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
 2022-08-25 07:56:40 +00:00
MURAKAMI Masahiko 25d78de4f6 test: use mustSucceed instead of mustCall with assert.ifError 
PR-URL: https://github.com/nodejs/node/pull/44196
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-08-12 10:17:06 +02:00
Keyhan Vakil 3738b57102 test: move tests with many workers to sequential 
These tests spawn many workers, which may be CPU intensive causing
timeouts (see the referenced PR for more details). Let's move them
to sequential.

Refs: https://github.com/nodejs/node/pull/44090
PR-URL: https://github.com/nodejs/node/pull/44139
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
 2022-08-07 12:44:33 +00:00
Nick Sia a31d572f00 test: deflake gc-http-client tests by restricting number of requests 
sequential/test-gc-http-client tests were sometimes failing due to
a non-deterministic number of requests being created, causing the
test to fail on some systems with a "ECONNRESET" error caused by
too many concurrent connections

Fixes: https://github.com/nodejs/node/issues/43638
PR-URL: https://github.com/nodejs/node/pull/44146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-08-07 12:44:25 +00:00
Keyhan Vakil f045a13cc9 test: move test-vm-break-on-sigint to sequential 
This PR moves `test-vm-break-on-sigint.js` to sequential, following the
other PRs I have made to move CPU intensive tests into sequential. The
test has already been tuned to do less iterations in a previous PR.
However it is still causing ~7% of build failures. The timeouts seem
highly correlated with other tests which spawn a bunch of threads also
failing, see for example the [first Jenkins failure][] and the [last
Jenkins failure][].

[first Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45756/
[last Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45837/

Refs: https://github.com/nodejs/node/pull/44090
Refs: https://github.com/nodejs/node/pull/43981
Refs: https://github.com/nodejs/reliability/issues/337
PR-URL: https://github.com/nodejs/node/pull/44140
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
 2022-08-07 12:26:59 +00:00
Feng Yu fbcac58db7 test: remove test-gc-http-client-timeout from flaky list 
PR-URL: https://github.com/nodejs/node/pull/43971
Refs: https://github.com/nodejs/node/pull/43949
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-07-26 23:38:07 +01:00
legendecas c6ec630b3f test: mark test-gc-http-client-timeout as flaky on arm 
`sequential/test-gc-http-client-timeout` is failing on arm
frequently. Mark it as flaky to unblock PRs to land.

PR-URL: https://github.com/nodejs/node/pull/43754
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-07-11 21:41:50 +08:00
Kohei Ueno 887816d8f2 test: add test for profile command of node inspect 
PR-URL: https://github.com/nodejs/node/pull/43058
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2022-07-09 21:14:27 +01:00
Ouyang Yadong acd2a3210d net: remove redundant connecting assignment 
PR-URL: https://github.com/nodejs/node/pull/43710
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
 2022-07-09 17:10:16 +01:00
Paolo Insogna c753f27a3d http: fix failing test 
PR-URL: https://github.com/nodejs/node/pull/43641
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2022-07-02 17:10:53 +01:00
Paolo Insogna 4267b92604 http: use Keep-Alive by default in global agents 
PR-URL: https://github.com/nodejs/node/pull/43522
Fixes: https://github.com/nodejs/node/issues/37184
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-29 12:48:52 +02:00
Tobias Nießen 800cff1e24 doc,test: clarify timingSafeEqual semantics 
PR-URL: https://github.com/nodejs/node/pull/43228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-06-21 12:43:09 +01:00