BackPup/node
1
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00
Code Issues Packages Projects Releases Wiki Activity
23,749 Commits 266 Branches 972 Tags
dca0300a86eb8a24ea38faff2b4d27567ab54707
Commit Graph
9 Commits
Author SHA1 Message Date
Rich Trott c90b10d9f2 test: refactor test-repl-definecommand 
The test was writing to both REPL input and output but only checking
output. Sending output to both streams seems like it was an error.

PR-URL: https://github.com/nodejs/node/pull/17795
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-12-21 15:10:02 -08:00
Vse Mozhet Byt 8b76c3e60c test: reduce string concatenations 
PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-05-05 17:39:05 +03:00
Brian White 61ebfa8d1f tools: add unescaped regexp dot rule to linter 
PR-URL: https://github.com/nodejs/node/pull/11834
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2017-03-29 10:53:28 +02:00
Gibson Fahnestock 7a0e462f9f test: use eslint to fix var->const/let 
Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
 2017-01-11 11:43:52 +00:00
Roman Reiss 39fbb5adf5 repl: improve .help message 
- Added dots to printed commands.
- Use spaces instead of tabs so there's no misalignment on terminals
  with a tab size other than 4.
- Improved the help text for .editor and .help.
- Automatically indent command help based on the longest command.

PR-URL: https://github.com/nodejs/node/pull/8519
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
 2016-09-16 16:53:03 +02:00
Evan Lucas 76007079ec Revert "repl,util: insert carriage returns in output" 
This reverts commit fce4b981ea.

This was a breaking change and should have been marked semver-major.
The change that was made altered the output of util.format() and
util.inspect(). With how much those are used in the wild, this type of
change deserves more justification.

Fixes: https://github.com/nodejs/node/issues/8138
PR-URL: https://github.com/nodejs/node/pull/8143
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-08-19 11:48:52 -05:00
JungMinu fce4b981ea repl,util: insert carriage returns in output 
`\n` is not enough for Linux with some custom stream
add carriage returns to ensure that the output is displayed correctly
using `\r\n` should not be a problem, even on non-Windows platforms.

Fixes: https://github.com/nodejs/node/issues/7954
PR-URL: https://github.com/nodejs/node/pull/8028
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-08-13 23:03:30 +09:00
Michaël Zasso d1aabd6264 test: fix style issues after eslint update 
Replace var keyword with const or let.

PR-URL: https://github.com/nodejs/io.js/pull/2286
Reviewed-By: Roman Reiss <me@silverwind.io>
 2016-01-13 23:16:17 +01:00
Bryan English e5d97fd91a test: add test for repl.defineCommand() 
It also tests displayPrompt by checking for '> '.

PR-URL: https://github.com/nodejs/node/pull/3908
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2015-12-01 15:27:12 -05:00