James M Snell
c77063eec2
test: implement low-risk test optimizations
...
Reviewing the performance of http tests in the smartos
CI runs revealed that a handful of HTTP related tests
are running way longer than they should, with some hitting
upwards of 66 seconds!
- Ten HTTP/HTTPS tests now close connections
deterministically instead of waiting 66 seconds.
- Two HTTP/2 tests use an explicit 64KiB stream window
and 3MB payload, while restoring timeout assertions.
- Estimated SmartOS CI saving: about 4.5 minutes at -j4.
Signed-off-by: James M Snell <jasnell@gmail.com >
Assisted-by: Opencode
PR-URL: https://github.com/nodejs/node/pull/65926
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
2026-09-12 10:03:06 +02:00
Ben Noordhuis and treysis
1b2749ecbe
dns: default to verbatim=true in dns.lookup()
...
Switch the default from `ipv4first` to `verbatim` (return them exactly
as the resolver sent them to us).
PR-URL: https://github.com/nodejs/node/pull/39987
Fixes: https://github.com/nodejs/node/issues/31566
Refs: https://github.com/nodejs/node/issues/6307
Refs: https://github.com/nodejs/node/pull/20710
Refs: https://github.com/nodejs/node/pull/38099
Co-authored-by: treysis <treysis@gmx.net >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-09-12 21:05:35 +02:00
Rich Trott
4a40ea6894
test: refactor test-https-connect-localport
...
Use arrow functions for callbacks. Replace uses of `this` with explicit
variables. Add a trailing comma in a multiline object literal
declaration.
PR-URL: https://github.com/nodejs/node/pull/26881
Fixes: https://github.com/https://github.com/nodejs/node/issues/26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2019-03-24 07:56:25 -07:00
Rich Trott
f5969f08a0
test: replace localhost IP with 'localhost' for TLS conformity
...
test-https-connect-localport currently causes a runtime deprecation
warning: "[DEP0123] DeprecationWarning: Setting the TLS ServerName
to an IP address is not permitted by RFC 6066. This will be ignored
in a future version."
Change IP usage to the string 'localhost' instead.
PR-URL: https://github.com/nodejs/node/pull/26881
Fixes: https://github.com/https://github.com/nodejs/node/issues/26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2019-03-24 07:56:20 -07:00
Rich Trott
229759f961
test: use common.PORT instead of hardcoded number
...
In sequential/test-https-connect-localport, replace 34567 with
common.PORT.
PR-URL: https://github.com/nodejs/node/pull/26881
Fixes: https://github.com/https://github.com/nodejs/node/issues/26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2019-03-24 07:56:12 -07:00
Rich Trott
0f7e24a0c3
test: move test-https-connect-localport to sequential
...
test-https-connect-localport uses a hard-coded port number. Therefore
the test cannot be in the parallel directory because it will sometimes
conflict with other tests that run at the same time and request that the
OS provide an available port.
Fixes: https://github.com/nodejs/node/issues/26862
PR-URL: https://github.com/nodejs/node/pull/26881
Fixes: https://github.com/https://github.com/nodejs/node/issues/26862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2019-03-24 07:56:03 -07:00
James M Snell