Anna Henningsen
e7b99e027b
worker: add stack size resource limit option
...
Add `stackSizeMb` to the `resourceLimit` option group.
Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820
PR-URL: https://github.com/nodejs/node/pull/33085
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2020-04-29 05:13:42 +02:00
Ranjan Purbey
393f6914df
doc: improve worker pool example
...
In the worker pool example, the 'kWorkerFreedEvent' should be emitted
in case of error as well. After adding new worker in the error handler,
the pending tasks should be notified of an available worker.
PR-URL: https://github.com/nodejs/node/pull/33082
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2020-04-29 05:10:22 +02:00
Juan José Arboleda
ed87433970
doc: fix markdown parsing on doc/api/os.md
...
PR-URL: https://github.com/nodejs/node/pull/33067
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-04-29 03:53:28 +02:00
rickyes
f68428b695
console: support console constructor groupIndentation option
...
PR-URL: https://github.com/nodejs/node/pull/32964
Fixes: https://github.com/nodejs/node/issues/32947
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-29 03:51:03 +02:00
Alba Mendez
ee9280a02a
http2,doc: minor fixes
...
Some small fixes on HTTP/2 and its documentation:
- Add a note that, on server streams, it's not necessary
to start data flow.
- Set EOF flag if we have marked all data for sending:
there's no need to wait until the queue is
actually empty (and send a separate, empty DATA).
(Note that, even with this change, a separate DATA
frame will always be sent, because the streams
layer waits until data has been flushed before
dispatching EOF)
PR-URL: https://github.com/nodejs/node/pull/28044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-28 19:20:19 +02:00
cjihrig
6ca6db105d
wasi: update start() behavior to match spec
...
_start() and _initialize() shouldn't be called from the same
function, as they have different behavior. Furthermore, Node
should throw if both are provided. This commit updates the
implementation, docs, and tests accordingly.
PR-URL: https://github.com/nodejs/node/pull/33073
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gus Caplan <me@gus.host >
2020-04-28 13:04:43 -04:00
cjihrig
4791ea09bd
wasi: rename __wasi_unstable_reactor_start()
...
Upstream WASI has renamed __wasi_unstable_reactor_start() to
_initialize(). This commit updates Node's WASI implementation to
reflect that change.
PR-URL: https://github.com/nodejs/node/pull/33073
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gus Caplan <me@gus.host >
2020-04-28 13:04:43 -04:00
Michaël Zasso
165011ea98
2020-04-28, Version 12.16.3 'Erbium' (LTS)
...
Notable changes:
Dependencies:
* Updated OpenSSL to 1.1.1g.
https://github.com/nodejs/node/pull/32971
* Updated c-ares to 1.16.0.
https://github.com/nodejs/node/pull/32246
* Updated experimental uvwasi to 0.0.6.
https://github.com/nodejs/node/pull/32309
ESM (experimental):
* Additional warnings are no longer printed for modules that use
conditional exports or package name self resolution.
https://github.com/nodejs/node/pull/31845
PR-URL: https://github.com/nodejs/node/pull/33009
2020-04-28 15:24:52 +02:00
Anna Henningsen
9c7c876918
doc: fix LTS replaceme tags
...
When cherry-picking release commits for LTS releases into master,
the `REPLACEME` metadata can be taken over as well, to give users
a more accurate view of what is being released on which release line.
This addresses this problem for all previous LTS releases for which
this has not been done.
Fixes: https://github.com/nodejs/node/issues/33001
PR-URL: https://github.com/nodejs/node/pull/33041
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Shelley Vohr <codebytere@gmail.com >
2020-04-28 15:23:46 +02:00
Richard Lau
76ba9503a2
doc: assign missing deprecation code
...
Signed-off-by: Richard Lau <riclau@uk.ibm.com >
PR-URL: https://github.com/nodejs/node/pull/33109
Refs: https://github.com/nodejs/node/pull/32807
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com >
2020-04-28 00:50:59 +02:00
Liran Tal
6b2e3afee9
doc: improve WHATWG url constructor code example
...
Currently, the URL docs for the WHATWG URL spec support are
somewhat lacking in their code example of how to access the
new URL constructor that lives inside the core url package.
PR-URL: https://github.com/nodejs/node/pull/32782
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-28 00:47:49 +02:00
Robert Nagy
e5512acfa7
doc: document major finished changes in v14
...
Added description of semver-major changes to finished in v14.
PR-URL: https://github.com/nodejs/node/pull/33065
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-27 21:31:27 +02:00
Juan José Arboleda
75e4ccb192
doc: add documentation for transferList arg at worker threads
...
Ref: https://github.com/nodejs/node/pull/32278
PR-URL: https://github.com/nodejs/node/pull/32881
Refs: https://github.com/nodejs/node/pull/32278
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2020-04-27 19:27:55 +02:00
rickyes
58682d823a
tls: add highWaterMark option for connect
...
PR-URL: https://github.com/nodejs/node/pull/32786
Fixes: https://github.com/nodejs/node/issues/32781
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com >
2020-04-27 16:52:19 +03:00
Robert Nagy
5ee1e31e38
http: doc deprecate abort and improve docs
...
Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.
Refs: https://github.com/nodejs/node/issues/32225
PR-URL: https://github.com/nodejs/node/pull/32807
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-04-26 23:51:04 +02:00
Gus Caplan
74c393dd93
vm: add importModuleDynamically option to compileFunction
...
Fixes: https://github.com/nodejs/node/issues/31860
PR-URL: https://github.com/nodejs/node/pull/32985
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-04-25 09:49:53 -05:00
Eileen
ff622a2b2b
doc: updated directory entry information
...
Fixes: https://github.com/nodejs/node/issues/25595
subdirectory
updated def
PR-URL: https://github.com/nodejs/node/pull/32791
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-24 16:35:18 +02:00
Nick Schonning
7183d70273
doc: add angle brackets around implicit links
...
PR-URL: https://github.com/nodejs/node/pull/32676
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-04-23 21:48:17 -07:00
ConorDavenport
50d28d4b3a
assert: port common.mustCall() to assert
...
Fixes: https://github.com/nodejs/node/issues/31392
PR-URL: https://github.com/nodejs/node/pull/31982
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
2020-04-23 10:11:47 -07:00
Prosper Opara
01e158c600
doc: remove repeated word in modules.md
...
PR-URL: https://github.com/nodejs/node/pull/32931
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-23 19:22:28 +03:00
Guy Bedford
e767ed0558
module: exports not exported for null resolutions
...
PR-URL: https://github.com/nodejs/node/pull/32838
Reviewed-By: Jan Krems <jan.krems@gmail.com >
2020-04-22 15:48:44 -07:00
Beth Griggs
372c7cc3c2
2020-04-21, Version 14.0.0 (Current)
...
Deprecations:
- (SEMVER-MAJOR) crypto: move pbkdf2 without digest to EOL
(James M Snell) [#31166 ](https://github.com/nodejs/node/pull/31166 )
- (SEMVER-MAJOR) fs: deprecate closing FileHandle on garbage collection
(James M Snell) [#28396 ](https://github.com/nodejs/node/pull/28396 )
- (SEMVER-MAJOR) http: move OutboundMessage.prototype.flush to EOL
(James M Snell) [#31164 ](https://github.com/nodejs/node/pull/31164 )
- (SEMVER-MAJOR) lib: move GLOBAL and root aliases to EOL
(James M Snell) [#31167 ](https://github.com/nodejs/node/pull/31167 )
- (SEMVER-MAJOR) os: move tmpDir() to EOL
(James M Snell)[#31169 ](https://github.com/nodejs/node/pull/31169 )
- (SEMVER-MAJOR) src: remove deprecated wasm type check
(Clemens Backes) [#32116 ](https://github.com/nodejs/node/pull/32116 )
- (SEMVER-MAJOR) stream: move \_writableState.buffer to EOL
(James M Snell) [#31165 ](https://github.com/nodejs/node/pull/31165 )
- (SEMVER-MINOR) doc: deprecate process.mainModule
(Antoine du HAMEL) [#32232 ](https://github.com/nodejs/node/pull/32232 )
- (SEMVER-MINOR) doc: deprecate process.umask() with no arguments
(Colin Ihrig) [#32499 ](https://github.com/nodejs/node/pull/32499 )
ECMAScript Modules - Experimental Warning Removal:
- module: remove experimental modules warning
(Guy Bedford) [#31974 ](https://github.com/nodejs/node/pull/31974 )
In Node.js 13 we removed the need to include the --experimental-modules
flag, but when running EcmaScript Modules in Node.js, this would still
result in a warning ExperimentalWarning: The ESM module loader is
experimental.
As of Node.js 14 there is no longer this warning when using ESM in
Node.js. However, the ESM implementation in Node.js remains
experimental. As per our stability index: “The feature is not subject
to Semantic Versioning rules. Non-backward compatible changes or
removal may occur in any future release.” Users should be cautious when
using the feature in production environments.
Please keep in mind that the implementation of ESM in Node.js differs
from the developer experience you might be familiar with. Most
transpilation workflows support features such as optional file
extensions or JSON modules that the Node.js ESM implementation does not
support. It is highly likely that modules from transpiled environments
will require a certain degree of refactoring to work in Node.js. It is
worth mentioning that many of our design decisions were made with two
primary goals. Spec compliance and Web Compatibility. It is our belief
that the current implementation offers a future proof model to
authoring ESM modules that paves the path to Universal JavaScript.
Please read more in our documentation.
The ESM implementation in Node.js is still experimental but we do believe
that we are getting very close to being able to call ESM in Node.js
“stable”. Removing the warning is a huge step in that direction.
New V8 ArrayBuffer API:
* **src**: migrate to new V8 ArrayBuffer API
(Thang Tran) [#30782 ](https://github.com/nodejs/node/pull/30782 )
Multiple ArrayBuffers pointing to the same base address are no longer
allowed by V8. This may impact native addons.
Toolchain and Compiler Upgrades:
- (SEMVER-MAJOR) build: update macos deployment target to 10.13 for 14.x
(AshCripps)[#32454 ](https://github.com/nodejs/node/pull/32454 )
- (SEMVER-MAJOR) doc: update cross compiler machine for Linux armv7
(Richard Lau) [#32812 ](https://github.com/nodejs/node/pull/32812 )
- (SEMVER-MAJOR) doc: update Centos/RHEL releases use devtoolset-8
(Richard Lau) [#32812 ](https://github.com/nodejs/node/pull/32812 )
- (SEMVER-MAJOR) doc: remove SmartOS from official binaries
(Richard Lau) [#32812 ](https://github.com/nodejs/node/pull/32812 )
- (SEMVER-MAJOR) win: block running on EOL Windows versions
(João Reis) [#31954 ](https://github.com/nodejs/node/pull/31954 )
It is expected that there will be an ABI mismatch on ARM between the
Node.js binary and native addons. Native addons are only broken if they
interact with `std::shared_ptr`. This is expected to be fixed in a
later version of Node.js 14.
- [#30786 ](https://github.com/nodejs/node/issues/30786 )
Update to V8 8.1:
- (SEMVER-MAJOR) deps: update V8 to 8.1.307.20
(Matheus Marchini) [#32116 ](https://github.com/nodejs/node/pull/32116 )
Other Notable Changes:
- cli, report: move --report-on-fatalerror to stable
(Colin Ihrig) [#32496 ](https://github.com/nodejs/node/pull/32496 )
- deps: upgrade to libuv 1.37.0
(Colin Ihrig) [#32866 ](https://github.com/nodejs/node/pull/32866 )
- fs: add fs/promises alias module
(Gus Caplan) [#31553 ](https://github.com/nodejs/node/pull/31553 )
PR-URL: https://github.com/nodejs/node/pull/32181
2020-04-21 15:50:14 +01:00
William Armiros
4299e976ec
doc: corrected ERR_SOCKET_CANNOT_SEND message
...
PR-URL: https://github.com/nodejs/node/pull/32847
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2020-04-21 09:08:50 -05:00
karan singh virdi
b53cae32d3
doc: fix usage of folder and directory terms in fs.md
...
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md
Fixes: https://github.com/nodejs/node/issues/32902
PR-URL: https://github.com/nodejs/node/pull/32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-21 10:27:18 +03:00
雨夜带刀
c3554307c6
doc: fix typo in zlib.md
...
PR-URL: https://github.com/nodejs/node/pull/32901
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2020-04-20 18:54:46 -05:00
Gabriel Schulhof
d26ca06c16
n-api: detect deadlocks in thread-safe function
...
We introduce status `napi_would_deadlock` to be used as a return status
by `napi_call_threadsafe_function` if the call is made with
`napi_tsfn_blocking` on the main thread and the queue is full.
Fixes: https://github.com/nodejs/node/issues/32615
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com >
PR-URL: https://github.com/nodejs/node/pull/32860
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
2020-04-19 10:07:00 -07:00
Michael Dawson
2abec12838
doc: add N-API version 6 to table
...
We missed adding version 6 to the compatibility
table when we defined version 6. Add it along with the
versions that we know will include version 6.
PR-URL: https://github.com/nodejs/node/pull/32829
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com >
2020-04-17 15:35:26 -04:00
William Bonawentura
5e807c1fd2
doc: missing brackets
...
PR-URL: https://github.com/nodejs/node/pull/32657
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2020-04-17 12:19:39 -04:00
Michael Dawson
5a4f24e7e1
doc: improve consistency in usage of NULL
...
- add backticks around use of NULL
- convert from null to NULL where we mean
NULL
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com >
PR-URL: https://github.com/nodejs/node/pull/32726
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Christopher Hiller <boneskull@boneskull.com >
2020-04-16 17:12:37 -04:00
Gabriel Schulhof
d3d5eca657
Revert "n-api: detect deadlocks in thread-safe function"
...
This reverts commit aeb7084fe6 .
The solution creates incorrect behaviour on Windows.
Re: https://github.com/nodejs/node-addon-api/pull/697#issuecomment-612993476
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com >
PR-URL: https://github.com/nodejs/node/pull/32880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2020-04-16 12:52:12 -07:00
Robert Nagy
953445873a
doc: improve net docs
...
Refer back to streams docs for further and more accurate
description of behavior details.
Refs: https://github.com/nodejs/node/issues/31916
PR-URL: https://github.com/nodejs/node/pull/32811
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
2020-04-15 14:40:42 +02:00
Michaël Zasso
cf4c332b7a
2020-04-14, Version 13.13.0 (Current)
...
Notable changes:
New file system APIs:
* Added a new function, `fs.readv` (with sync and promisified versions).
This function takes an array of `ArrayBufferView` elements and will
write the data it reads sequentially to the buffers
(Sk Sajidul Kadir). https://github.com/nodejs/node/pull/32356
* A new overload is available for `fs.readSync`, which allows to
optionally pass any of the `offset`, `length` and `position`
parameters. https://github.com/nodejs/node/pull/32460
Other changes:
* dns:
* Added the `dns.ALL` flag, that can be passed to `dns.lookup()` with
`dns.V4MAPPED` to return resolved IPv6 addresses as well as IPv4
mapped IPv6 addresses (murgatroid99).
https://github.com/nodejs/node/pull/32183
* http:
* The default maximum HTTP header size was changed from 8KB to 16KB
(rosaxny). https://github.com/nodejs/node/pull/32520
* n-api:
* Calls to `napi_call_threadsafe_function` from the main thread can
now return the `napi_would_deadlock` status in certain
circumstances (Gabriel Schulhof).
https://github.com/nodejs/node/pull/32689
* util:
* Added a new `maxStrLength` option to `util.inspect`, to control the
maximum length of printed strings. Its default value is `Infinity`
(rosaxny). https://github.com/nodejs/node/pull/32392
* worker:
* Added support for passing a `transferList` along with `workerData`
to the `Worker` constructor (Juan José Arboleda).
https://github.com/nodejs/node/pull/32278
New core collaborators:
With this release, we welcome three new Node.js core collaborators:
* himself65. https://github.com/nodejs/node/pull/32734
* flarna (Gerhard Stoebich). https://github.com/nodejs/node/pull/32620
* mildsunrise (Alba Mendez). https://github.com/nodejs/node/pull/32525
PR-URL: https://github.com/nodejs/node/pull/32813
2020-04-14 20:22:41 +02:00
cjihrig
581d7d4a22
doc: add transform stream destroy() return value
...
PR-URL: https://github.com/nodejs/node/pull/32788
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-13 20:38:12 -04:00
cjihrig
f72feb7d70
cli, report: move --report-on-fatalerror to stable
...
This commit moves the last experimental feature of diagnostic
reports to stable status.
PR-URL: https://github.com/nodejs/node/pull/32496
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-13 20:33:44 -04:00
Cecchi MacNaughton
61e589f8ec
doc: remove warning from response.writeHead
...
The example referenced as being potentially unsafe specifies
Content-Length correctly.
PR-URL: https://github.com/nodejs/node/pull/32700
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2020-04-13 23:36:54 +02:00
unknown
1211b9a72f
util: change default value of maxStringLength to 10000
...
Refs: https://github.com/nodejs/node/pull/32392
PR-URL: https://github.com/nodejs/node/pull/32744
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matheus Marchini <mat@mmarchini.me >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-13 19:46:35 +02:00
Andrey Pechkurov
82d6726dcb
doc: improve AsyncLocalStorage sample
...
PR-URL: https://github.com/nodejs/node/pull/32757
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-04-13 18:46:45 +02:00
Harshitha KP and Mritunjay Goutam
2f755ffc8f
doc: document buffer.from returns internal pool buffer
...
Fixes: https://github.com/nodejs/node/issues/22139
Co-authored-by: Mritunjay Goutam <mritunjaygoutam2204@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/32703
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-13 18:39:12 +02:00
Andrey Pechkurov
50dd63e8ef
async_hooks: merge run and exit methods
...
PR-URL: https://github.com/nodejs/node/pull/31950
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2020-04-13 18:37:44 +02:00
Nimit
df05b0785b
doc: add useful v8 option section
...
This adds new section for v8 options and --max-old-space-size
Fixes: https://github.com/nodejs/node/issues/32252
PR-URL: https://github.com/nodejs/node/pull/32262
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
2020-04-11 16:07:55 +05:30
Rich Trott
1535243008
doc: split process.umask() entry into two
...
Split doc entries for process.umask() into one entry for process.umask()
(which is deprecated) and another for `process.umask(mask)` which is
not deprecated.
PR-URL: https://github.com/nodejs/node/pull/32711
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-10 13:21:11 -07:00
himself65
d0a3bf1f11
perf_hooks: allow omitted parameters in 'performance.measure'
...
Make `startMark` and `endMark` parameters optional.
PR-URL: https://github.com/nodejs/node/pull/32651
Fixes: https://github.com/nodejs/node/issues/32647
Refs: https://www.w3.org/TR/user-timing-2/#measure-method
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-10 18:08:30 +08:00
Gabriel Schulhof
aeb7084fe6
n-api: detect deadlocks in thread-safe function
...
We introduce status `napi_would_deadlock` to be used as a return status
by `napi_call_threadsafe_function` if the call is made with
`napi_tsfn_blocking` on the main thread and the queue is full.
PR-URL: https://github.com/nodejs/node/pull/32689
Fixes: https://github.com/nodejs/node/issues/32615
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: David Carlier <devnexen@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2020-04-09 02:41:28 -07:00
Michael Dawson
2681cba62e
doc: clarify behavior of napi_get_typedarray_info
...
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com >
Fixes: https://github.com/nodejs/node/issues/32089
PR-URL: https://github.com/nodejs/node/pull/32603
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-04-08 14:57:52 -04:00
unknown
944d8626b3
util: add maxStrLength option to inspect function
...
Refs: https://github.com/nodejs/node/issues/25478
PR-URL: https://github.com/nodejs/node/pull/32392
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Matheus Marchini <mat@mmarchini.me >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-04-08 18:02:54 +02:00
Rich Trott
c849f2d4f8
doc: remove optional parameter from markdown anchor link
...
Fix up a few instances so that lines don't xceed 80 characters.
PR-URL: https://github.com/nodejs/node/pull/32671
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-07 15:18:13 -07:00
Harshitha KP and Divyanshu
8c12a08de5
doc: clarify listening event
...
Co-authored-by: Divyanshu <dsinecos@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/32581
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-04-07 20:31:40 +02:00
Andrey Pechkurov
561dda273f
async_hooks: move to lazy destroy hook registration in AsyncResource
...
PR-URL: https://github.com/nodejs/node/pull/32429
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
2020-04-06 16:14:43 +02:00
Dave Vandyke
8c0a17ae28
doc: correct version metadata for Readable.from
...
PR-URL: https://github.com/nodejs/node/pull/32639
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-04-05 21:16:39 +02:00
Juan José Arboleda
34a4ab7278
doc: clarify docs fs.watch exception may be emitted
...
Fixes: https://github.com/nodejs/node/issues/29894
PR-URL: https://github.com/nodejs/node/pull/32513
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-04-05 20:50:23 +02:00