James M Snell
fe11f6bf7c
quic: cleanup QuicSocketFlags, used shared state struct
...
Some of the flags were no longer being used.
Switched to use an AliasedStruct for shared state to avoid
extraneous expensive JS=>C++ calls.
Removed unused QuicSocket option
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-09 07:15:43 -07:00
James M Snell
71236097d0
quic: use Number() instead of bigint for QuicSocket stats
...
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-09 07:14:17 -07:00
James M Snell
94372b124a
quic: refactor/improve/document QuicSocket listening event
...
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-09 07:14:14 -07:00
James M Snell
cc89aac5f7
quic: refactor/improve error handling for busy event
...
Also, change setServerBusy into a setter
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-09 07:14:07 -07:00
James M Snell
edc71ef008
quic: handle errors thrown / rejections in the session event
...
Errors thrown within the session event handler will be handled
by destroying the session (allowing a proper connection close
to be sent to the client peer). They will not crash the parent
QuicSocket by default. Instead, a `'sessionError'` event will
be emitted, allowing the error to be logged or handled.
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-09 07:14:05 -07:00
rickyes
527e2147af
stream: add promises version to utility functions
...
PR-URL: https://github.com/nodejs/node/pull/33991
Fixes: https://github.com/nodejs/node/issues/33582
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2020-07-09 09:12:19 +02:00
sapics
3975799f26
doc: replace http to https of link urls
...
PR-URL: https://github.com/nodejs/node/pull/34158
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-06 07:03:05 -07:00
Rich Trott
bf772896fe
doc: remove errors that were never released
...
Refs: https://github.com/nodejs/node/pull/33764#issuecomment-653667275
PR-URL: https://github.com/nodejs/node/pull/34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-06 07:02:17 -07:00
Rich Trott
654df09ae0
doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors
...
ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list
of errors that have never been released. It was added in
67e067eb06 and included in every release
in the 14.x line.
PR-URL: https://github.com/nodejs/node/pull/34196
Reviewed-By: Richard Lau <riclau@uk.ibm.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-07-05 15:05:43 -07:00
James M Snell and zombieleet
e7dadd376e
doc: specify how fs.WriteStream/ReadStreams are created
...
Alternative to https://github.com/nodejs/node/pull/33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/34188
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-07-05 14:19:42 -07:00
James M Snell
7b062ca015
quic: refactor qlog handling
...
Because of the timing of qlog events emitted by ngtcp2, it
becomes difficult to handle those as events on the QuicSession
object because the final qlog entry is not emitted until the
ngtcp2_conn is freed, which can occur when the object is being
garbage collected (meaning, we a: can't call out to javascript
and b: don't have an object we can use to emit the event).
This refactors it into a QLogStream object that allows the
qlog data to be piped out using a separate Readable stream.
PR-URL: https://github.com/nodejs/node/pull/34160
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-05 14:17:33 -07:00
Rich Trott
56dbe466fd
doc: remove parenthetical \r\n comment in http and http2 docs
...
The explanation that the HTTP requests include `\r\n` is true but not
important or relevant in these two specific contexts.
PR-URL: https://github.com/nodejs/node/pull/34178
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2020-07-04 16:46:26 -07:00
Rich Trott
21005c3b44
doc: remove stability from unreleased errors
...
Remove stability indicators from errors that only existed on the master
branch and are not in the release.
PR-URL: https://github.com/nodejs/node/pull/33764
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-04 05:51:42 -07:00
Bradley Farias
16f3b6a01b
doc: util.debuglog callback
...
PR-URL: https://github.com/nodejs/node/pull/33856
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 15:01:10 -07:00
Julien Poissonnier
647babc2fd
doc: update wording in "Two reading modes"
...
PR-URL: https://github.com/nodejs/node/pull/34119
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 14:53:17 -07:00
Luigi Pinca
d2c8b3efc3
doc: clarify that the ctx argument is optional
...
Clarify that the `ctx` argument of the `SNICallback` callback is
optional.
Fixes: https://github.com/nodejs/node/issues/34085
PR-URL: https://github.com/nodejs/node/pull/34097
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 14:49:30 -07:00
Mateusz Krawczuk
d3d4aceb96
doc: add a reference to the list of OpenSSL flags.
...
Some of the SSL_OP_* constants are missing description in the
documentation. Instead of rewriting the description from OpenSSL's
wiki, I have decided to put a link to a detailed list in the
'OpenSSL Options' section.
I see no point of doing both - adding a reference to the wiki and
adding constant descriptions - but I might do if presented with
convincing arguments.
This is a follow-up to #33929 .
PR-URL: https://github.com/nodejs/node/pull/34050
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 14:44:21 -07:00
Sam Roberts
3f81f2a421
doc: no longer maintain a CNA structure
...
Node.js hasn't touched the cve-management repo since the Feb 2019
security release, we've used the HackerOne CVE allocation process.
Maintaining our status as a CNA is not zero cost, there is some routine
adminstration that is requested (see this doc for details).
As we no longer use the CVE management process, I propose removing it.
If this lands, I will go through the interactions with Mitre so that
Node.js is no longer a CNA and cleanup related resources (email aliases,
archive the cve-management repo, whatever else I find).
PR-URL: https://github.com/nodejs/node/pull/33639
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
2020-07-03 14:38:26 -07:00
Saleem
1a9d6316b8
doc: use consistent naming in stream doc
...
Consistency of method naming
referred to as readable.push several other times in transform
documentation and also documented under readable, so makes sense
to just stick with readable.push
PR-URL: https://github.com/nodejs/node/pull/30506
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 14:28:22 -07:00
Anentropic
7c9df66485
doc: clarify how to read process.stdin
...
document more clearly that stdin will emit multiple readable events
PR-URL: https://github.com/nodejs/node/pull/27350
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 14:05:47 -07:00
Gabriel Schulhof
cfa3d8fec5
doc: fix entry for napi_create_external_buffer
...
Remove text regarding copying, because `napi_create_external_buffer`
does not copy.
Fixes: https://github.com/nodejs/node/issues/33471
PR-URL: https://github.com/nodejs/node/pull/34125
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Mathias Buus <mathiasbuus@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 13:57:50 -07:00
Rodion Abdurakhimov
d853145277
doc: fix source link margin to sub-header mark
...
Prior to this commit, [src] link overlapped sharped (#) sub-header link
PR-URL: https://github.com/nodejs/node/pull/33664
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 13:35:17 -07:00
Denys Otrishko
b4fe76d656
doc: improve async_hooks asynchronous context example
...
* use writeFile(1) everywhere to log
* prettify execution id graph
* add clearer explanation for TickObject presence
* add causation graph via triggerAsyncId
PR-URL: https://github.com/nodejs/node/pull/33730
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
2020-07-03 13:24:39 -07:00
Derek Lewis
db3b209e7d
doc: clarify esm conditional exports prose
...
This commit clarifies the behavior of a couple aspects of
conditional exports that may have been difficult to grasp
from the prose alone.
PR-URL: https://github.com/nodejs/node/pull/33886
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 12:16:23 -07:00
rickyes
a7c6806adc
doc: Add maxTotalSockets option to agent constructor
...
PR-URL: https://github.com/nodejs/node/pull/34013
Refs: https://github.com/nodejs/node/pull/33617
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 12:14:03 -07:00
rickyes
7f2cf0f8da
doc: add streams to the pipeline function signature
...
PR-URL: https://github.com/nodejs/node/pull/34153
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 12:11:48 -07:00
Rich Trott
2110fadecd
doc: improve triaging text in issues.md
...
Remove a double negative and many superfluous sentences. The sentiment
in the removed material is good, but we already tell people that
discussion should be focused, helpful, and professional. Having two
extra paragraphs greatly reduces the likelihood that people will read
the material.
PR-URL: https://github.com/nodejs/node/pull/34164
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 12:08:41 -07:00
Rich Trott
907829b1a4
doc: simply dns.ADDRCONFIG language
...
PR-URL: https://github.com/nodejs/node/pull/34155
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-07-03 12:03:37 -07:00
Rich Trott
829f521fda
doc: remove "considered" in errors.md
...
"would be considered a `TypeError`" -> "would be a `TypeError`".
Using "considered" introduces unnecessary ambiguity. Is is not actually
a TypeError but merely "considered" one? Why is that? We don't say.
Simplify to "is a TypeError".
PR-URL: https://github.com/nodejs/node/pull/34152
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com >
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2020-07-03 07:35:58 -07:00
Rich Trott
dfeeb3c275
doc: simplify and clarify ReferenceError material in errors.md
...
"should always be considered" -> "indicate"
PR-URL: https://github.com/nodejs/node/pull/34151
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
Reviewed-By: Christian Clauss <cclauss@me.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com >
2020-07-03 07:33:29 -07:00
Derek Lewis
1dc837ed9a
doc: add http highlight grammar
...
Prior to this commit, http request message code blocks in Markdown
files were not being highlighted correctly. This has been corrected by
adding the new grammar to the bundle, removing the CRLFs (`\r\n`) from
these code samples, adding a reminder to re-add them, and tuning the
syntax theme to support attribute highlighting.
PR-URL: https://github.com/nodejs/node/pull/33785
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2020-07-02 16:32:42 -07:00
Rich Trott
f06df175b4
doc: change "considered experimental" to "experimental" in n-api.md
...
This changes "considered" experimental" to "experimental" in the
n-api.md file and introduces some additional brevity.
PR-URL: https://github.com/nodejs/node/pull/34129
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-07-02 05:37:25 -07:00
Rich Trott
79eb529c3e
doc: changed "considered experimental" to "experimental" in cli.md
...
Change "no longer considered experimental" to "no longer experimental"
in cli.md.
PR-URL: https://github.com/nodejs/node/pull/34128
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2020-07-02 05:35:57 -07:00
falguniraina
c118304ad0
doc: improve text in issues.md
...
PR-URL: https://github.com/nodejs/node/pull/33973
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
2020-07-01 19:54:23 -07:00
Robert Nagy
c7e55c6b72
stream: fix writable.end callback behavior
...
Changes so that the end() callback behaves the same way in relation
to _final as write() does to _write/_writev.
PR-URL: https://github.com/nodejs/node/pull/34101
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-07-01 18:18:04 +02:00
Rich Trott
e2b468eb5c
doc: change "currently not considered public" to "not supported"
...
PR-URL: https://github.com/nodejs/node/pull/34114
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-06-30 21:56:11 -07:00
Rich Trott
70ec18c4eb
doc: clarify that APIs are no longer experimental
...
Change "no longer considered experimental" to "no longer experimental".
It's more clear and direct.
PR-URL: https://github.com/nodejs/node/pull/34113
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-06-30 21:54:52 -07:00
Rich Trott
8ff8c684d6
doc: clarify O_EXCL text in fs.md
...
PR-URL: https://github.com/nodejs/node/pull/34096
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
2020-06-30 21:53:48 -07:00
Rich Trott
584fc7e965
doc: clarify ambiguous rdev description
...
Replace "is considered 'special'" with "represents a device". The latter
is more clear and is derived from the stat() man page. The former is
also derived from the man page, but is ambiguous because:
* "considered" introduces doubt. Is it, or isn't it?
* "special" is never defined. "represents a device" communicates more
meaning.
* "special" is in scare-quotes, introducing more doubt as to what
exactly it means.
Refs: https://man7.org/linux/man-pages/man2/fstat.2.html
PR-URL: https://github.com/nodejs/node/pull/34094
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
2020-06-30 21:52:40 -07:00
Shelley Vohr
eb8fc2bf0f
2020-06-30, Version 14.5.0 (Current)
...
Notable changes:
build:
* (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) https://github.com/nodejs/node/pull/33376
cli:
* (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) https://github.com/nodejs/node/pull/33587
crypto:
* (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) https://github.com/nodejs/node/pull/33360
deps:
* (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) https://github.com/nodejs/node/pull/33376
* (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) https://github.com/nodejs/node/pull/33376
dgram:
* (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) https://github.com/nodejs/node/pull/22413
events:
* (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) https://github.com/nodejs/node/pull/33556
fs:
* (SEMVER-MINOR) implement lutimes (Maël Nison) https://github.com/nodejs/node/pull/33399
http:
* (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) https://github.com/nodejs/node/pull/33803
* (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) https://github.com/nodejs/node/pull/33617
* (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) https://github.com/nodejs/node/pull/32789
* (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) https://github.com/nodejs/node/pull/32789
* (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) https://github.com/nodejs/node/pull/32789
* (SEMVER-MINOR) added scheduling option to http agent (delvedor) https://github.com/nodejs/node/pull/33278
http2:
* (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) https://github.com/nodejs/node/pull/33994
* (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) https://github.com/nodejs/node/pull/33160
process:
* (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) https://github.com/nodejs/node/pull/33475
src:
* (SEMVER-MINOR) store key data in separate class (Tobias Nießen) https://github.com/nodejs/node/pull/33360
* (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) https://github.com/nodejs/node/pull/33360
* (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) https://github.com/nodejs/node/pull/33360
* (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) https://github.com/nodejs/node/pull/33772
* (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) https://github.com/nodejs/node/pull/33772
* (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) https://github.com/nodejs/node/pull/33850
stream*:
* runtime deprecate Transform._transformState (Robert Nagy) https://github.com/nodejs/node/pull/32763
win:
* (SEMVER-MINOR) allow skipping the supported platform check (João Reis) https://github.com/nodejs/node/pull/33176
worker:
* (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) https://github.com/nodejs/node/pull/33979
* (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) https://github.com/nodejs/node/pull/33772
* (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) https://github.com/nodejs/node/pull/33772
* (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) https://github.com/nodejs/node/pull/33772
worker,fs:
* (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) https://github.com/nodejs/node/pull/33772
zlib:
* (SEMVER-MINOR) add `maxOutputLength` option (unknown) https://github.com/nodejs/node/pull/33516
PR-URL: https://github.com/nodejs/node/pull/34093
2020-06-30 15:27:43 -07:00
Robert Nagy
0edeeec3ec
net: doc deprecate bufferSize
...
PR-URL: https://github.com/nodejs/node/pull/34088
Refs: https://github.com/nodejs/node/issues/34078
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2020-06-30 22:36:51 +02:00
Beth Griggs
cb673e1b61
2020-06-30, Version 12.18.2 'Erbium' (LTS)
...
Notable changes:
- deps: V8: backport fb26d0bb1835 (Matheus Marchini)
[#33573 ](https://github.com/nodejs/node/pull/33573 )
- src: use symbol to store `AsyncWrap` resource (Anna Henningsen)
[#31745 ](https://github.com/nodejs/node/pull/31745 )
PR-URL: https://github.com/nodejs/node/pull/34077
2020-06-30 14:31:59 +01:00
Gus Caplan
9e135accbb
wasi: add reactor support
...
PR-URL: https://github.com/nodejs/node/pull/34046
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2020-06-29 09:52:09 -05:00
Rich Trott
90d5f35f7a
doc: make minor improvements to paragraph in child_process.md
...
Use shorter and more direct phrasing.
PR-URL: https://github.com/nodejs/node/pull/34063
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
2020-06-28 21:47:33 -07:00
Rich Trott
95eecd58b3
doc: improve paragraph in esm.md
...
Edit for clarity, correct tense, and brevity.
PR-URL: https://github.com/nodejs/node/pull/34064
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2020-06-28 20:26:27 -07:00
Guy Bedford
f89530fccc
doc: clarify require/import mutual exclusivity
...
PR-URL: https://github.com/nodejs/node/pull/33832
Reviewed-By: Jan Krems <jan.krems@gmail.com >
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com >
2020-06-27 21:18:54 -07:00
Anna Henningsen
f63436d190
vm: add run-after-evaluate microtask mode
...
This allows timeouts to apply to e.g. `Promise`s and `async function`s
from code running inside of `vm.Context`s, by giving the Context its
own microtasks queue.
Fixes: https://github.com/nodejs/node/issues/3020
PR-URL: https://github.com/nodejs/node/pull/34023
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Denys Otrishko <shishugi@gmail.com >
2020-06-26 11:41:33 -07:00
Alec Davidson
e68563e31c
doc: add dynamic source code links
...
Fixes: https://github.com/nodejs/node/pull/33977
PR-URL: https://github.com/nodejs/node/pull/33996
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-06-26 10:25:14 -07:00
Pranshu Srivastava
074df495ed
doc: specify maxHeaderCount alias for maxHeaderListPairs
...
Fixes: https://github.com/nodejs/node/issues/32388
PR-URL: https://github.com/nodejs/node/pull/33519
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Zeyu Yang <himself65@outlook.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2020-06-26 10:09:28 -07:00
Anna Henningsen
072feec1b0
Revert "repl: always check for NODE_REPL_MODE environment variable"
...
This reverts commit b831b081c4 .
This presumably unbreaks the ASAN github action build.
Example failure:
2020-06-25T19:59:15.1448178Z === release test-repl-envvars ===
2020-06-25T19:59:15.1448872Z Path: parallel/test-repl-envvars
2020-06-25T19:59:15.1449449Z --- stderr ---
2020-06-25T19:59:15.1449835Z assert.js:103
2020-06-25T19:59:15.1450194Z throw new AssertionError(obj);
2020-06-25T19:59:15.1450524Z ^
2020-06-25T19:59:15.1450817Z
2020-06-25T19:59:15.1451431Z AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
2020-06-25T19:59:15.1452000Z + actual - expected
2020-06-25T19:59:15.1452298Z
2020-06-25T19:59:15.1452634Z {
2020-06-25T19:59:15.1452978Z terminal: true,
2020-06-25T19:59:15.1453321Z + useColors: false
2020-06-25T19:59:15.1453861Z - useColors: true
2020-06-25T19:59:15.1454225Z }
2020-06-25T19:59:15.1454841Z at /home/runner/work/node/node/test/parallel/test-repl-envvars.js:55:12
2020-06-25T19:59:15.1455246Z at internal/repl.js:33:5
PR-URL: https://github.com/nodejs/node/pull/34058
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2020-06-25 19:18:55 -07:00