mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Matteo Collina
49ad95045a
Enable node:vfs by default. --no-experimental-vfs disables node:vfs exposure and --vfs-load. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/66318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
46 lines
1.8 KiB
JavaScript
46 lines
1.8 KiB
JavaScript
// Flags: --disable-warning=ExperimentalWarning
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const os = require('os');
|
|
const path = require('path');
|
|
const vfs = require('node:vfs');
|
|
|
|
const addonPath = path.join(
|
|
__dirname, '..', 'addons', 'hello-world', 'build', 'Release', 'binding.node');
|
|
if (!fs.existsSync(addonPath)) {
|
|
common.skip('the hello-world addon is not built');
|
|
}
|
|
|
|
// A native addon inside a mounted VFS can be require()d: dlopen() cannot open
|
|
// the reserved mount path, so the loader hands the addon's bytes to
|
|
// process.dlopen's `binary` option, which loads them from a private temporary
|
|
// image (an in-memory memfd on Linux).
|
|
const myVfs = vfs.create();
|
|
myVfs.writeFileSync('/binding.node', fs.readFileSync(addonPath));
|
|
const mountPoint = myVfs.mount();
|
|
|
|
const before = new Set(fs.readdirSync(os.tmpdir()));
|
|
const addon = require(path.join(mountPoint, 'binding.node'));
|
|
assert.strictEqual(addon.hello(), 'world');
|
|
|
|
// On Linux the memfd path never touches the filesystem; on other POSIX the
|
|
// temp image is unlinked right after loading, so no addon temp file lingers.
|
|
// (Windows keeps a delete-on-close file until exit, so skip the check there.)
|
|
if (process.platform !== 'win32') {
|
|
const leaked = fs.readdirSync(os.tmpdir())
|
|
.filter((f) => f.startsWith('node-addon') && !before.has(f));
|
|
assert.deepStrictEqual(leaked, [], `addon temp not cleaned up: ${leaked}`);
|
|
}
|
|
|
|
// Regression check: while a VFS is mounted, process.dlopen() of a
|
|
// real-file-system addon without a flags argument must keep the default
|
|
// flags rather than forwarding `undefined`, which coerces to 0 - not a
|
|
// valid dlopen(2) mode.
|
|
const realMod = { exports: {} };
|
|
process.dlopen(realMod, addonPath);
|
|
assert.strictEqual(realMod.exports.hello(), 'world');
|
|
|
|
myVfs.unmount();
|