Myles Borins 4897f94ec6 node_contextify: do not incept debug context ...

Currently a debug context is created for various calls to util.

If the node debugger is being run the main context is the debug
context. In this case node_contextify was freeing the debug context
and causing everything to explode.

This change moves around the logic and no longer frees the context.

There is a concern about the dangling pointer

The regression test was adapted from code submitted by @3y3 in #4815

Fixes: https://github.com/nodejs/node/issues/4440
Fixes: https://github.com/nodejs/node/issues/4815
Fixes: https://github.com/nodejs/node/issues/4597
Fixes: https://github.com/nodejs/node/issues/4952

PR-URL: https://github.com/nodejs/node/issues/4815

Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>

2016-02-05 15:40:56 -08:00

..

res

build,win: fix node.exe resource version

2015-10-01 11:50:51 +01:00

async-wrap-inl.h

async_wrap: call callback in destructor

2015-11-06 16:37:11 -07:00

async-wrap.cc

async_wrap: call callback in destructor

2015-11-06 16:37:11 -07:00

async-wrap.h

async_wrap: call callback in destructor

2015-11-06 16:37:11 -07:00

atomic-polyfill.h

src: fix race condition in debug signal on exit

2015-10-27 12:57:09 +01:00

base-object-inl.h

Revert "core: set PROVIDER type as Persistent class id"

2015-05-28 21:48:44 +02:00

base-object.h

Revert "core: set PROVIDER type as Persistent class id"

2015-05-28 21:48:44 +02:00

cares_wrap.cc

src: return UV_EAI_NODATA on empty lookup

2016-01-18 09:53:35 -05:00

CNNICHashWhitelist.inc

crypto: add cert check to CNNIC Whitelist

2015-06-16 23:26:29 +09:00

debug-agent.cc

src: remove no longer relevant comments

2016-02-01 21:28:06 +01:00

debug-agent.h

src: remove no longer relevant comments

2016-02-01 21:28:06 +01:00

env-inl.h

src: upgrade to new v8::Private api

2016-02-03 01:04:31 +01:00

env.cc

src: define getpid() based on OS

2015-12-03 21:24:05 -05:00

env.h

src: upgrade to new v8::Private api

2016-02-03 01:04:31 +01:00

fs_event_wrap.cc

src: Add ABORT macro

2015-09-17 15:25:14 -05:00

handle_wrap.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

handle_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

js_stream.cc

js_stream: prevent abort if isalive doesn't exist

2015-10-08 11:38:21 -06:00

js_stream.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_buffer.cc

buffer: properly retrieve binary length of needle

2016-01-22 11:32:43 -07:00

node_buffer.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_constants.cc

tls, crypto: add ALPN Support

2015-10-27 01:31:47 +09:00

node_constants.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_contextify.cc

node_contextify: do not incept debug context

2016-02-05 15:40:56 -08:00

node_counters.cc

src: remove forwards for v8::GC*logueCallback

2015-12-22 08:11:41 -08:00

node_counters.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_crypto_bio.cc

src: Add ABORT macro

2015-09-17 15:25:14 -05:00

node_crypto_bio.h

src: fix crypto bio integer wraparound on 32 bits

2015-03-18 20:06:20 +01:00

node_crypto_clienthello-inl.h

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_crypto_clienthello.cc

build,src: remove sslv3 support

2015-01-13 01:59:30 +01:00

node_crypto_clienthello.h

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_crypto_groups.h

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_crypto.cc

tls: add getProtocol() to TLS sockets

2016-02-03 21:34:06 -05:00

node_crypto.h

tls: add getProtocol() to TLS sockets

2016-02-03 21:34:06 -05:00

node_dtrace.cc

src: remove forwards for v8::GC*logueCallback

2015-12-22 08:11:41 -08:00

node_dtrace.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_file.cc

fs: use pushValueToArray for readdir(Sync)

2015-12-17 17:29:06 -07:00

node_file.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_http_parser.cc

http_parser: use pushValueToArray for headers

2015-12-17 17:28:53 -07:00

node_http_parser.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_i18n.cc

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_i18n.h

src: hide InitializeICUDirectory symbol

2015-06-02 21:44:18 +02:00

node_internals.h

src: attach error to stack on displayErrors

2016-01-26 11:03:13 -05:00

node_javascript.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_javascript.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_lttng_provider.h

lttng: update flags for gc tracing

2015-10-20 23:38:28 +02:00

node_lttng_tp.h

tracing: add lttng support for tracing on linux

2015-02-09 18:06:57 +01:00

node_lttng.cc

src: remove forwards for v8::GC*logueCallback

2015-12-22 08:11:41 -08:00

node_lttng.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_main.cc

src: force line buffering for stderr

2015-11-10 17:52:44 -08:00

node_object_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_os.cc

os: fix crash in GetInterfaceAddresses

2016-01-04 15:04:16 +11:00

node_provider.d

src: remove unused dtrace probes

2015-02-02 21:55:56 +01:00

node_root_certs.h

crypto: update root certificates

2015-11-21 21:33:30 +01:00

node_stat_watcher.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_stat_watcher.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

node_util.cc

src: upgrade to new v8::Private api

2016-02-03 01:04:31 +01:00

node_v8.cc

v8,src: expose statistics about heap spaces

2016-01-18 11:44:00 -05:00

node_version.h

src: bump NODE_MODULE_VERSION To 47

2015-10-20 23:11:07 -04:00

node_watchdog.cc

vm: remove Watchdog dependency on Environment

2015-10-21 00:34:53 +02:00

node_watchdog.h

vm: remove Watchdog dependency on Environment

2015-10-21 00:34:53 +02:00

node_win32_etw_provider-inl.h

dtrace: fix removal of unused probes

2015-02-03 22:37:42 +11:00

node_win32_etw_provider.cc

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_win32_etw_provider.h

src: remove unused dtrace probes

2015-02-02 21:55:56 +01:00

node_win32_perfctr_provider.cc

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_win32_perfctr_provider.h

Remove excessive copyright/license boilerplate

2015-01-12 15:30:28 -08:00

node_wrap.h

stream_base: various improvements

2015-08-20 01:14:37 -07:00

node_zlib.cc

zlib: decompression throw on truncated input

2015-10-19 15:06:05 -06:00

node.cc

src: upgrade to new v8::Private api

2016-02-03 01:04:31 +01:00

node.d

dtrace: add missing translator

2012-02-03 14:07:32 +00:00

node.h

src: fix deprecation message for ErrnoException

2015-12-14 12:31:00 -08:00

node.js

node: deprecate process.EventEmitter

2016-02-04 13:43:15 -06:00

node.stp

src: remove unused dtrace probes

2015-02-02 21:55:56 +01:00

nolttng_macros.py

tracing: add lttng support for tracing on linux

2015-02-09 18:06:57 +01:00

notrace_macros.py

src: remove unused dtrace probes

2015-02-02 21:55:56 +01:00

perfctr_macros.py

windows: add tracing with performance counters

2012-11-21 01:21:53 +01:00

pipe_wrap.cc

async_wrap: update providers and add test

2015-10-01 13:54:44 -06:00

pipe_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

process_wrap.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

req-wrap-inl.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

req-wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

signal_wrap.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

spawn_sync.cc

src: Add ABORT macro

2015-09-17 15:25:14 -05:00

spawn_sync.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

stream_base-inl.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

stream_base.cc

http: fix out-of-order 'finish' bug in pipelining

2015-10-06 07:02:20 +11:00

stream_base.h

tls_wrap: reach error reporting for UV_EPROTO

2016-01-27 17:27:52 -05:00

stream_wrap.cc

stream_wrap: support empty TryWrites

2015-10-06 07:02:21 +11:00

stream_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

string_bytes.cc

src: add BE support to StringBytes::Encode()

2015-11-24 15:26:23 +01:00

string_bytes.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

string_search.cc

src: replace naive search in Buffer::IndexOf

2015-10-07 21:09:53 -07:00

string_search.h

src: replace naive search in Buffer::IndexOf

2015-10-07 21:09:53 -07:00

tcp_wrap.cc

async_wrap: update providers and add test

2015-10-01 13:54:44 -06:00

tcp_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

timer_wrap.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

tls_wrap.cc

tls_wrap: reach error reporting for UV_EPROTO

2016-01-27 17:27:52 -05:00

tls_wrap.h

tls_wrap: reach error reporting for UV_EPROTO

2016-01-27 17:27:52 -05:00

tree.h

dns: don't rely on libuv for c-ares integration

2012-08-07 01:57:50 +02:00

tty_wrap.cc

src: Add ABORT macro

2015-09-17 15:25:14 -05:00

tty_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

udp_wrap.cc

dgram: support dgram.send with multiple buffers

2016-01-29 19:26:44 +01:00

udp_wrap.h

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

util-inl.h

src: remove __builtin_bswap16 call

2015-12-15 16:37:10 +01:00

util.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

util.h

src: add BE support to StringBytes::Encode()

2015-11-24 15:26:23 +01:00

uv.cc

src: replace usage of v8::Handle with v8::Local

2015-09-06 21:38:05 +10:00

v8abbr.h

v8abbr: ASCIISTRINGTAG => ONEBYTESTRINGTAG

2015-02-03 19:25:31 +03:00

v8ustack.d

dtrace: backport two byte string fix

2013-10-09 08:49:39 -07:00