mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Ali Ijaz Sheikh
73fc440870
Recent phantom weakness API changes to buffer, ebbbc5a, ending up
introducing an alignment restriction on the native buffer pointers.
It turns out that there are uses in the modules ecosystem that rely
on the ability to create buffers with unaligned pointers (e.g.
node-ffi).
It turns out there is a simpler solution possible here. As a side
effect this also removes the need to have to reserve the first
internal field on buffers.
PR-URL: https://github.com/nodejs/node/pull/5752
Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
69 lines
2.3 KiB
C++
69 lines
2.3 KiB
C++
#ifndef SRC_NODE_BUFFER_H_
|
|
#define SRC_NODE_BUFFER_H_
|
|
|
|
#include "node.h"
|
|
#include "v8.h"
|
|
|
|
namespace node {
|
|
|
|
extern bool zero_fill_all_buffers;
|
|
|
|
namespace Buffer {
|
|
|
|
static const unsigned int kMaxLength =
|
|
sizeof(int32_t) == sizeof(intptr_t) ? 0x3fffffff : 0x7fffffff;
|
|
|
|
NODE_EXTERN typedef void (*FreeCallback)(char* data, void* hint);
|
|
|
|
NODE_EXTERN bool HasInstance(v8::Local<v8::Value> val);
|
|
NODE_EXTERN bool HasInstance(v8::Local<v8::Object> val);
|
|
NODE_EXTERN char* Data(v8::Local<v8::Value> val);
|
|
NODE_EXTERN char* Data(v8::Local<v8::Object> val);
|
|
NODE_EXTERN size_t Length(v8::Local<v8::Value> val);
|
|
NODE_EXTERN size_t Length(v8::Local<v8::Object> val);
|
|
|
|
// public constructor - data is copied
|
|
NODE_EXTERN v8::MaybeLocal<v8::Object> Copy(v8::Isolate* isolate,
|
|
const char* data,
|
|
size_t len);
|
|
|
|
// public constructor
|
|
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);
|
|
|
|
// public constructor from string
|
|
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
|
|
v8::Local<v8::String> string,
|
|
enum encoding enc = UTF8);
|
|
|
|
// public constructor - data is used, callback is passed data on object gc
|
|
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
|
|
char* data,
|
|
size_t length,
|
|
FreeCallback callback,
|
|
void* hint);
|
|
|
|
// public constructor - data is used.
|
|
NODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,
|
|
char* data,
|
|
size_t len);
|
|
|
|
// This is verbose to be explicit with inline commenting
|
|
static inline bool IsWithinBounds(size_t off, size_t len, size_t max) {
|
|
// Asking to seek too far into the buffer
|
|
// check to avoid wrapping in subsequent subtraction
|
|
if (off > max)
|
|
return false;
|
|
|
|
// Asking for more than is left over in the buffer
|
|
if (max - off < len)
|
|
return false;
|
|
|
|
// Otherwise we're in bounds
|
|
return true;
|
|
}
|
|
|
|
} // namespace Buffer
|
|
} // namespace node
|
|
|
|
#endif // SRC_NODE_BUFFER_H_
|