Sam Roberts 04633eeeb9 readline: error on falsy values for callback ...

It was intended, according to in-test comments and common behaviour,
that callbacks be either `undefined` or a function, but falsy values
were being accepted as meaning "no callback".

PR-URL: https://github.com/nodejs/node/pull/28109
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

2019-06-10 11:09:40 -07:00

..

internal

http2: do not register unnecessary listeners

2019-06-10 17:16:10 +02:00

_http_agent.js

async_hooks: don't reuse resource in HttpAgent

2019-05-19 23:17:06 +02:00

_http_client.js

http: remove default 'timeout' listener on upgrade

2019-06-08 13:35:37 +02:00

_http_common.js

async_hooks: fixup do not reuse HTTPParser

2019-05-03 16:02:55 +02:00

_http_incoming.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

_http_outgoing.js

http: call write callback even if there is no message body

2019-06-01 15:18:06 +02:00

_http_server.js

http: remove default 'timeout' listener on upgrade

2019-06-08 13:35:37 +02:00

_stream_duplex.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

_stream_passthrough.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

_stream_readable.js

stream: convert string to Buffer when calling unshift(<string>)

2019-06-02 16:56:13 +02:00

_stream_transform.js

stream: remove TODO and add a description instead

2019-05-02 23:16:14 +02:00

_stream_wrap.js

lib: assign missed deprecation code

2019-03-07 15:48:55 +01:00

_stream_writable.js

stream: use readableObjectMode public api for js stream

2019-05-19 23:37:51 +02:00

_tls_common.js

tls: fix createSecureContext() cipher list filter

2019-05-10 11:25:29 -07:00

_tls_wrap.js

crypto: add debug info client emit secureConnect

2019-06-10 05:29:10 +02:00

.eslintrc.yaml

lib: require globals instead of using the global proxy

2019-04-16 04:24:26 +08:00

assert.js

assert: use less read operations

2019-05-05 14:44:21 -07:00

async_hooks.js

process: improve queueMicrotask performance

2019-06-10 07:49:40 +02:00

buffer.js

buffer: remove unreachable code

2019-04-30 06:37:55 -07:00

child_process.js

child_process: move exports to bottom for consistent code style

2019-06-02 15:32:01 +02:00

cluster.js

…

console.js

console: split console into global.js and constructor.js

2018-12-02 04:51:18 +08:00

constants.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

crypto.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

dgram.js

dgram: fix abort on bad args

2019-06-10 09:14:13 -07:00

dns.js

dns: do not indicate invalid IPs are IPv6

2019-04-16 16:19:17 -07:00

domain.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

events.js

events: improve max listeners warning

2019-05-17 05:39:00 +02:00

fs.js

lib: removed unnecessary fs.realpath options arg check + tests

2019-05-30 15:02:11 +05:30

http2.js

http2: order declarations in http2.js

2018-11-20 10:42:31 -08:00

http.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

https.js

http, http2: remove default server timeout

2019-05-09 08:54:04 -07:00

inspector.js

inspector: removing checking of non existent field in lib/inspector.js

2019-05-29 22:21:55 +05:30

module.js

lib: rework logic of stripping BOM+Shebang from commonjs

2019-05-26 13:04:29 -05:00

net.js

net: make writeAfterFIN() return false

2019-06-04 06:02:58 +02:00

os.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

path.js

path: simplify normalizeString

2019-04-18 05:32:10 +02:00

perf_hooks.js

lib: require globals instead of using the global proxy

2019-04-16 04:24:26 +08:00

process.js

…

punycode.js

lib: update punycode to 2.1.1

2018-07-16 15:55:15 -07:00

querystring.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

readline.js

readline: error on falsy values for callback

2019-06-10 11:09:40 -07:00

repl.js

lib: rework logic of stripping BOM+Shebang from commonjs

2019-05-26 13:04:29 -05:00

stream.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

string_decoder.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

sys.js

benchmark,doc,lib,test: capitalize comments

2019-03-10 00:44:40 +01:00

timers.js

lib: remove outdated optimizations

2019-04-29 20:46:53 +08:00

tls.js

tls: expose built-in root certificates

2019-05-20 11:09:02 +02:00

trace_events.js

trace_events: respect inspect() depth

2019-06-05 15:39:44 -04:00

tty.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00

url.js

tools: enable block-scoped-var eslint rule

2019-05-10 16:58:49 +02:00

util.js

lib: require globals instead of using the global proxy

2019-04-16 04:24:26 +08:00

v8.js

src: export number_of_native_contexts and number_of_detached_contexts

2019-05-30 15:25:55 +02:00

vm.js

module: initialize module_wrap.callbackMap during pre-execution

2019-04-25 12:11:10 +08:00

worker_threads.js

worker: add ability to unshift message from MessagePort

2019-05-19 22:01:34 +02:00

zlib.js

lib: enforce the use of Object from primordials

2019-04-12 05:38:45 +02:00