mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Michaël Zasso
2be78b03c3
Adds a debug-only macro that can be used to track when a V8 fast API is called. A map of counters is maintained in in thread-local storage and an internal API can be called to get the total count associated with a call id. Specific tests are added and `crypto.timingSafeEqual` as well as internal documentation are updated to show how to use the macro and test fast API calls without running long loops. PR-URL: https://github.com/nodejs/node/pull/54317 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
102 lines
2.8 KiB
C++
102 lines
2.8 KiB
C++
#include "node_debug.h"
|
|
|
|
#ifdef DEBUG
|
|
#include "node_binding.h"
|
|
|
|
#include "env-inl.h"
|
|
#include "util.h"
|
|
#include "v8-fast-api-calls.h"
|
|
#include "v8.h"
|
|
|
|
#include <string_view>
|
|
#include <unordered_map>
|
|
#endif // DEBUG
|
|
|
|
namespace node {
|
|
namespace debug {
|
|
|
|
#ifdef DEBUG
|
|
using v8::Context;
|
|
using v8::FastApiCallbackOptions;
|
|
using v8::FunctionCallbackInfo;
|
|
using v8::Local;
|
|
using v8::Number;
|
|
using v8::Object;
|
|
using v8::Value;
|
|
|
|
thread_local std::unordered_map<std::string_view, int> v8_fast_api_call_counts;
|
|
|
|
void TrackV8FastApiCall(std::string_view key) {
|
|
v8_fast_api_call_counts[key]++;
|
|
}
|
|
|
|
int GetV8FastApiCallCount(std::string_view key) {
|
|
return v8_fast_api_call_counts[key];
|
|
}
|
|
|
|
void GetV8FastApiCallCount(const FunctionCallbackInfo<Value>& args) {
|
|
Environment* env = Environment::GetCurrent(args);
|
|
if (!args[0]->IsString()) {
|
|
env->ThrowError("getV8FastApiCallCount must be called with a string");
|
|
return;
|
|
}
|
|
Utf8Value utf8_key(env->isolate(), args[0]);
|
|
args.GetReturnValue().Set(GetV8FastApiCallCount(utf8_key.ToString()));
|
|
}
|
|
|
|
void SlowIsEven(const FunctionCallbackInfo<Value>& args) {
|
|
Environment* env = Environment::GetCurrent(args);
|
|
if (!args[0]->IsNumber()) {
|
|
env->ThrowError("isEven must be called with a number");
|
|
return;
|
|
}
|
|
int64_t value = args[0].As<Number>()->Value();
|
|
args.GetReturnValue().Set(value % 2 == 0);
|
|
}
|
|
|
|
bool FastIsEven(Local<Value> receiver,
|
|
const int64_t value,
|
|
// NOLINTNEXTLINE(runtime/references)
|
|
FastApiCallbackOptions& options) {
|
|
TRACK_V8_FAST_API_CALL("debug.isEven");
|
|
return value % 2 == 0;
|
|
}
|
|
|
|
void SlowIsOdd(const FunctionCallbackInfo<Value>& args) {
|
|
Environment* env = Environment::GetCurrent(args);
|
|
if (!args[0]->IsNumber()) {
|
|
env->ThrowError("isOdd must be called with a number");
|
|
return;
|
|
}
|
|
int64_t value = args[0].As<Number>()->Value();
|
|
args.GetReturnValue().Set(value % 2 != 0);
|
|
}
|
|
|
|
bool FastIsOdd(Local<Value> receiver,
|
|
const int64_t value,
|
|
// NOLINTNEXTLINE(runtime/references)
|
|
FastApiCallbackOptions& options) {
|
|
TRACK_V8_FAST_API_CALL("debug.isOdd");
|
|
return value % 2 != 0;
|
|
}
|
|
|
|
static v8::CFunction fast_is_even(v8::CFunction::Make(FastIsEven));
|
|
static v8::CFunction fast_is_odd(v8::CFunction::Make(FastIsOdd));
|
|
|
|
void Initialize(Local<Object> target,
|
|
Local<Value> unused,
|
|
Local<Context> context,
|
|
void* priv) {
|
|
SetMethod(context, target, "getV8FastApiCallCount", GetV8FastApiCallCount);
|
|
SetFastMethod(context, target, "isEven", SlowIsEven, &fast_is_even);
|
|
SetFastMethod(context, target, "isOdd", SlowIsOdd, &fast_is_odd);
|
|
}
|
|
#endif // DEBUG
|
|
|
|
} // namespace debug
|
|
} // namespace node
|
|
|
|
#ifdef DEBUG
|
|
NODE_BINDING_CONTEXT_AWARE_INTERNAL(debug, node::debug::Initialize)
|
|
#endif // DEBUG
|