mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Anna Henningsen
22c826f5aa
At least one method on a native object is added as a getter, namely `MessagePort.prototype.onmessage`. When a MessagePort attempts to call this method from C++ in response to receiving data, it will first invoke that getter and then call the function. Since `worker.terminate()` interrupts execution, this means that the getter may fail (without being faulty code on its own). This means that at least one test exercising these methods in combination has been flaky and could have crashed, because we did not actually check that the getter returns a value so far, resulting in dereferencing an empty `Local`. The proper fix for this is to use the non-deprecated overload of `Get()` and check the result like we should be doing. Also, as a (related) fix, don’t crash if the method is not a function but rather something else, like a getter could provide. Example test failure: https://ci.nodejs.org/job/node-test-commit-linux-containered/4976/nodes=ubuntu1604_sharedlibs_zlib_x64/console 17:56:56 not ok 1955 parallel/test-worker-dns-terminate 17:56:56 --- 17:56:56 duration_ms: 1.237 17:56:56 severity: crashed 17:56:56 exitcode: -11 17:56:56 stack: |- PR-URL: https://github.com/nodejs/node/pull/21189 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Node.js Core Tests
This directory contains code and data used to test the Node.js implementation.
For a detailed guide on how to write tests in this directory, see the guide on writing tests.
On how to run tests in this directory, see the contributing guide.
For the tests to successfully run on Windows, Node.js has to be checked out from
GitHub with the autocrlf git config flag set to true.
Test Directories
| Directory | Runs on CI | Purpose |
|---|---|---|
| abort | Yes | Tests for when the --abort-on-uncaught-exception flag is used. |
| addons | Yes | Tests for addon functionality along with some tests that require an addon to function properly. |
| cctest | Yes | C++ test that is run as part of the build process. |
| common | Common modules shared among many tests. Documentation | |
| es-module | Yes | Test ESM module loading. |
| fixtures | Test fixtures used in various tests throughout the test suite. | |
| gc | No | Tests for garbage collection related functionality. |
| internet | No | Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections. |
| known_issues | Yes | Tests reproducing known issues within the system. All tests inside of this directory are expected to fail consistently. If a test doesn't fail on certain platforms, those should be skipped via known_issues.status. |
| message | Yes | Tests for messages that are output for various conditions (console.log, error messages etc.) |
| parallel | Yes | Various tests that are able to be run in parallel. |
| pseudo-tty | Yes | Tests that require stdin/stdout/stderr to be a TTY. |
| pummel | No | Various tests for various modules / system functionality operating under load. |
| sequential | Yes | Various tests that are run sequentially. |
| testpy | Test configuration utility used by various test suites. | |
| tick-processor | No | Tests for the V8 tick processor integration. The tests are for the logic in lib/internal/v8_prof_processor.js and lib/internal/v8_prof_polyfill.js. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic. |
| timers | No | Tests for timing utilities (setTimeout and setInterval). |
When a new test directory is added, make sure to update the CI_JS_SUITES
variable in the Makefile and the js_test_suites variable in
vcbuild.bat.