mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Yagiz Nizipli
25c0c8e18a
Promote DEP0195 from documentation-only to a runtime deprecation. Calling node:http constructors without `new` now emits DEP0195 via deprecateInstantiation. This covers Agent, Server, OutgoingMessage, IncomingMessage, ServerResponse, and ClientRequest. Update in-tree tests that called Server/Agent without `new` to use the keyword, and add a dedicated DEP0195 coverage test. Refs: https://github.com/nodejs/node/pull/58518 Assisted-by: Grok Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/64853 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
95 lines
2.5 KiB
JavaScript
95 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const http = require('http');
|
|
|
|
|
|
let serverSocket = null;
|
|
const server = http.createServer(common.mustCallAtLeast(function(req, res) {
|
|
// They should all come in on the same server socket.
|
|
if (serverSocket) {
|
|
assert.strictEqual(req.socket, serverSocket);
|
|
} else {
|
|
serverSocket = req.socket;
|
|
}
|
|
|
|
res.end(req.url);
|
|
}));
|
|
server.listen(0, function() {
|
|
makeRequest(expectRequests);
|
|
});
|
|
|
|
const agent = new http.Agent({ keepAlive: true });
|
|
|
|
|
|
let clientSocket = null;
|
|
const expectRequests = 10;
|
|
let actualRequests = 0;
|
|
|
|
|
|
function makeRequest(n) {
|
|
if (n === 0) {
|
|
server.close();
|
|
agent.destroy();
|
|
return;
|
|
}
|
|
|
|
const req = http.request({
|
|
port: server.address().port,
|
|
path: `/${n}`,
|
|
agent: agent
|
|
});
|
|
|
|
req.end();
|
|
|
|
req.on('socket', common.mustCall((sock) => {
|
|
if (clientSocket) {
|
|
assert.strictEqual(sock, clientSocket);
|
|
} else {
|
|
clientSocket = sock;
|
|
}
|
|
}));
|
|
|
|
req.on('response', common.mustCall((res) => {
|
|
let data = '';
|
|
res.setEncoding('utf8');
|
|
res.on('data', function(c) {
|
|
data += c;
|
|
});
|
|
res.on('end', common.mustCall(() => {
|
|
assert.strictEqual(data, `/${n}`);
|
|
setTimeout(function() {
|
|
actualRequests++;
|
|
makeRequest(n - 1);
|
|
}, 1);
|
|
}));
|
|
}));
|
|
}
|
|
|
|
process.on('exit', function() {
|
|
assert.strictEqual(actualRequests, expectRequests);
|
|
console.log('ok');
|
|
});
|