Files
node/test/parallel/test-http2-client-setLocalWindowSize.js
T
Matteo Collina 1576cb83b4 http2: increase default window sizes
Increase the default HTTP/2 stream window from 64KB (65535) to 4MB
(4194304) and the default local connection window to 32MB (33554432).

The default 64KB window limits throughput on high-latency connections
to window_size / RTT. With a 250ms RTT, throughput is limited to
256KB/s. The new defaults improve throughput to 16MB/s (128Mbps)
for the stream window and 128MB/s (1Gbps) for the connection window.

Fixes: https://github.com/nodejs/node/issues/38426
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/64623
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2026-08-04 14:01:33 +00:00

121 lines
3.4 KiB
JavaScript

'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const http2 = require('http2');
{
const server = http2.createServer();
server.on('stream', common.mustNotCall((stream) => {
stream.respond();
stream.end('ok');
}));
const types = {
boolean: true,
function: () => {},
number: 1,
object: {},
array: [],
null: null,
};
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
client.on('connect', common.mustCall(() => {
const outOfRangeNum = 2 ** 32;
assert.throws(
() => client.setLocalWindowSize(outOfRangeNum),
{
name: 'RangeError',
code: 'ERR_OUT_OF_RANGE',
message: 'The value of "windowSize" is out of range.' +
' It must be >= 0 && <= 2147483647. Received ' + outOfRangeNum
}
);
// Throw if something other than number is passed to setLocalWindowSize
Object.entries(types).forEach(([type, value]) => {
if (type === 'number') {
return;
}
assert.throws(
() => client.setLocalWindowSize(value),
{
name: 'TypeError',
code: 'ERR_INVALID_ARG_TYPE',
message: 'The "windowSize" argument must be of type number.' +
common.invalidArgTypeHelper(value)
}
);
});
server.close();
client.close();
}));
}));
}
{
const server = http2.createServer();
server.on('stream', common.mustNotCall((stream) => {
stream.respond();
stream.end('ok');
}));
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
client.on('connect', common.mustCall(() => {
const windowSize = 2 ** 20;
client.setLocalWindowSize(windowSize);
assert.strictEqual(client.state.effectiveLocalWindowSize, windowSize);
// localWindowSize returns the available connection window.
// When decreasing from the default 33554432 to 1048576,
// the available window stays at 33554432.
assert.strictEqual(client.state.localWindowSize, 33554432);
// remoteWindowSize is the connection-level send window,
// which remains at the HTTP/2 default of 65535.
assert.strictEqual(client.state.remoteWindowSize, 65535);
server.close();
client.close();
}));
}));
}
{
const server = http2.createServer();
server.on('stream', common.mustNotCall((stream) => {
stream.respond();
stream.end('ok');
}));
server.listen(0, common.mustCall(() => {
const client = http2.connect(`http://localhost:${server.address().port}`);
client.on('connect', common.mustCall(() => {
const windowSize = 20;
client.setLocalWindowSize(windowSize);
assert.strictEqual(client.state.effectiveLocalWindowSize, windowSize);
// localWindowSize returns the available connection window.
// When decreasing from the default 33554432 to 20,
// the available window stays at 33554432.
assert.strictEqual(client.state.localWindowSize, 33554432);
// remoteWindowSize is the connection-level send window,
// which remains at the HTTP/2 default of 65535.
assert.strictEqual(client.state.remoteWindowSize, 65535);
server.close();
client.close();
}));
}));
}