mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Matteo Collina
1576cb83b4
Increase the default HTTP/2 stream window from 64KB (65535) to 4MB (4194304) and the default local connection window to 32MB (33554432). The default 64KB window limits throughput on high-latency connections to window_size / RTT. With a 250ms RTT, throughput is limited to 256KB/s. The new defaults improve throughput to 16MB/s (128Mbps) for the stream window and 128MB/s (1Gbps) for the connection window. Fixes: https://github.com/nodejs/node/issues/38426 Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/64623 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
74 lines
2.4 KiB
JavaScript
74 lines
2.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const { PADDING_STRATEGY_ALIGNED, PADDING_STRATEGY_CALLBACK } = http2.constants;
|
|
const { duplexPair } = require('stream');
|
|
|
|
{
|
|
const testData = '<h1>Hello World.</h1>';
|
|
const server = http2.createServer({
|
|
paddingStrategy: PADDING_STRATEGY_ALIGNED
|
|
});
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
stream.respond({
|
|
'content-type': 'text/html',
|
|
':status': 200
|
|
});
|
|
stream.end(testData);
|
|
}));
|
|
|
|
const [ clientSide, serverSide ] = duplexPair();
|
|
|
|
// The lengths of the expected writes... note that this is highly
|
|
// sensitive to how the internals are implemented.
|
|
const serverLengths = [24, 15, 9, 13, 32];
|
|
const clientLengths = [15, 13, 9, 48, 9, 1, 21, 1];
|
|
|
|
// Adjust for the 24-byte preamble, 15-byte settings frame (with
|
|
// initialWindowSize), 13-byte window update frame, and 9-byte settings
|
|
// ack, and the result must be equally divisible by 8
|
|
assert.strictEqual(
|
|
(serverLengths.reduce((i, n) => i + n) - 24 - 15 - 13 - 9) % 8, 0);
|
|
|
|
// Adjust for the 15-byte settings frame (with initialWindowSize),
|
|
// 13-byte window update frame, and 9-byte settings ack, and the result
|
|
// must be equally divisible by 8
|
|
assert.strictEqual(
|
|
(clientLengths.reduce((i, n) => i + n) - 15 - 13 - 9) % 8, 0);
|
|
|
|
serverSide.on('data', common.mustCall((chunk) => {
|
|
assert.strictEqual(chunk.length, serverLengths.shift());
|
|
}, serverLengths.length));
|
|
clientSide.on('data', common.mustCall((chunk) => {
|
|
assert.strictEqual(chunk.length, clientLengths.shift());
|
|
}, clientLengths.length));
|
|
|
|
server.emit('connection', serverSide);
|
|
|
|
const client = http2.connect('http://localhost:80', {
|
|
paddingStrategy: PADDING_STRATEGY_ALIGNED,
|
|
createConnection: common.mustCall(() => clientSide)
|
|
});
|
|
|
|
const req = client.request({ ':path': '/a' });
|
|
|
|
req.on('response', common.mustCall());
|
|
|
|
req.setEncoding('utf8');
|
|
req.on('data', common.mustCall((data) => {
|
|
assert.strictEqual(data, testData);
|
|
}));
|
|
req.on('close', common.mustCall(() => {
|
|
clientSide.destroy();
|
|
clientSide.end();
|
|
}));
|
|
req.end();
|
|
}
|
|
|
|
// PADDING_STRATEGY_CALLBACK has been aliased to mean aligned padding.
|
|
assert.strictEqual(PADDING_STRATEGY_ALIGNED, PADDING_STRATEGY_CALLBACK);
|