mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Matteo Collina
a9da9ffc04
Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: https://github.com/nodejs/node/pull/61227 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
22 lines
703 B
JavaScript
22 lines
703 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { startNewREPLServer } = require('../common/repl');
|
|
|
|
const { replServer, input } = startNewREPLServer();
|
|
|
|
// https://github.com/nodejs/node/issues/3346
|
|
// Tab-completion should be empty
|
|
input.run(['.clear', 'function () {']);
|
|
replServer.complete('arguments.', common.mustCall((err, completions) => {
|
|
assert.strictEqual(err, null);
|
|
assert.deepStrictEqual(completions, [[], 'arguments.']);
|
|
}));
|
|
|
|
input.run(['.clear', 'function () {', 'undef;']);
|
|
replServer.complete('undef.', common.mustCall((err, completions) => {
|
|
assert.strictEqual(err, null);
|
|
assert.deepStrictEqual(completions, [[], 'undef.']);
|
|
}));
|