Joyee Cheung c9578dc557 crypto: fix argument validation in crypto.timingSafeEqual fast path ...

A regression introduced by
https://github.com/nodejs/node/commit/0136bb0ee807b9789bf69e8d87e7a98e1b15f217
made it possible for the fast path to be hit with non-array-buffer
arguments despite that the fast paths could only deal with array
buffer arguments, so that it can crash with invalid arguments
once crypto.timingSafeEqual is optimized instead of throwing
validation errors as usual. This adds validation to the fast path
so that it throws correctly.

PR-URL: https://github.com/nodejs/node/pull/60538
Fixes: https://github.com/nodejs/node/issues/60537
Refs: https://github.com/nodejs-private/node-private/pull/749
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

2025-11-03 22:18:51 +00:00

..

sequential.status

test: move sea tests into test/sea

2025-10-17 12:51:59 +02:00

test-async-wrap-getasyncid.js

worker: add heap profile API

2025-09-23 12:41:47 +00:00

test-buffer-creation-regression.js

test: prepare for consistent comma-dangle lint rule

2021-04-01 23:14:29 -07:00

test-child-process-emfile.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-child-process-execsync.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-child-process-exit.js

…

test-child-process-pass-fd.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-cli-syntax-bad.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-cli-syntax-file-not-found.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-cli-syntax-good.js

test: add escapePOSIXShell util

2024-09-29 20:44:52 +00:00

test-cli-syntax-require.js

test: show more info on failure in test-cli-syntax-require.js

2023-09-12 17:02:51 +00:00

test-cluster-inspect-brk.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-cluster-net-listen-ipv6only-none.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-cluster-net-listen-ipv6only-rr.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-cluster-send-handle-large-payload.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-cpu-prof-default.js

…

test-cpu-prof-dir-absolute.js

test: use tmpdir.resolve()

2023-08-21 16:41:53 +00:00

test-cpu-prof-dir-and-name.js

test: use tmpdir.resolve()

2023-08-21 16:41:53 +00:00

test-cpu-prof-dir-relative.js

test: use tmpdir.resolve()

2023-08-21 16:41:53 +00:00

test-cpu-prof-dir-worker.js

test: use tmpdir.resolve()

2023-08-21 16:41:53 +00:00

test-cpu-prof-drained.js

…

test-cpu-prof-exit.js

…

test-cpu-prof-invalid-options.js

src: fix c++ exception on bad command line arg

2023-01-22 10:39:16 +00:00

test-cpu-prof-kill.js

…

test-cpu-prof-name.js

cli: support ${pid} placeholder in --cpu-prof-name

2025-07-24 10:28:18 +00:00

test-cpu-prof-worker-argv.js

…

test-crypto-timing-safe-equal-fast.js

crypto: fix argument validation in crypto.timingSafeEqual fast path

2025-11-03 22:18:51 +00:00

test-crypto-timing-safe-equal.js

crypto: fix argument validation in crypto.timingSafeEqual fast path

2025-11-03 22:18:51 +00:00

test-debug-prompt.js

…

test-debugger-custom-port.js

test: update startCLI to set --port=0 by default

2025-07-20 17:37:28 +00:00

test-debugger-debug-brk.js

…

test-debugger-invalid-args.js

test: update startCLI to set --port=0 by default

2025-07-20 17:37:28 +00:00

test-debugger-launch.mjs

test: update startCLI to set --port=0 by default

2025-07-20 17:37:28 +00:00

test-debugger-pid.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-deprecation-flags.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-dgram-bind-shared-ports.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-dgram-implicit-bind-failure.js

…

test-dgram-pingpong.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-diagnostic-dir-cpu-prof.js

test: use tmpdir.resolve()

2023-08-21 16:41:53 +00:00

test-diagnostic-dir-heap-prof.js

test: use tmpdir.resolve()

2023-08-21 16:41:53 +00:00

test-error-serdes.js

lib: avoid StackOverflow on serializeError

2025-04-29 21:12:29 +00:00

test-fs-opendir-recursive.js

fs: remove dirent.path

2024-11-15 00:18:05 +01:00

test-fs-readdir-recursive.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-fs-stat-sync-overflow.js

test: use spawn and spawnPromisified instead of exec

2023-08-05 07:29:53 +00:00

test-fs-watch.js

test: rely less on duplicative common test harness utilities

2025-01-25 07:23:09 +00:00

test-gc-http-client-onerror.js

test: merge ongc and gcutil into gc.js

2024-08-29 08:49:52 +01:00

test-gc-http-client-timeout.js

test: merge ongc and gcutil into gc.js

2024-08-29 08:49:52 +01:00

test-gc-http-client.js

test: merge ongc and gcutil into gc.js

2024-08-29 08:49:52 +01:00

test-get-heapsnapshot-options.js

lib: add options to the heap snapshot APIs

2022-11-08 16:19:54 +01:00

test-heapdump-flag-custom-dir.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-heapdump-flag.js

test: use assert.match instead of regexp.test

2021-08-31 18:50:16 +02:00

test-heapdump.js

v8: fix missing callback in heap utils destroy

2025-06-30 11:51:40 +00:00

test-http2-large-file.js

…

test-http2-max-session-memory.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http2-ping-flood.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http2-settings-flood.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http2-timeout-large-write-file.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http2-timeout-large-write.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http-econnrefused.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http-keep-alive-large-write.js

…

test-http-keepalive-maxsockets.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-http-regr-gh-2928.js

test: reduce the number of requests and parsers

2023-10-20 12:56:44 +00:00

test-http-server-keep-alive-timeout-slow-client-headers.js

…

test-http-server-keep-alive-timeout-slow-server.js

…

test-http-server-request-timeouts-mixed.js

test: move test-http-server-request-timeouts-mixed to sequential

2024-05-11 20:07:28 +02:00

test-https-connect-localport.js

dns: default to verbatim=true in dns.lookup()

2021-09-12 21:05:35 +02:00

test-https-server-keep-alive-timeout.js

…

test-init.js

test: rely less on duplicative common test harness utilities

2025-01-25 07:23:09 +00:00

test-inspector-network-resource.js

test: make test-inspector-network-resource sequential

2025-07-28 13:29:23 +00:00

test-inspector-open-dispose.mjs

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-inspector-port-cluster.js

test: prepare for consistent comma-dangle lint rule

2021-04-01 23:14:29 -07:00

test-module-loading.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-net-better-error-messages-port.js

net: enable autoSelectFamily by default

2023-04-05 08:31:56 -07:00

test-net-connect-econnrefused.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-net-connect-handle-econnrefused.js

net: remove redundant connecting assignment

2022-07-09 17:10:16 +01:00

test-net-connect-local-error.js

dns: default to verbatim=true in dns.lookup()

2021-09-12 21:05:35 +02:00

test-net-GH-5504.js

…

test-net-listen-shared-ports.js

lib,src: update cluster to use Parent

2021-01-05 15:41:45 -05:00

test-net-localport.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-net-reconnect-error.js

net: enable autoSelectFamily by default

2023-04-05 08:31:56 -07:00

test-net-response-size.js

test: enable no-empty ESLint rule

2022-02-05 12:58:32 +00:00

test-net-server-address.js

dns: accept 'IPv4' and 'IPv6' for family

2022-06-15 18:02:01 -04:00

test-net-server-bind.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-net-server-listen-ipv6-link-local.js

test: use valid hostnames

2024-08-25 22:16:25 +00:00

test-next-tick-error-spin.js

…

test-perf-hooks.js

test: fix incorrect calculation in test-perf-hooks.js

2025-10-18 12:21:44 +00:00

test-performance-eventloopdelay.js

test: increase spin for eventloop test on s390

2024-12-24 09:06:21 -05:00

test-pipe.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-process-title.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-process-warnings.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-repl-timeout-throw.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-require-cache-without-stat.js

…

test-resolution-inspect-brk.js

…

test-runner-run-inspect.mjs

test_runner: support using --inspect with --test

2022-09-10 17:01:42 +00:00

test-stream2-fs.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-stream2-stderr-sync.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-timers-block-eventloop.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-timers-set-interval-excludes-callback-duration.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-tls-connect.js

…

test-tls-lookup.js

test: remove unnecessary noop function args to mustCall()

2022-10-18 12:13:41 +00:00

test-tls-psk-client.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-tls-session-timeout.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-util-debug.js

util: fix debuglog.enabled not being present with callback logger

2025-09-14 00:06:57 +00:00

test-vm-break-on-sigint.js

test: move test-vm-break-on-sigint to sequential

2022-08-07 12:26:59 +00:00

test-vm-timeout-escape-promise-module-2.js

test: ensure never settling promises are detected

2023-10-23 17:55:50 +00:00

test-vm-timeout-rethrow.js

test: use assert.match instead of regexp.test

2021-08-31 18:50:16 +02:00

test-watch-mode-inspect.mjs

test: fix flaky test-watch-mode-inspect

2023-04-04 16:53:32 -07:00

test-watch-mode-watch-flags.mjs

watch: fix watch args not being properly filtered

2025-05-13 13:52:46 +00:00

test-watch-mode.mjs

src: add watch config namespace

2025-10-20 13:53:29 +02:00

test-without-async-context-frame.mjs

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-worker-eventlooputil.js

test: ensure assertions are reachable in test/sequential

2025-10-29 16:29:39 +01:00

test-worker-fshandles-error-on-termination.js

test: move tests with many workers to sequential

2022-08-07 12:44:33 +00:00

test-worker-fshandles-open-close-on-termination.js

test: move tests with many workers to sequential

2022-08-07 12:44:33 +00:00

test-worker-heapsnapshot-options.js

lib: add options to the heap snapshot APIs

2022-11-08 16:19:54 +01:00

test-worker-prof.js

test: spin longer on flaky platforms for test-worker-prof

2025-11-03 21:43:30 +00:00

test-write-heapsnapshot-options.js

lib: add options to the heap snapshot APIs

2022-11-08 16:19:54 +01:00

test-zlib-crc32-fast-api.js

zlib: implement fast path for crc32

2025-09-14 00:39:58 +00:00

testcfg.py

…