mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Timothy J Fontaine
58cc362251
The spawnsync test was written wrong, the timeout can never fire before the sync process has returned, the delta is immaterial and times when it was succeeding are not reliable cases. Instead verify that the timeout doesn't fire while the sync process is happening.
49 lines
1.9 KiB
JavaScript
49 lines
1.9 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
var spawnSync = require('child_process').spawnSync;
|
|
|
|
var TIMER = 100;
|
|
var SLEEP = 1000;
|
|
|
|
var timeout = 0;
|
|
|
|
setTimeout(function() {
|
|
timeout = process.hrtime(start);
|
|
assert.ok(stop, 'timer should not fire before process exits');
|
|
assert.strictEqual(timeout[0], 1, 'timer should take as long as sleep');
|
|
}, TIMER);
|
|
|
|
console.log('sleep started');
|
|
var start = process.hrtime();
|
|
var ret = spawnSync('sleep', ['1']);
|
|
var stop = process.hrtime(start);
|
|
assert.strictEqual(ret.status, 0, 'exit status should be zero');
|
|
console.log('sleep exited', stop);
|
|
assert.strictEqual(stop[0], 1, 'sleep should not take longer or less than 1 second');
|
|
|
|
// Error test when command does not exist
|
|
var ret_err = spawnSync('command_does_not_exist');
|
|
assert.strictEqual(ret_err.error.code, 'ENOENT');
|