Matteo Collina
28995396b2
The spec's [[backpressureChangePromise]] is only ever observed by the transform source pull algorithm (settles when backpressure next becomes true) and by a sink write arriving under backpressure (settles when it next becomes false), both internal. Replace the promise record with direct continuation delivery: a parked pull is completed by enqueueing the readable controller's pull-fulfilled step on the shared resolved promise, and a parked write by a cached per-stream continuation that resolves the sink promise with the perform-transform promise, so adoption reproduces the previous derived-chain settle depth exactly. Each delivery lands at the same microtask position as the old record's reaction. transformStreamDefaultControllerPerformTransform now mirrors the reference implementation's promiseCall().then(undefined, rejection steps) directly instead of running an async wrapper pair per chunk: the transformer.transform callback is wrapped raw, a non-thenable result reuses the shared resolved promise, and a synchronous throw is delivered through a rejected promise, keeping the error timing inside a reaction. A pipe-through benchmark is added since the suite had no transform-throughput row. pipeThrough passthrough improves by ~8% and a writer-driven transform loop by ~14%; the pipe-to and read families are unchanged. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/65143 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Node.js Core Benchmarks
This folder contains code and data used to measure performance of different Node.js implementations and different ways of writing JavaScript run by the built-in JavaScript engine.
For a detailed guide on how to write and run benchmarks in this directory, see the guide on benchmarks.
Table of Contents
File tree structure
Directories
Benchmarks testing the performance of a single node submodule are placed into a
directory with the corresponding name, so that they can be executed by submodule
or individually.
Benchmarks that span multiple submodules may either be placed into the misc
directory or into a directory named after the feature they benchmark.
E.g. benchmarks for various new ECMAScript features and their pre-ES2015
counterparts are placed in a directory named es.
Fixtures that are not specific to a certain benchmark but can be reused
throughout the benchmark suite should be placed in the fixtures directory.
Other Top-level files
The top-level files include common dependencies of the benchmarks and the tools for launching benchmarks and visualizing their output. The actual benchmark scripts should be placed in their corresponding directories.
_benchmark_progress.js: implements the progress bar displayed when runningcompare.js_cli.js: parses the command line arguments passed tocompare.js,run.jsandscatter.js_cli.R: parses the command line arguments passed tocompare.R_http-benchmarkers.js: selects and runs external tools for benchmarking thehttpsubsystem.bar.R: R script for visualizing the output of benchmarks with bar plots.common.js: see Common API.compare.js: command line tool for comparing performance between different Node.js binaries.compare.R: R script for statistically analyzing the output ofcompare.jsrun.js: command line tool for running individual benchmark suite(s).scatter.js: command line tool for comparing the performance between different parameters in benchmark configurations, for example to analyze the time complexity.scatter.R: R script for visualizing the output ofscatter.jswith scatter plots.
Common API
The common.js module is used by benchmarks for consistency across repeated tasks. It has a number of helpful functions and properties to help with writing benchmarks.
createBenchmark(fn, configs[, options])
See the guide on writing benchmarks.
default_http_benchmarker
The default benchmarker used to run HTTP benchmarks. See the guide on writing HTTP benchmarks.
PORT
The default port used to run HTTP benchmarks. See the guide on writing HTTP benchmarks.
sendResult(data)
Used in special benchmarks that can't use createBenchmark and the object
it returns to accomplish what they need. This function reports timing
data to the parent process (usually created by running compare.js, run.js or
scatter.js).