Anatoli Papirovski e782715d0a string_decoder: fix regressions ...

There are libraries which invoke StringDecoder using .call and
.inherits, which directly conflicts with making StringDecoder
be a class which can only be invoked with the new keyword.
Revert to declaring it as a function.

StringDecoder#lastNeed was not defined, redefine it using
the new interface and fix StringDecoder#lastTotal.

PR-URL: https://github.com/nodejs/node/pull/18723
Refs: https://github.com/nodejs/node/pull/18537
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

2018-02-13 08:03:23 -05:00

..

internal

path: replace "magic" numbers by readable constants

2018-02-12 20:12:40 +01:00

_http_agent.js

lib: replace string concatenation with template

2017-11-11 10:52:23 +01:00

_http_client.js

http: remove domain specific code

2018-02-04 08:23:26 -05:00

_http_common.js

http: add options to http.createServer()

2018-02-06 15:40:24 +01:00

_http_incoming.js

tools: enable additional eslint rules

2017-10-19 13:54:14 -04:00

_http_outgoing.js

http: there is no corked property of stream

2018-01-27 00:46:21 -05:00

_http_server.js

http: add options to http.createServer()

2018-02-06 15:40:24 +01:00

_stream_duplex.js

stream: rm {writeable/readable}State.length

2017-12-18 14:41:43 +01:00

_stream_passthrough.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

_stream_readable.js

stream: always defer readable in EOF when sync

2018-02-08 11:58:04 +01:00

_stream_transform.js

stream: delete unused code

2018-02-02 23:00:50 +01:00

_stream_wrap.js

lib: move _stream_wrap into internals

2017-10-19 18:06:27 +02:00

_stream_writable.js

stream: fix misleading error message

2018-02-08 13:48:23 +01:00

_tls_common.js

tls: implement clientCertEngine option

2017-11-11 13:35:23 -08:00

_tls_wrap.js

tls: provide now value from C++

2018-02-07 12:21:42 -05:00

.eslintrc.yaml

tools: non-Ascii linter for /lib only

2018-02-04 16:55:13 +01:00

assert.js

assert: fix throws trace

2018-02-09 08:45:51 -05:00

async_hooks.js

lib: provide proper deprecation code

2018-02-12 13:59:09 +01:00

buffer.js

buffer: simplify check size in assertSize

2018-02-10 16:04:03 +01:00

child_process.js

util: implement util.getSystemErrorName()

2018-01-20 08:51:47 +08:00

cluster.js

lib: use consistent indentation for ternaries

2017-07-07 06:57:16 -07:00

console.js

tools: non-Ascii linter for /lib only

2018-02-04 16:55:13 +01:00

constants.js

src: add support to pass flags to dlopen

2017-09-08 17:14:03 -04:00

crypto.js

crypto: docs-only deprecate crypto.fips, replace

2018-02-02 07:50:31 -08:00

dgram.js

errors: move error creation helpers to errors.js

2018-02-07 18:42:40 +08:00

dns.js

errors: move error creation helpers to errors.js

2018-02-07 18:42:40 +08:00

domain.js

domain: runtime deprecate MakeCallback

2018-02-09 10:38:50 +01:00

events.js

lib: combine similar error codes

2017-12-24 14:09:29 +08:00

fs.js

fs: fix misplaced errors in fs.symlinkSync

2018-02-08 21:38:00 +08:00

http2.js

http2: refactor error handling

2017-08-28 00:39:42 +04:00

http.js

lib: use destructuring for some constants

2017-10-16 23:34:32 +02:00

https.js

https: add extra options to Agent#getName()

2018-02-10 14:15:57 +01:00

inspector.js

lib: enable dot-notation eslint rule

2018-01-09 10:52:18 -05:00

module.js

module: use internal/errors.js in module.require

2018-01-29 17:29:35 +08:00

net.js

net: remove Socket.prototoype.read

2018-02-08 13:38:05 -05:00

os.js

os: migrate node_os.cc to internal/errors

2017-11-02 11:58:38 -07:00

path.js

path: replace "magic" numbers by readable constants

2018-02-12 20:12:40 +01:00

perf_hooks.js

perf_hooks: add warning when too many entries in the timeline

2018-01-31 15:24:58 -08:00

process.js

…

punycode.js

…

querystring.js

querystring: convert to using internal/errors

2017-10-28 14:04:53 -04:00

readline.js

readline: use Date.now() and move test to parallel

2018-02-07 15:11:06 +01:00

repl.js

Revert "repl: refactor tests to not rely on timing"

2018-02-12 15:42:06 +01:00

stream.js

tools: non-Ascii linter for /lib only

2018-02-04 16:55:13 +01:00

string_decoder.js

string_decoder: fix regressions

2018-02-13 08:03:23 -05:00

sys.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

timers.js

timers: fix enroll deprecation wording

2018-02-11 10:34:13 -05:00

tls.js

tls: make deprecated tls.createSecurePair() use public API

2018-01-14 14:49:41 +01:00

tty.js

errors: move error creation helpers to errors.js

2018-02-07 18:42:40 +08:00

url.js

url: simplify loop in parser

2018-01-31 18:36:43 +01:00

util.js

errors: move error creation helpers to errors.js

2018-02-07 18:42:40 +08:00

v8.js

v8: migrate setFlagsFromString to internal/errors

2017-10-29 17:04:27 -07:00

vm.js

vm: add modules

2018-01-30 17:00:57 -08:00

zlib.js

tools: non-Ascii linter for /lib only

2018-02-04 16:55:13 +01:00