mirror of
https://github.com/nodejs/node.git
synced 2026-11-18 18:15:17 -05:00
Update ESLint to v3.8.0. * Installed with `npm install --production` to avoid installing unnecessary dev files * Used `dmn -f clean` to further eliminate unneeded files PR-URL: https://github.com/nodejs/node/pull/9112 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
84 lines
2.4 KiB
JavaScript
84 lines
2.4 KiB
JavaScript
/**
|
|
* @fileoverview Rule to flag when a function has too many parameters
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = {
|
|
meta: {
|
|
docs: {
|
|
description: "enforce a maximum number of parameters in function definitions",
|
|
category: "Stylistic Issues",
|
|
recommended: false
|
|
},
|
|
|
|
schema: [
|
|
{
|
|
oneOf: [
|
|
{
|
|
type: "integer",
|
|
minimum: 0
|
|
},
|
|
{
|
|
type: "object",
|
|
properties: {
|
|
maximum: {
|
|
type: "integer",
|
|
minimum: 0
|
|
},
|
|
max: {
|
|
type: "integer",
|
|
minimum: 0
|
|
}
|
|
},
|
|
additionalProperties: false
|
|
}
|
|
]
|
|
}
|
|
]
|
|
},
|
|
|
|
create(context) {
|
|
|
|
const option = context.options[0];
|
|
let numParams = 3;
|
|
|
|
if (typeof option === "object" && option.hasOwnProperty("maximum") && typeof option.maximum === "number") {
|
|
numParams = option.maximum;
|
|
}
|
|
if (typeof option === "object" && option.hasOwnProperty("max") && typeof option.max === "number") {
|
|
numParams = option.max;
|
|
}
|
|
if (typeof option === "number") {
|
|
numParams = option;
|
|
}
|
|
|
|
/**
|
|
* Checks a function to see if it has too many parameters.
|
|
* @param {ASTNode} node The node to check.
|
|
* @returns {void}
|
|
* @private
|
|
*/
|
|
function checkFunction(node) {
|
|
if (node.params.length > numParams) {
|
|
context.report(node, "This function has too many parameters ({{count}}). Maximum allowed is {{max}}.", {
|
|
count: node.params.length,
|
|
max: numParams
|
|
});
|
|
}
|
|
}
|
|
|
|
return {
|
|
FunctionDeclaration: checkFunction,
|
|
ArrowFunctionExpression: checkFunction,
|
|
FunctionExpression: checkFunction
|
|
};
|
|
|
|
}
|
|
};
|