Matteo Collina e13c138a2c http2: settle pending write callbacks on destroy ...

When a stream is destroyed while a write is still in flight, nghttp2 may
have handed the data to the socket and never report the write completion
once the stream or session tears down. That leaves the write callback
unresolved, the Writable stuck, and the event loop never drains, which
times out test-http2-close-while-writing on macOS.

Settle the in-flight write in Http2Stream._destroy by invoking its
callback with the destroy error and resetting writePending. A later
native completion callback is then a no-op because writeCb is null and
writePending is 0, so the settle is idempotent. Passing the error rather
than null also drains any buffered writes.

Fixes: https://github.com/nodejs/node/issues/58252

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Assisted-by: pi-coding-agent
PR-URL: https://github.com/nodejs/node/pull/66016
Fixes: https://github.com/nodejs/node/issues/58252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>

2026-09-15 16:06:11 +00:00

..

compat.js

http2: finish empty trailers natively for compat streams

2026-07-07 14:24:14 +00:00

core.js

http2: settle pending write callbacks on destroy

2026-09-15 16:06:11 +00:00

util.js

http2: add new connectionWindowSize option

2026-09-09 07:46:46 +00:00