mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Ben Noordhuis
992703f2b5
Replace v8::Persistent with node::Persistent, a specialization that resets the persistent handle on destruction. Prevents accidental resource leaks when forgetting to call .Reset() manually. I'm fairly confident this commit fixes a number of resource leaks that have gone undiagnosed so far. PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
31 lines
936 B
C++
31 lines
936 B
C++
#ifndef SRC_NODE_PERSISTENT_H_
|
|
#define SRC_NODE_PERSISTENT_H_
|
|
|
|
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
|
|
|
#include "v8.h"
|
|
|
|
namespace node {
|
|
|
|
template <typename T>
|
|
struct ResetInDestructorPersistentTraits {
|
|
static const bool kResetInDestructor = true;
|
|
template <typename S, typename M>
|
|
// Disallow copy semantics by leaving this unimplemented.
|
|
inline static void Copy(
|
|
const v8::Persistent<S, M>&,
|
|
v8::Persistent<T, ResetInDestructorPersistentTraits<T>>*);
|
|
};
|
|
|
|
// v8::Persistent does not reset the object slot in its destructor. That is
|
|
// acknowledged as a flaw in the V8 API and expected to change in the future
|
|
// but for now node::Persistent is the easier and safer alternative.
|
|
template <typename T>
|
|
using Persistent = v8::Persistent<T, ResetInDestructorPersistentTraits<T>>;
|
|
|
|
} // namespace node
|
|
|
|
#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
|
|
|
|
#endif // SRC_NODE_PERSISTENT_H_
|