mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Richard Lau
2d6aea7ff5
The shortened link to the commit message guidelines no longer works after they were moved from `docs/guides` to `docs/contributing`. Now that `core-validate-commit` outputs an error message pointing to the full URL of the commit message guidelines on failure we no longer need to include the URL (shortened or otherwise) in the workflow title. PR-URL: https://github.com/nodejs/node/pull/42168 Refs: https://github.com/nodejs/core-validate-commit/pull/95 Refs: https://github.com/nodejs/node/issues/41697 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
30 lines
1.0 KiB
YAML
30 lines
1.0 KiB
YAML
name: First commit message adheres to guidelines
|
|
|
|
on: [pull_request]
|
|
|
|
env:
|
|
NODE_VERSION: lts/*
|
|
|
|
jobs:
|
|
lint-commit-message:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Compute number of commits in the PR
|
|
id: nb-of-commits
|
|
run: |
|
|
echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
|
|
echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
|
|
persist-credentials: false
|
|
- run: git reset HEAD^2
|
|
- name: Install Node.js
|
|
uses: actions/setup-node@v2
|
|
with:
|
|
node-version: ${{ env.NODE_VERSION }}
|
|
- name: Validate commit message
|
|
run: |
|
|
echo "::add-matcher::.github/workflows/commit-lint-problem-matcher.json"
|
|
git rev-parse HEAD~${{ steps.nb-of-commits.outputs.minusOne }} | xargs npx -q core-validate-commit --no-validate-metadata --tap
|