Matteo Collina 0a9e96e86c stream: finish must always follow error ...

When _write completes with an Error, 'finish' was emitted before
'error' if the callback was asynchronous. This commit restore the
previous behavior.
The logic is still less then ideal, because we call the write()
callback before emitting error if asynchronous, but after if
synchronous. This commit do not try to change the behavior.
This commit fixes a regression introduced by:
https://github.com/nodejs/node/pull/13195.

Fixes: https://github.com/nodejs/node/issues/13812
PR-URL: https://github.com/nodejs/node/pull/13850
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

2017-06-24 12:19:23 +02:00

..

internal

readline,repl,url,util: remove needless capturing

2017-06-21 22:44:18 +02:00

_http_agent.js

http: overridable keep-alive behavior of Agent

2017-06-07 13:37:23 -07:00

_http_client.js

https: support rejectUnauthorized for unix sockets

2017-06-10 17:56:07 +02:00

_http_common.js

lib: implement async_hooks API in core

2017-05-10 22:22:29 +02:00

_http_incoming.js

http: suppress data event if req aborted

2017-06-05 12:19:38 -07:00

_http_outgoing.js

http: improve outgoing string write performance

2017-05-28 07:03:37 -07:00

_http_server.js

http: fix timeout reset after keep-alive timeout

2017-06-13 01:40:23 -04:00

_stream_duplex.js

stream: add destroy and _destroy methods.

2017-05-28 07:00:40 -07:00

_stream_passthrough.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

_stream_readable.js

stream: fix undefined in Readable object mode

2017-06-21 22:44:26 +02:00

_stream_transform.js

stream: add destroy and _destroy methods.

2017-05-28 07:00:40 -07:00

_stream_wrap.js

stream: ensure that instanceof fast-path is hit.

2017-06-10 17:54:43 +02:00

_stream_writable.js

stream: finish must always follow error

2017-06-24 12:19:23 +02:00

_tls_common.js

lib: correct typo in createSecureContext

2017-06-21 22:42:53 +02:00

_tls_legacy.js

test,lib,doc: use function declarations

2017-05-01 15:56:58 -07:00

_tls_wrap.js

cluster, dns, repl, tls, util: fix RegExp nits

2017-06-10 17:56:08 +02:00

.eslintrc.yaml

tools: rename eslintrc to an undeprecated format

2017-01-18 09:48:52 +05:30

assert.js

assert: fix deepEqual similar sets and maps bug

2017-06-07 13:28:35 -07:00

async_hooks.js

async_hooks: minor refactor to callback invocation

2017-06-10 17:53:22 +02:00

buffer.js

buffer: fix indexOf for empty searches

2017-05-18 23:16:40 +02:00

child_process.js

child_process: promisify includes stdio in error

2017-06-10 17:54:44 +02:00

cluster.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

console.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

constants.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

crypto.js

test,lib,doc: use function declarations

2017-05-01 15:56:58 -07:00

dgram.js

dgram: change parameter name in set(Multicast)TTL

2017-06-21 22:44:22 +02:00

dns.js

cluster, dns, repl, tls, util: fix RegExp nits

2017-06-10 17:56:08 +02:00

domain.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

events.js

lib: "iff" changed to "if and only if"

2017-06-07 13:30:17 -07:00

fs.js

fs: don't conflate data and callback in appendFile

2017-06-21 22:42:48 +02:00

http.js

http: use more efficient module.exports pattern

2017-03-20 16:01:31 -07:00

https.js

http: destroy sockets after keepAliveTimeout

2017-05-28 07:03:38 -07:00

inspector.js

inspector: allow --inspect=host:port from js

2017-06-07 13:31:55 -07:00

module.js

inspector: --debug* deprecation and invalidation

2017-05-29 09:35:31 -07:00

net.js

net: fix abort on bad address input

2017-06-21 22:44:20 +02:00

os.js

os: refactor os structure, add Symbol.toPrimitive

2017-05-01 11:44:56 -07:00

path.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

process.js

src: remove excessive license boilerplate

2015-01-27 16:35:05 +11:00

punycode.js

lib: remove let from for loops

2016-10-04 12:17:32 -04:00

querystring.js

querystring: improve unescapeBuffer() performance

2017-05-28 07:03:38 -07:00

readline.js

readline,repl,url,util: remove needless capturing

2017-06-21 22:44:18 +02:00

repl.js

readline,repl,url,util: remove needless capturing

2017-06-21 22:44:18 +02:00

stream.js

stream: support Uint8Array input to methods

2017-05-28 07:03:40 -07:00

string_decoder.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

sys.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

timers.js

timers: do not use user object call/apply

2017-05-12 22:18:18 -07:00

tls.js

tls: support Uint8Arrays for protocol list buffers

2017-03-27 02:08:49 +02:00

tty.js

errors,tty: migrate to use internal/errors.js

2017-06-07 13:29:51 -07:00

url.js

readline,repl,url,util: remove needless capturing

2017-06-21 22:44:18 +02:00

util.js

readline,repl,url,util: remove needless capturing

2017-06-21 22:44:18 +02:00

v8.js

v8: add a js class for Serializer/Dserializer

2017-06-12 14:20:10 +02:00

vm.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

zlib.js

zlib: revert back to Functions

2017-06-05 12:28:24 -07:00