mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
Ruben Bridgewater
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
61 lines
1.6 KiB
JavaScript
61 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
|
|
function testFd(input, errObj) {
|
|
assert.throws(() => fs.fchown(input), errObj);
|
|
assert.throws(() => fs.fchownSync(input), errObj);
|
|
}
|
|
|
|
function testUid(input, errObj) {
|
|
assert.throws(() => fs.fchown(1, input), errObj);
|
|
assert.throws(() => fs.fchownSync(1, input), errObj);
|
|
}
|
|
|
|
function testGid(input, errObj) {
|
|
assert.throws(() => fs.fchown(1, 1, input), errObj);
|
|
assert.throws(() => fs.fchownSync(1, 1, input), errObj);
|
|
}
|
|
|
|
['', false, null, undefined, {}, []].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: /fd|uid|gid/
|
|
};
|
|
testFd(input, errObj);
|
|
testUid(input, errObj);
|
|
testGid(input, errObj);
|
|
});
|
|
|
|
[Infinity, NaN].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be an integer. ' +
|
|
`Received ${input}`
|
|
};
|
|
testFd(input, errObj);
|
|
errObj.message = errObj.message.replace('fd', 'uid');
|
|
testUid(input, errObj);
|
|
errObj.message = errObj.message.replace('uid', 'gid');
|
|
testGid(input, errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be ' +
|
|
`>= 0 && <= 2147483647. Received ${input}`
|
|
};
|
|
testFd(input, errObj);
|
|
errObj.message = 'The value of "uid" is out of range. It must be >= 0 && ' +
|
|
`< 4294967296. Received ${input}`;
|
|
testUid(input, errObj);
|
|
errObj.message = errObj.message.replace('uid', 'gid');
|
|
testGid(input, errObj);
|
|
});
|