node/test/embedding at afbfccc30c8ebcd526ca1e24faa2c58c378adc2a - node

BackPup/node

0 Fork 0

mirror of https://github.com/nodejs/node.git synced 2026-11-09 15:11:11 -05:00

Files

T

Shelley Vohr 524564e4e5 src: keep the first snapshot blob alive for later isolates

`NewIsolate()` creates every isolate from the snapshot blob the first
isolate in the process used, because V8 shares the read-only heap
between isolates, and did so by keeping a pointer to the first
`CreateParams`. When that blob came from an `EmbedderSnapshotData` the
embedder had since released, e.g. a second
`CommonEnvironmentSetup::CreateFromSnapshot()` after the first setup and
its snapshot were destroyed, V8 deserialized freed memory.

Record the first blob and external references under a mutex instead of
copying the caller's `CreateParams`, and make `~SnapshotData()` leave
that one blob allocated, since its owner can go away before the last
isolate is created. Nothing is copied and `node` itself is unaffected.
embedtest grows an `--embedder-run-twice` switch so the sequence can be
tested.

Refs: https://github.com/nodejs/node/pull/45885
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65779
Refs: https://github.com/nodejs/node/pull/32984
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

2026-09-11 18:29:11 +00:00

embedtest.cc

src: keep the first snapshot blob alive for later isolates

2026-09-11 18:29:11 +00:00

shared_embedtest.cc

build,test: add tests for binary linked with shared libnode

2026-01-28 15:02:55 +00:00

test-embedding-builtin-code-cache-harvest.js

src: let embedders supply a builtin code cache without a snapshot

2026-09-02 14:04:24 +00:00

test-embedding-create-require-fs.js

test: split test-embedding.js and run tests in parallel