mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
Denys Otrishko
c66e6471e7
This will be a start to generalize all argument validation errors. As currently we throw ARG/OPT, OUT_OF_RANGE, and other more specific errors. The OPT errors didn't bring much to the errors as it's just another variant of ARG error which is sometimes more confusing (some of our code used OPT errors to denote just argument validation errors presumably because of similarity of OPT to 'option' and not 'options-object') and they don't specify the name of the options object where the invalid value is located. Much better approach would be to just specify path to the invalid value in the name of the value as it is done in this PR (i.e. 'options.format', 'options.publicKey.type' etc) Also since this decreases a variety of errors we have it'd be easier to reuse validation code across the codebase. Refs: https://github.com/nodejs/node/pull/31251 Refs: https://github.com/nodejs/node/pull/34070#discussion_r467251009 Signed-off-by: Denys Otrishko <shishugi@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34682 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
98 lines
3.2 KiB
JavaScript
98 lines
3.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const dns = require('dns');
|
|
const dnsPromises = dns.promises;
|
|
|
|
(async function() {
|
|
let res;
|
|
|
|
res = await dnsPromises.lookup(null);
|
|
assert.strictEqual(res.address, null);
|
|
assert.strictEqual(res.family, 4);
|
|
|
|
res = await dnsPromises.lookup('127.0.0.1');
|
|
assert.strictEqual(res.address, '127.0.0.1');
|
|
assert.strictEqual(res.family, 4);
|
|
|
|
res = await dnsPromises.lookup('::1');
|
|
assert.strictEqual(res.address, '::1');
|
|
assert.strictEqual(res.family, 6);
|
|
})().then(common.mustCall());
|
|
|
|
// Try resolution without hostname.
|
|
dns.lookup(null, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.strictEqual(result, null);
|
|
assert.strictEqual(addressType, 4);
|
|
}));
|
|
|
|
dns.lookup('127.0.0.1', common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.strictEqual(result, '127.0.0.1');
|
|
assert.strictEqual(addressType, 4);
|
|
}));
|
|
|
|
dns.lookup('::1', common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.strictEqual(result, '::1');
|
|
assert.strictEqual(addressType, 6);
|
|
}));
|
|
|
|
[
|
|
// Try calling resolve with an unsupported type.
|
|
'HI',
|
|
// Try calling resolve with an unsupported type that's an object key
|
|
'toString',
|
|
].forEach((val) => {
|
|
const err = {
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'TypeError',
|
|
message: `The argument 'rrtype' is invalid. Received '${val}'`,
|
|
};
|
|
|
|
assert.throws(
|
|
() => dns.resolve('www.google.com', val),
|
|
err
|
|
);
|
|
|
|
assert.throws(() => dnsPromises.resolve('www.google.com', val), err);
|
|
});
|
|
|
|
// Windows doesn't usually have an entry for localhost 127.0.0.1 in
|
|
// C:\Windows\System32\drivers\etc\hosts
|
|
// so we disable this test on Windows.
|
|
// IBMi reports `ENOTFOUND` when get hostname by address 127.0.0.1
|
|
if (!common.isWindows && !common.isIBMi) {
|
|
dns.reverse('127.0.0.1', common.mustCall(function(error, domains) {
|
|
assert.ifError(error);
|
|
assert.ok(Array.isArray(domains));
|
|
}));
|
|
|
|
(async function() {
|
|
assert.ok(Array.isArray(await dnsPromises.reverse('127.0.0.1')));
|
|
})().then(common.mustCall());
|
|
}
|