mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Anna Henningsen
2fb168f756
Heap dumps are used for analyzing the relationship between
objects that keep each other alive, so that retainers of
memory can be detected and memory leaks fixed.
6e60ab744e broke this for a wide range of `BaseObject`
instances. Marking all `BaseObject`s, including weak ones,
as children of `Realm` and `Environment` instances gives
the incorrect impression that they are held alive by those
objects, effectively hiding the "real" set of strong roots
that keep other objects alive through GC.
An upcoming change in V8 will allow us to represent this
relationship between `Realm` and `Environment` and its
`BaseObject` and `CppgcMixin` instances properly.
Refs: https://github.com/v8/v8/commit/e37cadf1143a8c5bbe44c0408186b5a26cc23863
Refs: https://github.com/nodejs/node/pull/57417
Signed-off-by: Anna Henningsen <anna@addaleax.net>
PR-URL: https://github.com/nodejs/node/pull/63842
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
41 lines
1.0 KiB
C++
41 lines
1.0 KiB
C++
#include "cppgc_helpers.h"
|
|
#include "env-inl.h"
|
|
|
|
namespace node {
|
|
|
|
void CppgcWrapperList::Cleanup() {
|
|
for (auto node : *this) {
|
|
CppgcMixin* ptr = node->persistent.Get();
|
|
if (ptr != nullptr) {
|
|
ptr->Finalize();
|
|
}
|
|
}
|
|
}
|
|
|
|
void CppgcWrapperList::MemoryInfo(MemoryTracker* tracker) const {
|
|
for (auto node : *this) {
|
|
CppgcMixin* ptr = node->persistent.Get();
|
|
if (ptr != nullptr) {
|
|
// TODO(addaleax): Add weak edges instead of no edges once
|
|
// https://github.com/v8/v8/commit/e37cadf1143a8c5bbe44c0408186b5a26cc23863
|
|
// is available for us
|
|
tracker->Track(ptr, MemoryTracker::kWeakEdge);
|
|
}
|
|
}
|
|
}
|
|
|
|
void CppgcWrapperList::PurgeEmpty() {
|
|
for (auto weak_it = begin(); weak_it != end();) {
|
|
CppgcWrapperListNode* node = *weak_it;
|
|
auto next_it = ++weak_it;
|
|
// The underlying cppgc wrapper has already been garbage collected.
|
|
// Remove it from the list.
|
|
if (!node->persistent) {
|
|
node->persistent.Clear();
|
|
delete node;
|
|
}
|
|
weak_it = next_it;
|
|
}
|
|
}
|
|
} // namespace node
|