mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Ben Noordhuis
3a1bc067d4
This reverts commit 3c44100558.
Reverted for breaking node-heapdump[0].
AsyncWrap assigns a class id but does not set a v8::RetainedObjectInfo
provider callback with v8::HeapProfiler::SetWrapperClassInfoProvider().
The result is a null pointer dereference when taking a heap snapshot.
It can probably be solved by setting a generic provider callback inside
the AsyncWrap constructor but that may have performance ramifications
that need to be investigated first. I move to revert it for now.
[0] https://github.com/bnoordhuis/node-heapdump
PR-URL: https://github.com/nodejs/io.js/pull/1827
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
52 lines
1.4 KiB
C++
52 lines
1.4 KiB
C++
#ifndef SRC_BASE_OBJECT_H_
|
|
#define SRC_BASE_OBJECT_H_
|
|
|
|
#include "v8.h"
|
|
|
|
namespace node {
|
|
|
|
class Environment;
|
|
|
|
class BaseObject {
|
|
public:
|
|
BaseObject(Environment* env, v8::Local<v8::Object> handle);
|
|
virtual ~BaseObject();
|
|
|
|
// Returns the wrapped object. Returns an empty handle when
|
|
// persistent.IsEmpty() is true.
|
|
inline v8::Local<v8::Object> object();
|
|
|
|
// The parent class is responsible for calling .Reset() on destruction
|
|
// when the persistent handle is strong because there is no way for
|
|
// BaseObject to know when the handle goes out of scope.
|
|
// Weak handles have been reset by the time the destructor runs but
|
|
// calling .Reset() again is harmless.
|
|
inline v8::Persistent<v8::Object>& persistent();
|
|
|
|
inline Environment* env() const;
|
|
|
|
// The handle_ must have an internal field count > 0, and the first
|
|
// index is reserved for a pointer to this class. This is an
|
|
// implicit requirement, but Node does not have a case where it's
|
|
// required that MakeWeak() be called and the internal field not
|
|
// be set.
|
|
template <typename Type>
|
|
inline void MakeWeak(Type* ptr);
|
|
|
|
inline void ClearWeak();
|
|
|
|
private:
|
|
BaseObject();
|
|
|
|
template <typename Type>
|
|
static inline void WeakCallback(
|
|
const v8::WeakCallbackData<v8::Object, Type>& data);
|
|
|
|
v8::Persistent<v8::Object> handle_;
|
|
Environment* env_;
|
|
};
|
|
|
|
} // namespace node
|
|
|
|
#endif // SRC_BASE_OBJECT_H_
|