Matteo Collina acf56be536 fs: guarantee order of callbacks in ws.close ...

Refactor WriteStream.prototype.close and WriteStream.prototype._destroy
to always call the callback passed to close in order. Protects from
calling .close() without a callback.

Fixes: https://github.com/nodejs/node/issues/17951
See: https://github.com/nodejs/node/pull/15407

PR-URL: https://github.com/nodejs/node/pull/18002
Fixes: https://github.com/nodejs/node/issues/17951
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

2018-01-08 09:17:16 +01:00

..

internal

lib: remove queue implementation from JSStreamWrap

2018-01-07 21:21:32 +01:00

_http_agent.js

lib: replace string concatenation with template

2017-11-11 10:52:23 +01:00

_http_client.js

async_hooks: rename initTriggerId

2017-12-19 18:04:43 +01:00

_http_common.js

http: simplify checkIsHttpToken()

2017-12-10 16:50:47 -05:00

_http_incoming.js

tools: enable additional eslint rules

2017-10-19 13:54:14 -04:00

_http_outgoing.js

http: remove duplicate export

2018-01-04 18:22:59 -06:00

_http_server.js

http: add rawPacket in err of clientError event

2017-12-27 19:42:57 +01:00

_stream_duplex.js

stream: rm {writeable/readable}State.length

2017-12-18 14:41:43 +01:00

_stream_passthrough.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

_stream_readable.js

stream: rm {writeable/readable}State.length

2017-12-18 14:41:43 +01:00

_stream_transform.js

stream: migrate to internal/errors

2017-10-01 20:37:00 -03:00

_stream_wrap.js

lib: move _stream_wrap into internals

2017-10-19 18:06:27 +02:00

_stream_writable.js

stream: rm {writeable/readable}State.length

2017-12-18 14:41:43 +01:00

_tls_common.js

tls: implement clientCertEngine option

2017-11-11 13:35:23 -08:00

_tls_legacy.js

tls: comment about old-style errors

2017-12-22 09:02:05 -05:00

_tls_wrap.js

tls: set servername on client side too

2018-01-03 11:29:39 -08:00

.eslintrc.yaml

tools: add lowercase-name-for-primitive eslint rule

2017-12-13 06:23:37 +01:00

assert.js

assert: fix strict regression

2017-12-29 00:04:40 +01:00

async_hooks.js

async_hooks: rename initTriggerId

2017-12-19 18:04:43 +01:00

buffer.js

buffer: check byteLength in readUInt(B|L)E

2018-01-05 12:40:26 +01:00

child_process.js

lib: combine similar error codes

2017-12-24 14:09:29 +08:00

cluster.js

lib: use consistent indentation for ternaries

2017-07-07 06:57:16 -07:00

console.js

console: make .assert standard compliant

2017-12-26 10:46:27 +01:00

constants.js

src: add support to pass flags to dlopen

2017-09-08 17:14:03 -04:00

crypto.js

crypto: migrate setFipsCrypto to internal/errors

2017-10-27 08:13:01 -07:00

dgram.js

async_hooks: use scope for defaultTriggerAsyncId

2017-12-19 18:04:52 +01:00

dns.js

dns: fix crash while setting server during query

2017-12-06 04:22:31 +01:00

domain.js

domain: fix error emit handling

2017-12-13 09:33:27 -05:00

events.js

lib: combine similar error codes

2017-12-24 14:09:29 +08:00

fs.js

fs: guarantee order of callbacks in ws.close

2018-01-08 09:17:16 +01:00

http2.js

http2: refactor error handling

2017-08-28 00:39:42 +04:00

http.js

lib: use destructuring for some constants

2017-10-16 23:34:32 +02:00

https.js

tls: implement clientCertEngine option

2017-11-11 13:35:23 -08:00

inspector.js

lib: improve the usage of TypeError[INVALID_ARG_TYPE]

2017-11-12 11:04:06 -08:00

module.js

module: Set dynamic import callback

2017-11-29 14:16:43 -08:00

net.js

http2: implement ref() and unref() on client sessions

2017-12-28 09:32:54 -08:00

os.js

os: migrate node_os.cc to internal/errors

2017-11-02 11:58:38 -07:00

path.js

benchmark,path: remove unused variables

2017-11-22 14:36:38 -08:00

perf_hooks.js

http2: perf_hooks integration

2018-01-02 08:56:30 -08:00

process.js

src: remove excessive license boilerplate

2015-01-27 16:35:05 +11:00

punycode.js

lib: remove let from for loops

2016-10-04 12:17:32 -04:00

querystring.js

querystring: convert to using internal/errors

2017-10-28 14:04:53 -04:00

readline.js

readline: update references to archived repository

2018-01-03 18:22:52 +01:00

repl.js

repl: refactor code for readability

2018-01-04 21:21:22 +01:00

stream.js

lib: use destructuring for some constants

2017-10-16 23:34:32 +02:00

string_decoder.js

lib: use destructuring for some constants

2017-10-16 23:34:32 +02:00

sys.js

meta: restore original copyright header

2017-03-10 11:23:48 -08:00

timers.js

timers: refactor setImmediate error handling

2018-01-02 11:16:33 -05:00

tls.js

doc: document tls.checkServerIdentity

2017-12-01 20:44:52 +01:00

tty.js

tty: refactor exports

2017-11-14 17:31:26 -05:00

url.js

lib: improve the usage of TypeError[INVALID_ARG_TYPE]

2017-11-12 11:04:06 -08:00

util.js

util: improve error message of _errnoException

2017-12-29 12:33:34 +08:00

v8.js

v8: migrate setFlagsFromString to internal/errors

2017-10-29 17:04:27 -07:00

vm.js

vm: allow modifying context name in inspector

2017-12-23 14:05:18 +08:00

zlib.js

zlib: add ArrayBuffer support

2017-12-13 06:23:23 +01:00