mirror of
https://github.com/nodejs/node.git
synced 2026-10-14 10:26:26 -04:00
Michaël Zasso
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
48 lines
1.5 KiB
JavaScript
48 lines
1.5 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const dnstools = require('../common/dns');
|
|
const dns = require('dns');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
const dnsPromises = dns.promises;
|
|
|
|
const server = dgram.createSocket('udp4');
|
|
|
|
server.on('message', common.mustCall((msg, { address, port }) => {
|
|
const parsed = dnstools.parseDNSPacket(msg);
|
|
const domain = parsed.questions[0].domain;
|
|
assert.strictEqual(domain, 'example.org');
|
|
|
|
const buf = dnstools.writeDNSPacket({
|
|
id: parsed.id,
|
|
questions: parsed.questions,
|
|
answers: { type: 'A', address: '1.2.3.4', ttl: 123, domain },
|
|
});
|
|
// Overwrite the # of answers with 2, which is incorrect.
|
|
buf.writeUInt16LE(2, 6);
|
|
server.send(buf, port, address);
|
|
}, 2));
|
|
|
|
server.bind(0, common.mustCall(async () => {
|
|
const address = server.address();
|
|
dns.setServers([`127.0.0.1:${address.port}`]);
|
|
|
|
dnsPromises.resolveAny('example.org')
|
|
.then(common.mustNotCall())
|
|
.catch(common.expectsError({
|
|
code: 'EBADRESP',
|
|
syscall: 'queryAny',
|
|
hostname: 'example.org'
|
|
}));
|
|
|
|
dns.resolveAny('example.org', common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'EBADRESP');
|
|
assert.strictEqual(err.syscall, 'queryAny');
|
|
assert.strictEqual(err.hostname, 'example.org');
|
|
const descriptor = Object.getOwnPropertyDescriptor(err, 'message');
|
|
assert.strictEqual(descriptor.enumerable,
|
|
false, 'The error message should be non-enumerable');
|
|
server.close();
|
|
}));
|
|
}));
|