mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Luigi Pinca
8c4bd2af4f
`socket.destroy()` can destory the stream before the chunk to write with `socket.end()` is actually sent. Furthermore `socket.destroy()` destroys `p` and not the actual raw socket. As a result it is possible that the connection is left open. Remove `socket.destroy()` to ensure that the chunk is sent. Also use `common.mustCall()` to ensure that the `'secureConnection'` and `'secureConnect'` events are emitted exactly once. PR-URL: https://github.com/nodejs/node/pull/27478 Fixes: https://github.com/nodejs/node/issues/26938 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
40 lines
1.1 KiB
Plaintext
40 lines
1.1 KiB
Plaintext
prefix parallel
|
|
|
|
# To mark a test as flaky, list the test name in the appropriate section
|
|
# below, without ".js", followed by ": PASS,FLAKY". Example:
|
|
# sample-test : PASS,FLAKY
|
|
|
|
[true] # This section applies to all platforms
|
|
# https://github.com/nodejs/node/issues/23207
|
|
test-net-connect-options-port: PASS,FLAKY
|
|
# https://github.com/nodejs/node/issues/26401
|
|
test-worker-prof: PASS,FLAKY
|
|
# https://github.com/nodejs/node/issues/27553
|
|
test-tls-enable-trace-cli: PASS,FLAKY
|
|
|
|
[$system==win32]
|
|
test-http2-pipe: PASS,FLAKY
|
|
test-worker-syntax-error: PASS,FLAKY
|
|
test-worker-syntax-error-file: PASS,FLAKY
|
|
# https://github.com/nodejs/node/issues/23277
|
|
test-worker-memory: PASS,FLAKY
|
|
# https://github.com/nodejs/node/issues/20750
|
|
test-http2-client-upload: PASS,FLAKY
|
|
test-http2-client-upload-reject: PASS,FLAKY
|
|
|
|
[$system==linux]
|
|
|
|
[$system==macos]
|
|
|
|
[$arch==arm || $arch==arm64]
|
|
# https://github.com/nodejs/node/issues/26610
|
|
test-async-hooks-http-parser-destroy: PASS,FLAKY
|
|
|
|
[$system==solaris] # Also applies to SmartOS
|
|
|
|
[$system==freebsd]
|
|
# https://github.com/nodejs/node/issues/23089
|
|
test-gc-http-client-onerror: PASS,FLAKY
|
|
|
|
[$system==aix]
|