mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
brad-decker
18016d3b3f
Using NodeTodo I learned of a need to swap out the .equal function with .strictEqual in a few test files. https://twitter.com/NodeTodo/status/803657321993961472 https://gist.github.com/Trott/864401455d4afa2428cd4814e072bd7c additional commits squashed: .strictEqual's argument signature is actual, expected, [message]. Previously some statements were listed as expected, actual. As asked in PR i swapped them to match the correct argument signature. PR-URL: https://github.com/nodejs/node/pull/9842 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
43 lines
1.3 KiB
JavaScript
43 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const binding = require(`./build/${common.buildType}/binding`);
|
|
const assert = require('assert');
|
|
|
|
const skipMessage = 'intensive toString tests due to memory confinements';
|
|
if (!common.enoughTestMem) {
|
|
common.skip(skipMessage);
|
|
return;
|
|
}
|
|
|
|
// v8 fails silently if string length > v8::String::kMaxLength
|
|
// v8::String::kMaxLength defined in v8.h
|
|
const kStringMaxLength = process.binding('buffer').kStringMaxLength;
|
|
|
|
try {
|
|
var buf = Buffer.allocUnsafe(kStringMaxLength + 1);
|
|
} catch (e) {
|
|
// If the exception is not due to memory confinement then rethrow it.
|
|
if (e.message !== 'Array buffer allocation failed') throw (e);
|
|
common.skip(skipMessage);
|
|
return;
|
|
}
|
|
|
|
// Ensure we have enough memory available for future allocations to succeed.
|
|
if (!binding.ensureAllocation(2 * kStringMaxLength)) {
|
|
common.skip(skipMessage);
|
|
return;
|
|
}
|
|
|
|
assert.throws(function() {
|
|
buf.toString('latin1');
|
|
}, /"toString\(\)" failed/);
|
|
|
|
var maxString = buf.toString('latin1', 1);
|
|
assert.strictEqual(maxString.length, kStringMaxLength);
|
|
// Free the memory early instead of at the end of the next assignment
|
|
maxString = undefined;
|
|
|
|
maxString = buf.toString('latin1', 0, kStringMaxLength);
|
|
assert.strictEqual(maxString.length, kStringMaxLength);
|