mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Shelley Vohr
c5eb9deb7f
Since the V8 14.2 update, `globals.h` sizes the read-only space reservation in the shared pointer compression cage from `V8_CONTIGUOUS_COMPRESSED_RO_SPACE_SIZE_MB`, which BUILD.gn defines together with `V8_CONTIGUOUS_COMPRESSED_RO_SPACE` whenever `v8_enable_pointer_compression_shared_cage` is set. features.gypi defines neither, so builds configured with `--experimental-pointer-compression-shared-cage` fail to compile V8. Define both the way BUILD.gn does, with the same 16 MB default. Refs: https://github.com/nodejs/node/pull/60254 Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65464 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>