mirror of
https://github.com/nodejs/node.git
synced 2026-11-09 15:11:11 -05:00
Ruben Bridgewater
dca7fb2225
This makes sure the input arguments get validated so implementation errors will be caught early. It also improves a couple of error messages by providing more detailed information and fixes errors detected by the new functionality. Besides that a error type got simplified and tests got refactored. PR-URL: https://github.com/nodejs/node/pull/19924 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
118 lines
3.1 KiB
JavaScript
118 lines
3.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const filepath = fixtures.path('x.txt');
|
|
const fd = fs.openSync(filepath, 'r');
|
|
const expected = 'xyz\n';
|
|
|
|
|
|
// Error must be thrown with string
|
|
assert.throws(
|
|
() => fs.read(fd, expected.length, 0, 'utf-8', common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: 'The "buffer" argument must be one of type Buffer or Uint8Array.' +
|
|
' Received type number'
|
|
}
|
|
);
|
|
|
|
[true, null, undefined, () => {}, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
fs.read(value,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: 'The "fd" argument must be of type number. ' +
|
|
`Received type ${typeof value}`
|
|
});
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
-1,
|
|
expected.length,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "offset" is out of range. It must be >= 0 && <= 4. ' +
|
|
'Received -1'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.read(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
-1,
|
|
0,
|
|
common.mustNotCall());
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|
|
|
|
|
|
assert.throws(
|
|
() => fs.readSync(fd, expected.length, 0, 'utf-8'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: 'The "buffer" argument must be one of type Buffer or Uint8Array.' +
|
|
' Received type number'
|
|
}
|
|
);
|
|
|
|
[true, null, undefined, () => {}, {}].forEach((value) => {
|
|
assert.throws(() => {
|
|
fs.readSync(value,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: 'The "fd" argument must be of type number. ' +
|
|
`Received type ${typeof value}`
|
|
});
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
-1,
|
|
expected.length,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "offset" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.readSync(fd,
|
|
Buffer.allocUnsafe(expected.length),
|
|
0,
|
|
-1,
|
|
0);
|
|
}, {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError [ERR_OUT_OF_RANGE]',
|
|
message: 'The value of "length" is out of range. ' +
|
|
'It must be >= 0 && <= 4. Received -1'
|
|
});
|